Re: Segfault when creating partition with a primary key and sql_droptrigger exists

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: Segfault when creating partition with a primary key and sql_droptrigger exists
Дата
Msg-id
20180928031700.GE1500@paquier.xyz
Ответ на
Список
Дерево обсуждения
Segfault when creating partition with a primary key and sql_droptrigger exists Marco Slot <marco@citusdata.com>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Justin Pryzby <pryzby@telsasoft.com>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Dmitry Dolgov <9erthalion6@gmail.com>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Michael Paquier <michael@paquier.xyz>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Dmitry Dolgov <9erthalion6@gmail.com>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Michael Paquier <michael@paquier.xyz>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Michael Paquier <michael@paquier.xyz>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Dmitry Dolgov <9erthalion6@gmail.com>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Segfault when creating partition with a primary key and sql_drop trigger exists Tom Lane <tgl@sss.pgh.pa.us>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Michael Paquier <michael@paquier.xyz>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Andres Freund <andres@anarazel.de>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Michael Paquier <michael@paquier.xyz>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists "Jonathan S. Katz" <jkatz@postgresql.org>
Re: Segfault when creating partition with a primary key and sql_drop trigger exists Tom Lane <tgl@sss.pgh.pa.us>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Segfault when creating partition with a primary key and sql_drop trigger exists Tom Lane <tgl@sss.pgh.pa.us>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Michael Paquier <michael@paquier.xyz>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Arthur Zakirov <a.zakirov@postgrespro.ru>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Alvaro Herrera <alvherre@2ndquadrant.com>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Michael Paquier <michael@paquier.xyz>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists "Jonathan S. Katz" <jkatz@postgresql.org>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists Andres Freund <andres@anarazel.de>
Re: Segfault when creating partition with a primary key and sql_droptrigger exists "Jonathan S. Katz" <jkatz@postgresql.org>
On Thu, Sep 27, 2018 at 11:02:06PM +0200, Dmitry Dolgov wrote:
> Yes, you're right. Although probably it's not great that the sequence of
> EventTriggerAlterTableStart, EventTriggerAlterTableRelid and
> EventTriggerAlterTableEnd is distributed between different functions (which
> most likely is worth a comment in AlterTableInternal), but it's a minor
> concern.

I think that Alvaro should definitely look at this patch to be sure, or
I could do it, but I would need to spend way more time on this and check
event trigger interactions. 

Anyway, I was struggling a bit regarding the location where adding a
regression test.  event_trigger.sql makes the most sense but in tests
for drops the objects are created before the event trigger is defined,
so that would need to move around so as the original problem is
reproducible.  Perhaps you have an idea for that?
--
Michael
В списке pgsql-hackers по дате отправления
От: Michael Paquier
Дата:
От: Michael Paquier
Дата:
FAQ