Re: Yet another fast GiST build (typo)

Поиск
Список
Период
Сортировка
От Thomas Munro
Тема Re: Yet another fast GiST build (typo)
Дата
Msg-id CA+hUKG+UoDyKgvO9BLE7543D1Yu8qQoBHAZRDSo_ETowja6GHw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Yet another fast GiST build (typo)  ("Andrey M. Borodin" <x4mmm@yandex-team.ru>)
Ответы Re: Yet another fast GiST build (typo)  ("Andrey M. Borodin" <x4mmm@yandex-team.ru>)
Список pgsql-hackers
On Fri, Jul 10, 2020 at 6:55 PM Andrey M. Borodin <x4mmm@yandex-team.ru> wrote:
> Thanks! Fixed.

It's not a bug, but I think those 64 bit constants should be wrapped
in UINT64CONST(), following our convention.

I'm confused about these two patches: 0001 introduces
gist_point_fastcmp(), but then 0002 changes it to gist_bbox_fastcmp().
Maybe you intended to keep both of them?  Also 0002 seems to have
fixups for 0001 squashed into it.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Geoghegan
Дата:
Сообщение: Re: Default setting for enable_hashagg_disk
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions?