On Sun, Oct 2, 2016 at 9:00 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Mon, Oct 3, 2016 at 1:36 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Sat, Oct 1, 2016 at 3:33 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Copy-editing for contrib/pg_visibility documentation.
>>>
>>> Add omitted names for some function parameters.
>>> Fix some minor grammatical issues.
>>
>> Why do you keep insisting on changing case where I've written "which"
>> to instead say "that" in situations where AFAIK either is perfectly
>> correct? I find such changes at best neutral, and in some cases
>> worse.
>
> 'Which' looks OK to me too here, but I speak some kind of British
> English, and it looks like at least some writers of formal American
> English prefer 'that' here:
>
> * http://www.chicagomanualofstyle.org/qanda/data/faq/topics/Whichvs.That.html?old=Whichvs.That01.html
> * https://en.oxforddictionaries.com/usage/that-or-which
Gosh, I think "she held out the hand that was hurt" is clearly worse
than "she held out the hand which was hurt", but even if someone
prefers the opposite, correcting it as a supposed grammatical error
strikes me as arrant pedantry. You know, the kind up with which I
don't particularly wish to put.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company