On Thu, Jan 26, 2017 at 8:53 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
>> I've not done like the most careful review ever, but I'm in favor of the
>> general change (provided the byval thing is fixed obviously).
>
> Thanks for the review.
Why not use pg_ltoa and pg_lltoa like the output functions for the datatype do?
Might use CStringGetTextDatum(blah) instead of
PointerGetDatum(cstring_to_text(blah)).
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company