On Tue, Dec 2, 2014 at 8:28 PM, Peter Geoghegan <pg@heroku.com> wrote:
> On Tue, Dec 2, 2014 at 2:16 PM, Peter Geoghegan <pg@heroku.com> wrote:
>> On Tue, Dec 2, 2014 at 2:07 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>>> Well, maybe you should make the updates we've agreed on and I can take
>>> another look at it.
>>
>> Agreed.
>
> Attached, revised patchset makes these updates. I continue to use the
> sortsupport struct to convey that a given attribute of a given sort is
> abbreviation-applicable (although the field is now a bool, not an
> enum).
All right, it seems Tom is with you on that point, so after some
study, I've committed this with very minor modifications. Sorry for
the long delay. I have not committed the 0002 patch, though, because
I haven't studied that enough yet to know whether I think it's a good
idea. Perhaps that could get its own CommitFest entry and thread,
though, to separate it from this exceedingly long discussion and make
it clear exactly what we're hoping to gain by that patch specifically.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company