Re: B-Tree support function number 3 (strxfrm() optimization)

>>>>> "Robert" == Robert Haas <robertmhaas@gmail.com> writes:
Robert> All right, it seems Tom is with you on that point, so afterRobert> some study, I've committed this with very
minormodifications.
 

This caught my eye (thanks to conflict with GS patch):
* In the future, we should consider forcing the* tuplesort_begin_heap() case when the abbreviated key* optimization can
therebybe used, even when numInputs is 1.
 

The comment in tuplesort_begin_datum that abbreviation can't be used
seems wrong to me; why is the copy of the original value pointed to by
stup->tuple (in the case of by-reference types, and abbreviation is
obviously not needed for by-value types) not sufficient?

Or what am I missing?

-- 
Andrew (irc:RhodiumToad)