On Tue, Apr 15, 2014 at 10:46 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Wed, Apr 16, 2014 at 3:01 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Tue, Apr 15, 2014 at 12:33 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>> On Mon, Apr 14, 2014 at 10:03 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>>>> For the create case, I'm wondering if we should put the block that
>>>> tests for !hmap *before* the _dosmaperr() and check for EEXIST. What
>>>> is your opinion?
>>>
>>> Either way is okay, but I think the way you are suggesting is better as it
>>> will make code consistent with other place (PGSharedMemoryCreate()).
>>
>> OK, can you prepare a patch?
>
> Please find attached patch to address this issue.
> One minor point to note is that now we have to call GetLastError() twice,
> once inside error path and once to check EEXIST, but I think that is okay
> as existing code in PGSharedMemoryCreate() does it that way.
OK. I committed this blindly, but I don't have a Windows dev
environment, so please keep an eye on the Windows buildfarm members
and provide follow-on patches if any of them get unhappy about this.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company