Re: SQLAlchemy updates for check tables.

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: SQLAlchemy updates for check tables.
Дата
Msg-id CA+OCxoxcT8u9VJPp_oEML0tL7D=sXFpy=jkFBz56K1ApQ=_Pfw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: SQLAlchemy updates for check tables.  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: SQLAlchemy updates for check tables.  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers


On Mon, Jul 19, 2021 at 9:58 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Mon, Jul 19, 2021 at 2:17 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Jul 19, 2021 at 6:37 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for SQLAlchemy updates for check table is present in the database or not. (This will resolve load and dump server.)

How come this upstream change didn't fail the regression tests? 
Flask-SQLAlchemy is dependent on SQLAlchemy and which is an indirect dependency of pgAdmin, so if the installed version of Flask-SQLAlchemy is the latest one, it will be skipped.

Sure, but the regression test runs on the buildfarm build the venv from scratch on every run (as happens when we build the packages themselves). So I can see why local regression runs might have passed (as developers generally don't recreate their venv's from scratch before testing), but I would expect to have seen failures on the buildfarm. 

--

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Khushboo Vashi
Дата:
Сообщение: Re: SQLAlchemy updates for check tables.
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: Bug #6337 Patch