Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros

On Tue, Jul 14, 2009 at 8:42 PM, Jeremy Kerr<jk@ozlabs.org> wrote:
> Hi, Alvaro,
>
>> Does this work in compilers other than GCC?  I think we use some
>> kludges to protect against them ... see pg_list.h for the canonical
>> example.
>
> As I understand it, we're not using static inlines in pg_list.h to
> prevent multiple objects from exporting the same symbols if the
> functions don't end up as 'static inline' (ie, because the compiler
> doesn't support that).
>
> In this case, we're only compiling the inlines into a single object, so
> even if the compiler doesn't support inlines, we'll just end up with
> out-of-line function calls, which should work too.

Perhaps we should use macros.

...Robert