Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros

Поиск
Список
Период
Сортировка
От Jeremy Kerr
Тема Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros
Дата
Msg-id 200907201000.53416.jk@ozlabs.org
обсуждение исходный текст
Ответ на Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Hi Robert,

> Perhaps we should use macros.

I was trying to avoid macros, as this means we lose type- and syntax- 
checking at the call-site, and end up with slightly messier code. 
However, I understand that this is probably personal preference for me 
:)

How about just 'static' functions? (ie, drop the 'inline'). This way, 
the compiler is free to inline where suitable, and non-inlining 
compilers will do the right thing too.

However, I'd rather make decisions on data, rather than guessing. Is the 
actual problem here that some compilers just don't support the 'inline' 
keyword?

Cheers,


Jeremy


В списке pgsql-hackers по дате отправления:

Предыдущее
От: KaiGai Kohei
Дата:
Сообщение: Re: [PATCH] SE-PgSQL/tiny rev.2193
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros