Re: review: psql and pset without any arguments

Le 30/09/2013 05:43, Alvaro Herrera a écrit :
> Gilles Darold escribió:
>
>> +    else if (strcmp(param, "numericlocale") == 0)
>> +    {
>> +        if (popt->topt.numericLocale)
>> +            puts(_("Locale-adjusted numeric output (numericlocale) is on."));
>> +        else
>> +            puts(_("Locale-adjusted numeric output (numericlocale) is off."));
>> +    }
> Please don't make the variable name part of the translatable message.  I
> suggest using the following pattern:
>
>> +    else if (strcmp(param, "numericlocale") == 0)
>> +    {
>> +        if (popt->topt.numericLocale)
>> +            printf(_("Locale-adjusted numeric output (%s) is on."), "numericlocale");
>> +        else
>> +            printf(_("Locale-adjusted numeric output (%s) is off."), "numericlocale");
>> +    }
> Otherwise it will be too easy for the translator to make the mistake
> that the variable name needs translation too.
>

That's right, here is the patch modified with just a little change with
your suggestion:

                if (popt->topt.numericLocale)
                        printf(_("Locale-adjusted numeric output (%s) is
on.\n"), param);
                else
                        printf(_("Locale-adjusted numeric output (%s) is
off.\n"), param);


Thanks

--
Gilles Darold
Administrateur de bases de données
http://dalibo.com - http://dalibo.org