Re: review: psql and pset without any arguments

Gilles Darold escribió:

> +    else if (strcmp(param, "numericlocale") == 0)
> +    {
> +        if (popt->topt.numericLocale)
> +            puts(_("Locale-adjusted numeric output (numericlocale) is on."));
> +        else
> +            puts(_("Locale-adjusted numeric output (numericlocale) is off."));
> +    }

Please don't make the variable name part of the translatable message.  I
suggest using the following pattern:

> +    else if (strcmp(param, "numericlocale") == 0)
> +    {
> +        if (popt->topt.numericLocale)
> +            printf(_("Locale-adjusted numeric output (%s) is on."), "numericlocale");
> +        else
> +            printf(_("Locale-adjusted numeric output (%s) is off."), "numericlocale");
> +    }

Otherwise it will be too easy for the translator to make the mistake
that the variable name needs translation too.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services