Re: Synchronize with imath upstream

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Synchronize with imath upstream
Дата
Msg-id 5102.1549207886@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Synchronize with imath upstream  (Noah Misch <noah@leadboat.com>)
Ответы Re: Synchronize with imath upstream  (Noah Misch <noah@leadboat.com>)
Список pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
> The -Wno-declaration-after-statement approach takes eight lines of code, and
> the filter-out approach takes one.  On the other hand, using $(filter-out)
> changes any runs of whitespace to single spaces ("$(filter-out foo,a    b c)"
> yields "a b c").  We do risk that with CPPFLAGS and LDFLAGS in a few places.
> I don't want to proliferate that practice, because it changes semantics of
> CFLAGS containing -DFOO="arbitrary    text".

I don't particularly buy that argument, because CPPFLAGS is where any -D
switches ought to be put.  So we've already exposed ourselves to this
risk, in the unlikely scenario where it's not hypothetical.

            regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Why are we PageInit'ing buffers in RelationAddExtraBlocks()?
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Early WIP/PoC for inlining CTEs