Re: BUG: pgScript NOT thread safe!!

Поиск
Список
Период
Сортировка
От Ashesh Vashi
Тема Re: BUG: pgScript NOT thread safe!!
Дата
Msg-id 4A43BBC6.1020102@enterprisedb.com
обсуждение исходный текст
Ответ на Re: BUG: pgScript NOT thread safe!!  (Mickael Deloison <mdeloison@gmail.com>)
Список pgadmin-support
<tt>Hi Mickael/Dave,<br /><br /> Mickael Deloison wrote:</tt><blockquote
cite="mid:1f8f052b0906251055l20d2603bocd789e2eb281ee8d@mail.gmail.com"type="cite"><pre wrap=""><tt>2009/6/25 Magnus
Hagander<a class="moz-txt-link-rfc2396E" href="mailto:magnus@hagander.net"><magnus@hagander.net></a>:
 
</tt></pre><blockquote type="cite"><pre wrap=""><tt>Ashesh Vashi wrote:
</tt></pre><blockquote type="cite"><pre wrap=""><tt> Hi Dave,

This patch does the job.
But, it will not be able disable to toolbar buttons on each windows.
Introduced a static variable of type wxMutex for these operations.

Please take a look at it.
</tt></pre></blockquote><pre wrap=""><tt>I'd rather see something that throws up a messagebox informing the user
that parallel execution of pgscript is not supported, if this is the
route we have to go down.

--
 Magnus Hagander
 Self: <a class="moz-txt-link-freetext" href="http://www.hagander.net/">http://www.hagander.net/</a>
 Work: <a class="moz-txt-link-freetext" href="http://www.redpill-linpro.com/">http://www.redpill-linpro.com/</a>

</tt></pre></blockquote><pre wrap=""><tt>
Hi,

Very sorry for this bug. I did not take into account the case when one
uses 2 or more Query tool windows. If one launches two windows, it
will create two pgsApplication. However, it will use the same
Flex/Bison parser. Actually I can''t do anything about Flex & Bison
not supporting multiple threads.

So the only immediate fix I see is the one provided by Ashesh plus
showing a message box when a script is running saying that a script is
already running (Magnus suggestion). I do not currently have a
development environment up-to-date: Ashesh, could you add the message
box please?
</tt></pre></blockquote><tt>I agree.<br /> But, as the release is in one/two days, I did not want to introduce any new
message.:(<br /> (It will be added work for the translations at 11'o clock.)<br /> If you still insist, I can send the
updatedpatch.<br /></tt><tt><br /></tt><div class="moz-signature"><tt>-- <br /></tt><div class="moz-signature"><tt>
<fontcolor="#666666">Thanks & Regards,<br /> Ashesh Vashi<br /><br /> EnterpriseDB INDIA: <a
href="http://www.enterprisedb.com">http://www.enterprisedb.com</a></font> </tt></div></div> 

В списке pgadmin-support по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: Re: BUG: pgScript NOT thread safe!!
Следующее
От: Ashesh Vashi
Дата:
Сообщение: Re: BUG: pgScript NOT thread safe!!