Re: Add BF member koel-like indentation checks to SanityCheck CI
От
Tom Lane
Тема
Re: Add BF member koel-like indentation checks to SanityCheck CI
Дата
Msg-id
2363219.1704871454@sss.pgh.pa.us
Ответ на
Re: Add BF member koel-like indentation checks to SanityCheck CI (Michael Paquier)
Список
Дерево обсуждения
Add BF member koel-like indentation checks to SanityCheck CI Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Add code indentation check to cirrus-ci (was Re: Add BF member koel-like indentation checks to SanityCheck CI) Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Add code indentation check to cirrus-ci (was Re: Add BF member koel-like indentation checks to SanityCheck CI) Nazir Bilal Yavuz <byavuz81@gmail.com>
Re: Add code indentation check to cirrus-ci (was Re: Add BF member koel-like indentation checks to SanityCheck CI) Peter Smith <smithpb2250@gmail.com>
Re: Add code indentation check to cirrus-ci (was Re: Add BF member koel-like indentation checks to SanityCheck CI) Andrew Dunstan <andrew@dunslane.net>
Re: Add code indentation check to cirrus-ci (was Re: Add BF member koel-like indentation checks to SanityCheck CI) Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Add BF member koel-like indentation checks to SanityCheck CI John Naylor <johncnaylorls@gmail.com>
Re: Add BF member koel-like indentation checks to SanityCheck CI Jelte Fennema-Nio <postgres@jeltef.nl>
Re: Add BF member koel-like indentation checks to SanityCheck CI "Tristan Partin" <tristan@neon.tech>
Re: Add BF member koel-like indentation checks to SanityCheck CI Robert Haas <robertmhaas@gmail.com>
Re: Add BF member koel-like indentation checks to SanityCheck CI Tom Lane <tgl@sss.pgh.pa.us>
Re: Add BF member koel-like indentation checks to SanityCheck CI Daniel Gustafsson <daniel@yesql.se>
Re: Add BF member koel-like indentation checks to SanityCheck CI Robert Haas <robertmhaas@gmail.com>
Re: Add BF member koel-like indentation checks to SanityCheck CI Tom Lane <tgl@sss.pgh.pa.us>
Re: Add BF member koel-like indentation checks to SanityCheck CI Jim Nasby <jim.nasby@gmail.com>
Re: Add BF member koel-like indentation checks to SanityCheck CI "Tristan Partin" <tristan@neon.tech>
Re: Add BF member koel-like indentation checks to SanityCheck CI John Naylor <johncnaylorls@gmail.com>
Re: Add BF member koel-like indentation checks to SanityCheck CI Tom Lane <tgl@sss.pgh.pa.us>
Re: Add BF member koel-like indentation checks to SanityCheck CI Michael Paquier <michael@paquier.xyz>
Re: Add BF member koel-like indentation checks to SanityCheck CI Tom Lane <tgl@sss.pgh.pa.us>
Re: Add BF member koel-like indentation checks to SanityCheck CI Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Re: Add BF member koel-like indentation checks to SanityCheck CI Tom Lane <tgl@sss.pgh.pa.us>
Re: Add BF member koel-like indentation checks to SanityCheck CI "Tristan Partin" <tristan@neon.tech>
Michael Paquier writes: > On Wed, Jan 10, 2024 at 01:25:36AM -0500, Tom Lane wrote: >> So that leads to the conclusion that I wouldn't want an automatic >> pgindent check to happen during "make all" or "make check", because >> I want those things to succeed before I consider pgindent'ing. >> Maybe it's okay to include it as part of check-world, but I'm >> not quite sure about that either. > Another possibility would be to hide the test behind a PG_TEST_EXTRA. Yeah. I'm not quite sure what's a good way to make this work, but it seems like having "make check-world" always invoke it would not be desirable. Making that conditional on an environment variable setting could be a better idea, perhaps? regards, tom lane
В списке pgsql-hackers по дате отправления
От: Michael Paquier
Дата: