On 2022-Sep-27, houzj.fnst@fujitsu.com wrote:
> Thanks for reviewing!
>
> Just in case I misunderstand, it seems you mean the message style[1] is OK, right ?
>
> [1]
> errdetail("Column list cannot be specified for a partitioned table when %s is false.",
> "publish_via_partition_root")));
Yeah, since you're changing another word in that line, it's ok to move
the parameter line off-string. (If you were only changing the parameter
to %s and there was no message duplication, I would reject the patch as
useless.)
I'm going over that patch now, I have a few other changes as attached,
intend to commit soon.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Ni aún el genio muy grande llegaría muy lejos
si tuviera que sacarlo todo de su propio interior" (Goethe)