Re: Superfluous libpq-be.h include in GSSAPI code

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Superfluous libpq-be.h include in GSSAPI code
Дата
Msg-id 20190629022306.GA2191@paquier.xyz
обсуждение исходный текст
Ответ на Re: Superfluous libpq-be.h include in GSSAPI code  (Julien Rouhaud <rjuju123@gmail.com>)
Ответы Re: Superfluous libpq-be.h include in GSSAPI code  (Daniel Gustafsson <daniel@yesql.se>)
Список pgsql-hackers
On Fri, Jun 28, 2019 at 08:47:33PM +0200, Julien Rouhaud wrote:
> On Fri, Jun 28, 2019 at 4:37 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>> backend/libpq/be-secure-gssapi.c is including both libpq-be.h and libpq.h,
>> which makes libpq-be.h superfluous as it gets included via libpq.h.  The
>> attached patch removes the inclusion of libpq-be.h to make be-secure-gssapi.c
>> behave like other files which need both headers.
>
> LGTM.

Thanks, committed.  I looked at the area in case but did not notice
anything else strange.

(We have in hba.h a kludge with hbaPort to avoid including libpq-be.h,
I got to wonder if we could do something about that..)
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: [bug fix] Produce a crash dump before main() on Windows
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: cleanup & refactoring on reindexdb.c