Обсуждение: Superfluous libpq-be.h include in GSSAPI code

backend/libpq/be-secure-gssapi.c is including both libpq-be.h and libpq.h,
which makes libpq-be.h superfluous as it gets included via libpq.h.  The
attached patch removes the inclusion of libpq-be.h to make be-secure-gssapi.c
behave like other files which need both headers.

cheers ./daniel

On Fri, Jun 28, 2019 at 4:37 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> backend/libpq/be-secure-gssapi.c is including both libpq-be.h and libpq.h,
> which makes libpq-be.h superfluous as it gets included via libpq.h.  The
> attached patch removes the inclusion of libpq-be.h to make be-secure-gssapi.c
> behave like other files which need both headers.

LGTM.

On Fri, Jun 28, 2019 at 08:47:33PM +0200, Julien Rouhaud wrote:
> On Fri, Jun 28, 2019 at 4:37 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>> backend/libpq/be-secure-gssapi.c is including both libpq-be.h and libpq.h,
>> which makes libpq-be.h superfluous as it gets included via libpq.h.  The
>> attached patch removes the inclusion of libpq-be.h to make be-secure-gssapi.c
>> behave like other files which need both headers.
>
> LGTM.

Thanks, committed.  I looked at the area in case but did not notice
anything else strange.

(We have in hba.h a kludge with hbaPort to avoid including libpq-be.h,
I got to wonder if we could do something about that..)
--
Michael

> On 29 Jun 2019, at 04:23, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Jun 28, 2019 at 08:47:33PM +0200, Julien Rouhaud wrote:
>> On Fri, Jun 28, 2019 at 4:37 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>>> backend/libpq/be-secure-gssapi.c is including both libpq-be.h and libpq.h,
>>> which makes libpq-be.h superfluous as it gets included via libpq.h.  The
>>> attached patch removes the inclusion of libpq-be.h to make be-secure-gssapi.c
>>> behave like other files which need both headers.
>>
>> LGTM.
>
> Thanks, committed.  I looked at the area in case but did not notice
> anything else strange.

Thanks!

> (We have in hba.h a kludge with hbaPort to avoid including libpq-be.h,
> I got to wonder if we could do something about that..)

I looked at that one too at the time, but didn’t come up with anything less
kludgy.

cheers ./daniel