[HACKERS] Re: [COMMITTERS] pgsql: Preventive maintenance in advance ofpgindent run.

Поиск
Список
Период
Сортировка
Искать
От
Alvaro Herrera
Тема
[HACKERS] Re: [COMMITTERS] pgsql: Preventive maintenance in advance ofpgindent run.
Дата
в 17:08:47
Msg-id
20170517140847.lasiafwmsxgzppm6@alvherre.pgsql
Ответ на
Список
Дерево обсуждения
Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.) Piotr Stefaniak <postgres@piotr-stefaniak.me>
Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.) Piotr Stefaniak <postgres@piotr-stefaniak.me>
Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.) Piotr Stefaniak <postgres@piotr-stefaniak.me>
Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.) Piotr Stefaniak <postgres@piotr-stefaniak.me>
Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.) Piotr Stefaniak <postgres@piotr-stefaniak.me>
Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.) Piotr Stefaniak <postgres@piotr-stefaniak.me>
Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.) Piotr Stefaniak <postgres@piotr-stefaniak.me>
Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.) Piotr Stefaniak <postgres@piotr-stefaniak.me>
Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.) Piotr Stefaniak <postgres@piotr-stefaniak.me>
Tom Lane wrote:

> src/bin/pg_basebackup/pg_basebackup.c          | 24 +++++++++---------
> src/bin/pg_waldump/pg_waldump.c                | 18 ++++++-------

There are some changes here that should be reverted; for instance:

-   printf(_("  -c, --checkpoint=fast|spread\n"
-            "                         set fast or spread checkpointing\n"));
+   printf(_("  -c, --checkpoint=fast|spread\n"));
+   printf(_("                         set fast or spread checkpointing\n"));

From the translator's point of view the patched version doesn't make
sense because they are two separate strings.  In the original, it's a
single translatable string.  Particularly in pg_waldump's -p, where a
phrase is now cut in the middle.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


В списке pgsql-hackers по дате отправления
От: Ashutosh Bapat
Дата:
От: Tom Lane
Дата:
FAQ