outdated comment in heapam.c

Поиск
Список
Период
Сортировка
От Andres Freund
Тема outdated comment in heapam.c
Дата
Msg-id 201205031508.19390.andres@anarazel.de
обсуждение исходный текст
Ответы Re: outdated comment in heapam.c  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Список pgsql-hackers
Hi,

It seems that when Heikki added the multi_insert code the following comment in 
htup.h wasn't updated:
/** We ran out of opcodes, so heapam.c now has a second RmgrId.    These opcodes* are associated with RM_HEAP2_ID, but
arenot logically different from* the ones above associated with RM_HEAP_ID.  We apply XLOG_HEAP_OPMASK,* although
currentlyXLOG_HEAP_INIT_PAGE is not used for any of these.*/
 
#define XLOG_HEAP2_FREEZE        0x00
#define XLOG_HEAP2_CLEAN        0x10
/* 0x20 is free, was XLOG_HEAP2_CLEAN_MOVE */
#define XLOG_HEAP2_CLEANUP_INFO 0x30
#define XLOG_HEAP2_VISIBLE        0x40
#define XLOG_HEAP2_MULTI_INSERT    0x50

I suggest simply to remove the "although currently XLOG_HEAP_INIT_PAGE is not 
used for any of these" part.


Andres


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: Re: ALTER DATABASE and datallowconn
Следующее
От: Merlin Moncure
Дата:
Сообщение: Re: Temporary tables under hot standby