Re: [COMMITTERS] pgsql: Restructure the pg_upgrade code to use several global structures

Itagaki Takahiro wrote:
> On Wed, Oct 20, 2010 at 6:38 AM, Bruce Momjian <bruce@momjian.us> wrote:
> > Restructure the pg_upgrade code to use several global structures rather
> > than packing everything into 'ctx' and passing that to every function.
> > -------
> > http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e13f7e9a711c9117e438516537066bbe61df6455
> 
> I see the following warning message:
> ----
> In file included from check.c:10:
> pg_upgrade.h:243: warning: built-in function ?log? declared as non-function
> ----
> gcc (GCC) 4.4.4 20100630 (Red Hat 4.4.4-10)
> 
> pg_upgrade.h has a variable 'log'.
> extern Log log;
> 
> It might be platform-dependent, but I think we'd better rename it.

Thanks, done.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +