Re: [COMMITTERS] pgsql: Restructure the pg_upgrade code to use several global structures

Поиск
Список
Период
Сортировка
От Itagaki Takahiro
Тема Re: [COMMITTERS] pgsql: Restructure the pg_upgrade code to use several global structures
Дата
Msg-id AANLkTi=VhagmGxL521WXsfG1sQ-KB+hnp2iB_fXG1+V=@mail.gmail.com
обсуждение исходный текст
Ответы Re: [COMMITTERS] pgsql: Restructure the pg_upgrade code to use several global structures  (Bruce Momjian <bruce@momjian.us>)
Список pgsql-hackers
On Wed, Oct 20, 2010 at 6:38 AM, Bruce Momjian <bruce@momjian.us> wrote:
> Restructure the pg_upgrade code to use several global structures rather
> than packing everything into 'ctx' and passing that to every function.
> -------
> http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e13f7e9a711c9117e438516537066bbe61df6455

I see the following warning message:
----
In file included from check.c:10:
pg_upgrade.h:243: warning: built-in function ‘log’ declared as non-function
----
gcc (GCC) 4.4.4 20100630 (Red Hat 4.4.4-10)

pg_upgrade.h has a variable 'log'.
extern Log log;

It might be platform-dependent, but I think we'd better rename it.

--
Itagaki Takahiro


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: patch: Add JSON datatype to PostgreSQL (GSoC, WIP)
Следующее
От: Robert Haas
Дата:
Сообщение: Re: Domains versus arrays versus typmods