Re: DTrace probe patch for OS X Leopard

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: DTrace probe patch for OS X Leopard
Дата
Msg-id 20080229141048.GD4673@alvh.no-ip.org
обсуждение исходный текст
Ответ на Re: DTrace probe patch for OS X Leopard  (Robert Lor <Robert.Lor@Sun.COM>)
Ответы Re: DTrace probe patch for OS X Leopard  (Robert Lor <Robert.Lor@Sun.COM>)
Список pgsql-patches
Robert Lor wrote:

> My concern is that when we start adding more probes (not just the
> backend), we will have to add the following 5 lines in .c files that use
> the Dtrace macros. This seems intrusive and messy to me instead of in a
> centralized place like c.h. What are the disadvantages for keeping the
> way it is now?
>
> #ifdef ENABLE_DTRACE
> #include "utils/probes.h"
> #else
> #include "utils/probes_null.h"
> #endif

Why can't this block be centralized in probes.h?

--
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

В списке pgsql-patches по дате отправления:

Предыдущее
От: Robert Lor
Дата:
Сообщение: Re: DTrace probe patch for OS X Leopard
Следующее
От: Robert Lor
Дата:
Сообщение: Re: DTrace probe patch for OS X Leopard