Re: Small bug in postgres' ./configure script and invalid

Thanks.  Patch attached.  This will be in 7.4.

---------------------------------------------------------------------------

Arjen van der Meijden wrote:
> Hi List,
>
> I'm using flex 2.5.31
>
> acm@server pgsql $ flex --version
> flex 2.5.31
>
> And get this warning from the configure-script (in latest cvs):
>
> checking for flex... no
> configure: WARNING:
> *** The Flex version 2.5.3 you have at /usr/bin/lex contains a bug. You
> *** should get version 2.5.4 or later.
> configure: WARNING:
> *** Without Flex you will not be able to build PostgreSQL from CVS or
> *** change any of the scanner definition files.  You can obtain Flex
> from
> *** a GNU mirror site.  (If you are using the official distribution of
> *** PostgreSQL then you do not need to worry about this because the Flex
> *** output is pre-generated.)
>
> Of course the regexp on line 3580 of the configure-script is wrong:
> if $pgac_candidate --version | grep '2\.5\.3' >/dev/null 2>&1; then
>
> I don't know a real solution, probably something like changing the grep
> to read:
> grep -e `2\.5\.3$'
> Or adding a second grep to grep out 2\.5\.3[0-9]
>
> Ow and the reason why I didn't try reporting this via the "Report a bug"
> link on the postgresql-website is because that gave me a 404-error.
> "Not Found
> The requested URL /bugs/bugs.php was not found on this server.
>
> Apache/1.3.27 Server at www.ca.postgresql.org Port 80"
>
> Regards,
>
> Arjen
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: configure
===================================================================
RCS file: /cvsroot/pgsql-server/configure,v
retrieving revision 1.252
diff -c -c -r1.252 configure
*** configure    24 Apr 2003 21:16:42 -0000    1.252
--- configure    6 May 2003 23:25:51 -0000
***************
*** 3577,3583 ****
        then
          echo '%%'  > conftest.l
          if $pgac_candidate -t conftest.l 2>/dev/null | grep FLEX_SCANNER >/dev/null 2>&1; then
!           if $pgac_candidate --version | grep '2\.5\.3' >/dev/null 2>&1; then
              pgac_broken_flex=$pgac_candidate
              continue
            fi
--- 3577,3583 ----
        then
          echo '%%'  > conftest.l
          if $pgac_candidate -t conftest.l 2>/dev/null | grep FLEX_SCANNER >/dev/null 2>&1; then
!           if $pgac_candidate --version | grep '2\.5\.3$' >/dev/null 2>&1; then
              pgac_broken_flex=$pgac_candidate
              continue
            fi
Index: config/programs.m4
===================================================================
RCS file: /cvsroot/pgsql-server/config/programs.m4,v
retrieving revision 1.11
diff -c -c -r1.11 programs.m4
*** config/programs.m4    6 Apr 2003 22:45:22 -0000    1.11
--- config/programs.m4    6 May 2003 23:25:51 -0000
***************
*** 26,32 ****
        then
          echo '%%'  > conftest.l
          if $pgac_candidate -t conftest.l 2>/dev/null | grep FLEX_SCANNER >/dev/null 2>&1; then
!           if $pgac_candidate --version | grep '2\.5\.3' >/dev/null 2>&1; then
              pgac_broken_flex=$pgac_candidate
              continue
            fi
--- 26,32 ----
        then
          echo '%%'  > conftest.l
          if $pgac_candidate -t conftest.l 2>/dev/null | grep FLEX_SCANNER >/dev/null 2>&1; then
!           if $pgac_candidate --version | grep ' 2\.5\.3$' >/dev/null 2>&1; then
              pgac_broken_flex=$pgac_candidate
              continue
            fi