Re: spoonbill is failing citext test

Stefan Kaltenbrunner <stefan@kaltenbrunner.cc> writes:
> Tom Lane wrote:
>> Perhaps Stefan can run the test manually and get us a readable diff.

> well what we are looking at here are actually two issues - one is the 
> regression failure - diff -a produces:
> http://www.kaltenbrunner.cc/files/citext.diff.txt

Huh.  This is blowback from the change I made recently to make "cannot
cast to insert target type" errors point at the source expression
instead of the target column name.  Easily fixed, but I wonder why
spoonbill was complaining?  Apparently it thought the output file was
not textual (thus defeating the --ignore-spaces option), but why?

> the other problem is that each of those failures leaves spoonbill with a 
>   running postgresql instance that causes a follow up failure with the 
> next buildfarm run

I think this is a known buildfarm-script problem --- it forgets to shut
down the installed postmaster if there's a failure in this step.
        regards, tom lane