Re: write past chunk end in ExprContext / to_char

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: write past chunk end in ExprContext / to_char
Дата
Msg-id 17853.1183057778@sss.pgh.pa.us
обсуждение исходный текст
Ответ на write past chunk end in ExprContext / to_char  (Patrick Welche <prlw1@newn.cam.ac.uk>)
Ответы Re: write past chunk end in ExprContext / to_char  (imad <immaad@gmail.com>)
Re: write past chunk end in ExprContext / to_char  (Bruce Momjian <bruce@momjian.us>)
Список pgsql-hackers
Patrick Welche <prlw1@newn.cam.ac.uk> writes:
> With today's CVS code (originally noticed with 8.2beta3), on a PC where
> INT_MAX=0x7FFFFFFF=2147483647

> postgres=# select to_char(2147483648,'999,999,999');
> WARNING:  detected write past chunk end in ExprContext 0x845509c
> WARNING:  detected write past chunk end in ExprContext 0x845509c

Yech ... it's scribbling on the output of int8out, which is bad enough,
but it's assuming that buffer will be long enough when it demonstrably
isn't.

Some days I think we ought to throw out formatting.c and rewrite it from
scratch; it's probably the most poorly-coded module in all of Postgres.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: write past chunk end in ExprContext / to_char
Следующее
От: Tom Lane
Дата:
Сообщение: Re: SetBufferCommitInfoNeedsSave and race conditions