Re: [COMMITTERS] pgsql: pgindent run for 9.4

Поиск
Список
Период
Сортировка
От Kevin Grittner
Тема Re: [COMMITTERS] pgsql: pgindent run for 9.4
Дата
Msg-id 1399405566.41569.YahooMailNeo@web122305.mail.ne1.yahoo.com
обсуждение исходный текст
Ответ на Re: [COMMITTERS] pgsql: pgindent run for 9.4  (Bruce Momjian <bruce@momjian.us>)
Ответы Re: [COMMITTERS] pgsql: pgindent run for 9.4
Re: [COMMITTERS] pgsql: pgindent run for 9.4
Список pgsql-hackers
Bruce Momjian <bruce@momjian.us> wrote:
> On Tue, May  6, 2014 at 12:38:41PM -0700, Kevin Grittner wrote:
>> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Kevin Grittner <kgrittn@ymail.com> writes:
>>>
>>>> Bruce Momjian <bruce@momjian.us> wrote:
>>>>> pgindent run for 9.4
>>>
>>>> The 13 tests above are broken by this commit.  Probably the
>>>> directory should be excluded from pgindent processing.
>>>
>>> What's broken?  The buildfarm isn't complaining, and "make installcheck"
>>> in src/interfaces/ecpg/test passes for me.
>>
>> On "make check-world" I get the attached.  After the period, the
>> trailing tabs in the comment have been changed to spaces in
>> "expected", but are still tabs in "results".
>
> Yes, I had to modify those lines before I pushed the pgindent changes so
> 'make installcheck-world' would pass.  It passes here for me now.  Did
> you do 'make maintainer-clean' before running the tests?  That might
> help.

It occurred to me after my last post that I had just done a "make
world" without any cleanup when I pulled that, and had started a
full build from "make maintainer-clean" when you sent that.  :-)

I'll let you know either way when I get results from that.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: pg_shmem_allocations view
Следующее
От: Andres Freund
Дата:
Сообщение: Re: Wanted: jsonb on-disk representation documentation