Re: pg_upgrade: make the locale comparison more tolerating

Поиск
Список
Период
Сортировка
От Pavel Raiskup
Тема Re: pg_upgrade: make the locale comparison more tolerating
Дата
Msg-id 10152755.SVtzXS2QiT@nb.usersys.redhat.com
обсуждение исходный текст
Ответ на pg_upgrade: make the locale comparison more tolerant  (Pavel Raiskup <praiskup@redhat.com>)
Ответы Re: pg_upgrade: make the locale comparison more tolerating  (Rushabh Lathia <rushabh.lathia@gmail.com>)
Re: pg_upgrade: make the locale comparison more tolerating  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Rushabh, really sorry I have to re-create the patch and thanks a
lot for looking at it!

Looking at the patch once again, I see that there were at least two
problems.  Firstly, I used the equivalent_locale function also on the
encoding values.  Even if that should not cause bugs (as it should result
in strncasecmp anyway), it was not pretty..

The second problem was assuming that the locale specifier "A" is not
longer then locale specifier B.  Comparisons like 'en_US.utf8' with
'en_US_.utf8' would result in success.  Bug resulting from this mistake is
not real probably but it is not nice anyway..

Rather cleaning the patch once more, attached,
Pavel

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Change authentication error message (patch)
Следующее
От: Harold Giménez
Дата:
Сообщение: Re: proposal: hide application_name from other users