Re: pg_upgrade: make the locale comparison more tolerating

Поиск
Список
Период
Сортировка
От Rushabh Lathia
Тема Re: pg_upgrade: make the locale comparison more tolerating
Дата
Msg-id CAGPqQf2ApFiyXT5EHr1t4a62Sh19Ft0Yz3e9HU5qowJMWJc1Cg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: pg_upgrade: make the locale comparison more tolerating  (Pavel Raiskup <praiskup@redhat.com>)
Список pgsql-hackers
Дерево обсуждения
Hi Pavel,

I looked at your latest cleanup patch. Yes its looks more cleaner in term
equivalent_locale & equivalent_encoding separate functions.

I did run the test again on latest patch and all looks good.

Marking it as ready for committer.

Regards,



On Fri, Jan 24, 2014 at 9:49 PM, Pavel Raiskup <praiskup@redhat.com> wrote:
Rushabh, really sorry I have to re-create the patch and thanks a
lot for looking at it!

Looking at the patch once again, I see that there were at least two
problems.  Firstly, I used the equivalent_locale function also on the
encoding values.  Even if that should not cause bugs (as it should result
in strncasecmp anyway), it was not pretty..

The second problem was assuming that the locale specifier "A" is not
longer then locale specifier B.  Comparisons like 'en_US.utf8' with
'en_US_.utf8' would result in success.  Bug resulting from this mistake is
not real probably but it is not nice anyway..

Rather cleaning the patch once more, attached,
Pavel



--
Rushabh Lathia

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: patch: option --if-exists for pg_dump
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Performance Improvement by reducing WAL for Update Operation