Обсуждение: small cleanup of ICU includes

Removes ICU includes from pg_locale.h, and instead include them in the
few C files that need them.

There used to be more files that needed to use ICU functions, but after
refactoring, there are only a few files that access ICU APIs directly.

Regards,
    Jeff Davis

Hi,

On 2026-01-06 15:11:13 -0800, Jeff Davis wrote:
> Removes ICU includes from pg_locale.h, and instead include them in the
> few C files that need them.
> 
> There used to be more files that needed to use ICU functions, but after
> refactoring, there are only a few files that access ICU APIs directly.

Yay! I think this is a pretty significant improvement, removing the need for
the ugly C++ compat hackery we had introduced, as well as (imo) just being
cleaner.

Greetings,

Andres Freund

On Tue, 2026-01-06 at 18:20 -0500, Andres Freund wrote:
> Yay! I think this is a pretty significant improvement, removing the
> need for
> the ugly C++ compat hackery we had introduced, as well as (imo) just
> being
> cleaner.

Thanks for looking! I will push after my CI run finishes.

Regards,
    Jeff Davis