Обсуждение: cleanup: Split long Makefile lists across lines and sort them

Поиск
Список
Период
Сортировка

cleanup: Split long Makefile lists across lines and sort them

От
"Jelte Fennema-Nio"
Дата:
This makes sure that the lines don't get excessively long, while keeping
diffs that add/remove elements small.

For context: this was extracted from the pytest patchset and extended to more places based on Andres his
recommendation.

Вложения

Re:cleanup: Split long Makefile lists across lines and sort them

От
"zengman"
Дата:
> This makes sure that the lines don't get excessively long, while keeping
> diffs that add/remove elements small.

Hi,

It looks like there’s a minor typo in the patch: in the line `is first becaues`, 
`becaues` is a misspelling of `because`.

--
Regards,
Man Zeng
www.openhalo.org

Re: cleanup: Split long Makefile lists across lines and sort them

От
"Jelte Fennema-Nio"
Дата:
On Wed Dec 24, 2025 at 3:18 PM CET, =?gb18030?B?emVuZ21hbg==?= wrote:
> It looks like there’s a minor typo in the patch: in the line `is first becaues`,
> `becaues` is a misspelling of `because`.

Oops. Fixed in attached.


Вложения

Re: cleanup: Split long Makefile lists across lines and sort them

От
"Jelte Fennema-Nio"
Дата:
On Wed Dec 24, 2025 at 3:31 PM CET, Jelte Fennema-Nio wrote:
> Oops. Fixed in attached.

I had accidentally included a trailing backspace in one of the lists. To
my surprise that worked fine. Since these trailing separators result in
smaller git diffs when a new item is added at the end of the list, I
decided to put such trailing backslashes in all the lists in this patch.

Вложения

Re: cleanup: Split long Makefile lists across lines and sort them

От
"zengman"
Дата:
No further comments from me, LGTM!

--
Regards,
Man Zeng
www.openhalo.org

Re: cleanup: Split long Makefile lists across lines and sort them

От
Chao Li
Дата:

> On Dec 25, 2025, at 17:07, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>
> On Wed Dec 24, 2025 at 3:31 PM CET, Jelte Fennema-Nio wrote:
>> Oops. Fixed in attached.
>
> I had accidentally included a trailing backspace in one of the lists. To
> my surprise that worked fine. Since these trailing separators result in
> smaller git diffs when a new item is added at the end of the list, I
> decided to put such trailing backslashes in all the lists in this patch.
> <v3-0001-cleanup-Split-long-Makefile-lists-across-lines-an.patch>

```
+REGRESS = \
+    page \
+    brin \
+    btree \
+    checksum \
+    gin \
+    gist \
+    hash \
+    oldextversions \
```

If we look at existing Makefiles, they don’t add a tailing “\” in the last line of lists, so let’s keep consistent.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







Re: cleanup: Split long Makefile lists across lines and sort them

От
Japin Li
Дата:
On Thu, 25 Dec 2025 at 10:07, "Jelte Fennema-Nio" <postgres@jeltef.nl> wrote:
> On Wed Dec 24, 2025 at 3:31 PM CET, Jelte Fennema-Nio wrote:
>> Oops. Fixed in attached.
>
> I had accidentally included a trailing backspace in one of the lists. To
> my surprise that worked fine. Since these trailing separators result in
> smaller git diffs when a new item is added at the end of the list, I
> decided to put such trailing backslashes in all the lists in this patch.
> [3. text/x-patch; v3-0001-cleanup-Split-long-Makefile-lists-across-lines-an.patch]...

Small suggestion: the backslash on the last line isn't needed and can be removed.

This also aligns with the style used elsewhere.

-- 
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.