Обсуждение: DOCS - Clarify the publication 'publish_via_partition_root' default value.

Поиск
Список
Период
Сортировка

DOCS - Clarify the publication 'publish_via_partition_root' default value.

От
Peter Smith
Дата:
Hi,

When reading the docs for the publication parameter
'publish_via_partition_root' [1], I felt there was too much mental
gymnastics required to understand the meaning of "the latter is the
default."

Why not just say clearly what the default value is?

PSA: a patch to do that.

======
[1]
https://www.postgresql.org/docs/current/sql-createpublication.html#SQL-CREATEPUBLICATION-PARAMS-WITH-PUBLISH-VIA-PARTITION-ROOT

Kind Regards,
Peter Smith.
Fujitsu Australia



Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.

От
Peter Smith
Дата:
On Thu, Dec 11, 2025 at 6:51 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi,
>
> When reading the docs for the publication parameter
> 'publish_via_partition_root' [1], I felt there was too much mental
> gymnastics required to understand the meaning of "the latter is the
> default."
>
> Why not just say clearly what the default value is?
>
> PSA: a patch to do that.

Here is the patch accidentally omitted from the last post.

>
> ======
> [1]
https://www.postgresql.org/docs/current/sql-createpublication.html#SQL-CREATEPUBLICATION-PARAMS-WITH-PUBLISH-VIA-PARTITION-ROOT
>
> Kind Regards,
> Peter Smith.
> Fujitsu Australia

Вложения

Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.

От
Jacob Champion
Дата:
On Thu, Dec 11, 2025 at 12:22 PM Peter Smith <smithpb2250@gmail.com> wrote:
> > Why not just say clearly what the default value is?
> >
> > PSA: a patch to do that.

LGTM. (In fact I've read that paragraph three times and still cannot
get it to stick in my head, despite having done a fair amount of
thinking about publish_via_partition_root, so if you have further
improvement ideas I'm all ears.)

--Jacob



Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.

От
Chao Li
Дата:

> On Dec 12, 2025, at 07:12, Jacob Champion <jacob.champion@enterprisedb.com> wrote:
>
> On Thu, Dec 11, 2025 at 12:22 PM Peter Smith <smithpb2250@gmail.com> wrote:
>>> Why not just say clearly what the default value is?
>>>
>>> PSA: a patch to do that.
>
> LGTM. (In fact I've read that paragraph three times and still cannot
> get it to stick in my head, despite having done a fair amount of
> thinking about publish_via_partition_root, so if you have further
> improvement ideas I'm all ears.)
>
> --Jacob
>
>

My feeling is that the preceding long sentence has described both sides expect explicitly mentioning true and false,
whichmakes the following sentence, no matter the original version and the patched version sounds slightly redundant. So
Ithink maybe we can rework the entire paragraph like: 

```
This parameter controls how changes to a partitioned table (or any of its partitions) are published. When set to true,
changesare published using the identity and schema of the partitioned table. When set to false (the default), changes
arepublished using the identity and schema of the individual partitions 
where the changes actually occurred. Enabling this option allows the changes to be replicated into a non-partitioned
tableor into a partitioned table whose 
partition structure differs from that of the publisher.
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/