Обсуждение: Improve coments on structures in trigger.c

Поиск
Список
Период
Сортировка

Improve coments on structures in trigger.c

От
Yugo Nagata
Дата:
Hi,

I found that comments in trigger.c describing fields of three different
structures in a comment block. I feel this is confusing because some
structure names are not explicitly mentioned there even though common field
names are used between structures. I've attached a patch to improve the comments
by splitting it to three blocks.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>
Вложения

Re: Improve coments on structures in trigger.c

От
Philip Alger
Дата:
Hi Yugo,
 
I found that comments in trigger.c describing fields of three different
structures in a comment block.

That makes sense to me.
 
I've attached a patch to improve the comments
by splitting it to three blocks.

I think you could also move the comment beginning on:
   
    * AfterTriggersData has the following fields:

To between:

  typedef struct AfterTriggersTableData AfterTriggersTableData;
> HERE
    typedef struct AfterTriggersData

To keep it consistent with the other comments you moved around.