Re: Improve coments on structures in trigger.c

Поиск
Список
Период
Сортировка
От Philip Alger
Тема Re: Improve coments on structures in trigger.c
Дата
Msg-id CAPXBC8LWYqQ5bjt3pmjU93f_RWky=8B84X8ADKDbZeHBjfiZWw@mail.gmail.com
обсуждение исходный текст
Ответ на Improve coments on structures in trigger.c  (Yugo Nagata <nagata@sraoss.co.jp>)
Список pgsql-hackers
Hi Yugo,
 
I found that comments in trigger.c describing fields of three different
structures in a comment block.

That makes sense to me.
 
I've attached a patch to improve the comments
by splitting it to three blocks.

I think you could also move the comment beginning on:
   
    * AfterTriggersData has the following fields:

To between:

  typedef struct AfterTriggersTableData AfterTriggersTableData;
> HERE
    typedef struct AfterTriggersData

To keep it consistent with the other comments you moved around.

В списке pgsql-hackers по дате отправления: