Обсуждение: BUG #18018: Homebrew link is broken
The following bug has been logged on the website: Bug reference: 18018 Logged by: John Lin Email address: johnlinp@gmail.com PostgreSQL version: Unsupported/Unknown Operating system: macOS Description: When I went to https://www.postgresql.org/download/macosx/, there is a link in the sentence: > A list of PostgreSQL packages can be found using the Braumeister search tool. And the link is https://formulae.brew.sh/formula/postgresql. However, the link is broken. Please consider changing the link. Thanks.
On Tue, Jul 11, 2023 at 3:29 AM PG Bug reporting form <noreply@postgresql.org> wrote: > > The following bug has been logged on the website: > > Bug reference: 18018 > Logged by: John Lin > Email address: johnlinp@gmail.com > PostgreSQL version: Unsupported/Unknown > Operating system: macOS > Description: > > When I went to https://www.postgresql.org/download/macosx/, there is a link > in the sentence: > > > A list of PostgreSQL packages can be found using the Braumeister search > tool. > > And the link is https://formulae.brew.sh/formula/postgresql. > > However, the link is broken. Please consider changing the link. Thanks. Homebrew does not (no longer?) provides a formula named postgresql; instead, it provides a formula for each of the Postgres major versions. See the output of brew commands below [1]. The difficulty is that, which is also pointed out in the first command's output, is that each major version of postgres introduces backwards incompatible changes, and hence a simple brew update or upgrade will break the user's database setup. Unfortunately the Homebrew online formula search tool does provide a URL for prefix-searches, else this page could've linked to the search results, and directed the reader to pick one. Something like https://formulae.brew.sh/formula/postgresql@ Perhaps this webpage can provide the brew command to list available formulae, and advise to install one from the result. [1]: $ brew search --formulae postgresql ==> Formulae postgresql@10 postgresql@12 postgresql@14 postgresql@9.4 qt-postgresql postgresql@11 postgresql@13 postgresql@15 postgresql@9.5 postgrest If you meant "postgresql" specifically: postgresql breaks existing databases on upgrade without human intervention. See a more specific version to install with: brew formulae | grep postgresql@ $ brew formulae | grep postgresql@ postgresql@10 postgresql@11 postgresql@12 postgresql@13 postgresql@14 postgresql@15 postgresql@9.4 postgresql@9.5 +CC pgsql-www@postgresql.org, for their visibility. Best regards, Gurjeet http://Gurje.et
On Tue, Jul 11, 2023 at 11:14:31AM -0700, Gurjeet Singh wrote: > On Tue, Jul 11, 2023 at 3:29 AM PG Bug reporting form > <noreply@postgresql.org> wrote: >> And the link is https://formulae.brew.sh/formula/postgresql. >> >> However, the link is broken. Please consider changing the link. Thanks. This link is part of the website, not the in-core docs. It would be simpler to mention the search command rather than each formula individually, as that could easily rot across the years. > Homebrew does not (no longer?) provides a formula named postgresql; > instead, it provides a formula for each of the Postgres major > versions. See the output of brew commands below [1]. > > The difficulty is that, which is also pointed out in the first > command's output, is that each major version of postgres introduces > backwards incompatible changes, and hence a simple brew update or > upgrade will break the user's database setup. This is not surprising, that's the only way for distributions to do upgrades in a predictible way. > $ brew formulae | grep postgresql@ > postgresql@10 > postgresql@11 > postgresql@12 > postgresql@13 > postgresql@14 > postgresql@15 > postgresql@9.4 > postgresql@9.5 It's a bit surprising that they don't have a formula for 9.6, but well, that's been EOL by the community for some time now. I can see that as well in my own setup. -- Michael
Вложения
> On 11 Jul 2023, at 20:14, Gurjeet Singh <gurjeet@singh.im> wrote: > On Tue, Jul 11, 2023 at 3:29 AM PG Bug reporting form > <noreply@postgresql.org> wrote: >>> A list of PostgreSQL packages can be found using the Braumeister search >> tool. >> >> And the link is https://formulae.brew.sh/formula/postgresql. >> >> However, the link is broken. Please consider changing the link. Thanks. > > Homebrew does not (no longer?) provides a formula named postgresql; > instead, it provides a formula for each of the Postgres major > versions. > Perhaps this webpage can provide the brew command to list available > formulae, and advise to install one from the result. I'm not sure it's worth complicating this too much, including brew commands means we need to keep up with brew development to make they are still relevant. Since the package page for the postgresql15 package lists all the other postgresqlXX packages available, why not just link to that (changing it to @16 when that's available on brew)? The page also doesn't say Braumeister anywhere, so we should perhaps change that while at it? The attached small diff updates the link with the above. Thoughts? -- Daniel Gustafsson
Вложения
> On 11 Jul 2023, at 20:14, Gurjeet Singh <gurjeet@singh.im> wrote: > On Tue, Jul 11, 2023 at 3:29 AM PG Bug reporting form > <noreply@postgresql.org> wrote: >>> A list of PostgreSQL packages can be found using the Braumeister search >> tool. >> >> And the link is https://formulae.brew.sh/formula/postgresql. >> >> However, the link is broken. Please consider changing the link. Thanks. > > Homebrew does not (no longer?) provides a formula named postgresql; > instead, it provides a formula for each of the Postgres major > versions. > Perhaps this webpage can provide the brew command to list available > formulae, and advise to install one from the result. I'm not sure it's worth complicating this too much, including brew commands means we need to keep up with brew development to make they are still relevant. Since the package page for the postgresql15 package lists all the other postgresqlXX packages available, why not just link to that (changing it to @16 when that's available on brew)? The page also doesn't say Braumeister anywhere, so we should perhaps change that while at it? The attached small diff updates the link with the above. Thoughts? -- Daniel Gustafsson
On 7/12/23 8:49 AM, Daniel Gustafsson wrote: >> On 11 Jul 2023, at 20:14, Gurjeet Singh <gurjeet@singh.im> wrote: >> On Tue, Jul 11, 2023 at 3:29 AM PG Bug reporting form >> <noreply@postgresql.org> wrote: > >>>> A list of PostgreSQL packages can be found using the Braumeister search >>> tool. >>> >>> And the link is https://formulae.brew.sh/formula/postgresql. >>> >>> However, the link is broken. Please consider changing the link. Thanks. >> >> Homebrew does not (no longer?) provides a formula named postgresql; >> instead, it provides a formula for each of the Postgres major >> versions. > >> Perhaps this webpage can provide the brew command to list available >> formulae, and advise to install one from the result. > > I'm not sure it's worth complicating this too much, including brew commands > means we need to keep up with brew development to make they are still relevant. We do include commands for other installed (dnf/yum; apt), and we do provide commands (albeit generic) for installing from some of the distros (see "Included in Distribution"). > Since the package page for the postgresql15 package lists all the other > postgresqlXX packages available, why not just link to that (changing it to @16 > when that's available on brew)? The page also doesn't say Braumeister > anywhere, so we should perhaps change that while at it? > > The attached small diff updates the link with the above. Thoughts? I don't agree in its entirety. We say we're linking to a "list" of PostgreSQL downloads, but it's linking to "latest" (which includes a list of older packages). Additionally, given the way it's structured, we'd have to update it for every major release anyway, so we may as well list out the command if we're going to keep showing Homebrew on the downloads page. Attached is a revision of your patch. Thanks, Jonathan [1] https://www.postgresql.org/download/linux/redhat/
Вложения
On 7/12/23 8:49 AM, Daniel Gustafsson wrote: >> On 11 Jul 2023, at 20:14, Gurjeet Singh <gurjeet@singh.im> wrote: >> On Tue, Jul 11, 2023 at 3:29 AM PG Bug reporting form >> <noreply@postgresql.org> wrote: > >>>> A list of PostgreSQL packages can be found using the Braumeister search >>> tool. >>> >>> And the link is https://formulae.brew.sh/formula/postgresql. >>> >>> However, the link is broken. Please consider changing the link. Thanks. >> >> Homebrew does not (no longer?) provides a formula named postgresql; >> instead, it provides a formula for each of the Postgres major >> versions. > >> Perhaps this webpage can provide the brew command to list available >> formulae, and advise to install one from the result. > > I'm not sure it's worth complicating this too much, including brew commands > means we need to keep up with brew development to make they are still relevant. We do include commands for other installed (dnf/yum; apt), and we do provide commands (albeit generic) for installing from some of the distros (see "Included in Distribution"). > Since the package page for the postgresql15 package lists all the other > postgresqlXX packages available, why not just link to that (changing it to @16 > when that's available on brew)? The page also doesn't say Braumeister > anywhere, so we should perhaps change that while at it? > > The attached small diff updates the link with the above. Thoughts? I don't agree in its entirety. We say we're linking to a "list" of PostgreSQL downloads, but it's linking to "latest" (which includes a list of older packages). Additionally, given the way it's structured, we'd have to update it for every major release anyway, so we may as well list out the command if we're going to keep showing Homebrew on the downloads page. Attached is a revision of your patch. Thanks, Jonathan [1] https://www.postgresql.org/download/linux/redhat/
> On 12 Jul 2023, at 15:45, Jonathan S. Katz <jkatz@postgresql.org> wrote:
> On 7/12/23 8:49 AM, Daniel Gustafsson wrote:
>>> On 11 Jul 2023, at 20:14, Gurjeet Singh <gurjeet@singh.im> wrote:
>>> Perhaps this webpage can provide the brew command to list available
>>> formulae, and advise to install one from the result.
>> I'm not sure it's worth complicating this too much, including brew commands
>> means we need to keep up with brew development to make they are still relevant.
>
> We do include commands for other installed (dnf/yum; apt), and we do provide commands (albeit generic) for installing
fromsome of the distros (see "Included in Distribution").
We do, but only for packages provided by repos hosted by postgresql.org so I
kind of consider them special cases.
> Additionally, given the way it's structured, we'd have to update it for every major release anyway,
Ideally, but considering we have this on the Debian installation page it's not
something we are super consistent with =)
apt-get install postgresql-12
The page does say "substitute the version number as required" but still.
> so we may as well list out the command if we're going to keep showing Homebrew on the downloads page.
Fair enough, and ftr I think we should keep Homebrew on the page.
+ You can use <a href="https://formulae.brew.sh">Homebrew Formulae</a> to
+ search for PostgreSQL and other packages. To find a specific major version of
+ PostgreSQL, search for <code>postgresql@NN</code>, where <code>NN</code>
+ represents the major version. For example,
+ <a href="https://formulae.brew.sh/formula/postgresql@15"><code>postgresql@15</code></a>.
I would probably opt for leaving out the details only keeping the first
sentence, that way we aren't exposed to homebrew changing things in package
naming.
--
Daniel Gustafsson
> On 12 Jul 2023, at 15:45, Jonathan S. Katz <jkatz@postgresql.org> wrote:
> On 7/12/23 8:49 AM, Daniel Gustafsson wrote:
>>> On 11 Jul 2023, at 20:14, Gurjeet Singh <gurjeet@singh.im> wrote:
>>> Perhaps this webpage can provide the brew command to list available
>>> formulae, and advise to install one from the result.
>> I'm not sure it's worth complicating this too much, including brew commands
>> means we need to keep up with brew development to make they are still relevant.
>
> We do include commands for other installed (dnf/yum; apt), and we do provide commands (albeit generic) for installing
fromsome of the distros (see "Included in Distribution").
We do, but only for packages provided by repos hosted by postgresql.org so I
kind of consider them special cases.
> Additionally, given the way it's structured, we'd have to update it for every major release anyway,
Ideally, but considering we have this on the Debian installation page it's not
something we are super consistent with =)
apt-get install postgresql-12
The page does say "substitute the version number as required" but still.
> so we may as well list out the command if we're going to keep showing Homebrew on the downloads page.
Fair enough, and ftr I think we should keep Homebrew on the page.
+ You can use <a href="https://formulae.brew.sh">Homebrew Formulae</a> to
+ search for PostgreSQL and other packages. To find a specific major version of
+ PostgreSQL, search for <code>postgresql@NN</code>, where <code>NN</code>
+ represents the major version. For example,
+ <a href="https://formulae.brew.sh/formula/postgresql@15"><code>postgresql@15</code></a>.
I would probably opt for leaving out the details only keeping the first
sentence, that way we aren't exposed to homebrew changing things in package
naming.
--
Daniel Gustafsson
On 7/12/23 9:59 AM, Daniel Gustafsson wrote: >> On 12 Jul 2023, at 15:45, Jonathan S. Katz <jkatz@postgresql.org> wrote: >> On 7/12/23 8:49 AM, Daniel Gustafsson wrote: >>>> On 11 Jul 2023, at 20:14, Gurjeet Singh <gurjeet@singh.im> wrote: > >>>> Perhaps this webpage can provide the brew command to list available >>>> formulae, and advise to install one from the result. >>> I'm not sure it's worth complicating this too much, including brew commands >>> means we need to keep up with brew development to make they are still relevant. >> >> We do include commands for other installed (dnf/yum; apt), and we do provide commands (albeit generic) for installingfrom some of the distros (see "Included in Distribution"). > > We do, but only for packages provided by repos hosted by postgresql.org so I > kind of consider them special cases. > >> Additionally, given the way it's structured, we'd have to update it for every major release anyway, > > Ideally, but considering we have this on the Debian installation page it's not > something we are super consistent with =) > > apt-get install postgresql-12 > > The page does say "substitute the version number as required" but still. > >> so we may as well list out the command if we're going to keep showing Homebrew on the downloads page. > > Fair enough, and ftr I think we should keep Homebrew on the page. > > + You can use <a href="https://formulae.brew.sh">Homebrew Formulae</a> to > + search for PostgreSQL and other packages. To find a specific major version of > + PostgreSQL, search for <code>postgresql@NN</code>, where <code>NN</code> > + represents the major version. For example, > + <a href="https://formulae.brew.sh/formula/postgresql@15"><code>postgresql@15</code></a>. > > I would probably opt for leaving out the details only keeping the first > sentence, that way we aren't exposed to homebrew changing things in package > naming. Given this slipped of the (read: my) radar, I opted for pushing what was in the v2 patch, given any of these things require updating anyway, and it's nice to limit the amount of clicks it takes someone to install PostgreSQL. If we don't like it, it's easy enough to change. Thanks for reporting! Jonathan
Вложения
On 7/12/23 9:59 AM, Daniel Gustafsson wrote: >> On 12 Jul 2023, at 15:45, Jonathan S. Katz <jkatz@postgresql.org> wrote: >> On 7/12/23 8:49 AM, Daniel Gustafsson wrote: >>>> On 11 Jul 2023, at 20:14, Gurjeet Singh <gurjeet@singh.im> wrote: > >>>> Perhaps this webpage can provide the brew command to list available >>>> formulae, and advise to install one from the result. >>> I'm not sure it's worth complicating this too much, including brew commands >>> means we need to keep up with brew development to make they are still relevant. >> >> We do include commands for other installed (dnf/yum; apt), and we do provide commands (albeit generic) for installingfrom some of the distros (see "Included in Distribution"). > > We do, but only for packages provided by repos hosted by postgresql.org so I > kind of consider them special cases. > >> Additionally, given the way it's structured, we'd have to update it for every major release anyway, > > Ideally, but considering we have this on the Debian installation page it's not > something we are super consistent with =) > > apt-get install postgresql-12 > > The page does say "substitute the version number as required" but still. > >> so we may as well list out the command if we're going to keep showing Homebrew on the downloads page. > > Fair enough, and ftr I think we should keep Homebrew on the page. > > + You can use <a href="https://formulae.brew.sh">Homebrew Formulae</a> to > + search for PostgreSQL and other packages. To find a specific major version of > + PostgreSQL, search for <code>postgresql@NN</code>, where <code>NN</code> > + represents the major version. For example, > + <a href="https://formulae.brew.sh/formula/postgresql@15"><code>postgresql@15</code></a>. > > I would probably opt for leaving out the details only keeping the first > sentence, that way we aren't exposed to homebrew changing things in package > naming. Given this slipped of the (read: my) radar, I opted for pushing what was in the v2 patch, given any of these things require updating anyway, and it's nice to limit the amount of clicks it takes someone to install PostgreSQL. If we don't like it, it's easy enough to change. Thanks for reporting! Jonathan