Обсуждение: [PATCH] fix ICU explorer link in locale documentation
Hello, Existing Postgres documentation states in doc/src/sgml/charset.sgml: The <ulink url="https://ssl.icu-project.org/icu-bin/locexp">ICU Locale Explorer</ulink> can be used to check the details of a particular locale definition. But the link is broken (SSL certificate does not include ssl.icu-project.org as allowed name). Correct link is, I believe, https://icu4c-demos.unicode.org/icu-bin/locexp Attached patch fixes the broken link. -- Anton Voloshin Postgres Professional: https://www.postgrespro.com Russian Postgres Company
Вложения
On Sun, Apr 4, 2021 at 9:53 AM Anton Voloshin <a.voloshin@postgrespro.ru> wrote: > > Hello, > > Existing Postgres documentation states in doc/src/sgml/charset.sgml: > The <ulink url="https://ssl.icu-project.org/icu-bin/locexp">ICU Locale > Explorer</ulink> can be used to check the details of a particular locale > definition. > > But the link is broken (SSL certificate does not include > ssl.icu-project.org as allowed name). Correct link is, I believe, > https://icu4c-demos.unicode.org/icu-bin/locexp > > Attached patch fixes the broken link. https://icu4c-demos.unicode.org/icu-bin/locexp generates a 404 for me now. This might be something temporary though, because AFAICT it's where you end up when you follow the links from the ICU git repo... -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
On 18/05/2021 03:46, Magnus Hagander wrote: > https://icu4c-demos.unicode.org/icu-bin/locexp generates a 404 for me now. > > This might be something temporary though, because AFAICT it's where > you end up when you follow the links from the ICU git repo... Yes, same 404 for me. This error has been reported on icu-issues mailing list on April 13th [1] and the reply from Stephan Pakebusch was: > This demo has been out of date (by several releases) and is being updated for ICU 69. > In the meantime there was an issue with this particular demo. > We’re looking into the problem you noted. > > I’m not sure if there’s a tracking issue for this specific, but you can follow the development on https://github.com/unicode-org/icu-demos So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is still the proper one, and eventually it will be fixed. Anyway, the old link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through "wrong domain in certificate" errors, still redirects to the same https://icu4c-demos.unicode.org/icu-bin/locexp I believe changing link in Postgres' docs is better than keeping the old one, even though they are currently both 404 one way or another. At least it would save people following that link from scary "Warning: Potential Security Risk Ahead" messages before properly 404-ing. [1] https://sourceforge.net/p/icu/mailman/icu-support/thread/CAD%2BuSKi%3DQeLWiivJmaFBHPg-tH9PjRriTOXxi9t2NQGr3VONww%40mail.gmail.com/#msg37261067 -- Anton Voloshin Postgres Professional, The Russian Postgres Company https://postgrespro.ru
On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote: > On 18/05/2021 03:46, Magnus Hagander wrote: > > https://icu4c-demos.unicode.org/icu-bin/locexp generates a 404 for me now. > > > > This might be something temporary though, because AFAICT it's where > > you end up when you follow the links from the ICU git repo... > > Yes, same 404 for me. This error has been reported on icu-issues mailing > list on April 13th [1] and the reply from Stephan Pakebusch was: > > > This demo has been out of date (by several releases) and is being updated for ICU 69. > > In the meantime there was an issue with this particular demo. > > We’re looking into the problem you noted. > > > > I’m not sure if there’s a tracking issue for this specific, but you can follow the development on https://github.com/unicode-org/icu-demos > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is > still the proper one, and eventually it will be fixed. Anyway, the old > link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through > "wrong domain in certificate" errors, still redirects to the same > https://icu4c-demos.unicode.org/icu-bin/locexp > > I believe changing link in Postgres' docs is better than keeping the old > one, even though they are currently both 404 one way or another. At > least it would save people following that link from scary "Warning: > Potential Security Risk Ahead" messages before properly 404-ing. > > [1] > https://sourceforge.net/p/icu/mailman/icu-support/thread/CAD%2BuSKi%3DQeLWiivJmaFBHPg-tH9PjRriTOXxi9t2NQGr3VONww%40mail.gmail.com/#msg37261067 I agree that the documentation link should be changed. There are two options: 1. Trust that they will fix it soon and change the link to https://icu4c-demos.unicode.org/icu-bin/locexp 2. Despair and remove the link from the documentation. I suggest that we wait until the end of the June 2021 commitfest and decide then. If it is still not fixed then, the second option is better - or we move it to the next commitfest. Yours, Laurenz Albe
On Thu, 2021-05-27 at 08:59 +0200, Laurenz Albe wrote: > On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote: > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is > > still the proper one, and eventually it will be fixed. Anyway, the old > > link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through > > "wrong domain in certificate" errors, still redirects to the same > > https://icu4c-demos.unicode.org/icu-bin/locexp > > > > I believe changing link in Postgres' docs is better than keeping the old > > one, even though they are currently both 404 one way or another. At > > least it would save people following that link from scary "Warning: > > Potential Security Risk Ahead" messages before properly 404-ing. > > > > [1] > > https://sourceforge.net/p/icu/mailman/icu-support/thread/CAD%2BuSKi%3DQeLWiivJmaFBHPg-tH9PjRriTOXxi9t2NQGr3VONww%40mail.gmail.com/#msg37261067 > > I agree that the documentation link should be changed. > > There are two options: > > 1. Trust that they will fix it soon and change the link to > https://icu4c-demos.unicode.org/icu-bin/locexp > > 2. Despair and remove the link from the documentation. > > I suggest that we wait until the end of the June 2021 commitfest and decide then. > If it is still not fixed then, the second option is better - or we move it to > the next commitfest. It is way past that time, and the link is still broken. So I guess it would be the best to remove the link from the documentation. Yours, Laurenz Albe
On Fri, Sep 3, 2021 at 09:39:45PM +0200, Laurenz Albe wrote: > On Thu, 2021-05-27 at 08:59 +0200, Laurenz Albe wrote: > > On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote: > > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is > > > still the proper one, and eventually it will be fixed. Anyway, the old > > > link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through > > > "wrong domain in certificate" errors, still redirects to the same > > > https://icu4c-demos.unicode.org/icu-bin/locexp > > > > > > I believe changing link in Postgres' docs is better than keeping the old > > > one, even though they are currently both 404 one way or another. At > > > least it would save people following that link from scary "Warning: > > > Potential Security Risk Ahead" messages before properly 404-ing. > > > > > > [1] > > > https://sourceforge.net/p/icu/mailman/icu-support/thread/CAD%2BuSKi%3DQeLWiivJmaFBHPg-tH9PjRriTOXxi9t2NQGr3VONww%40mail.gmail.com/#msg37261067 > > > > I agree that the documentation link should be changed. > > > > There are two options: > > > > 1. Trust that they will fix it soon and change the link to > > https://icu4c-demos.unicode.org/icu-bin/locexp > > > > 2. Despair and remove the link from the documentation. > > > > I suggest that we wait until the end of the June 2021 commitfest and decide then. > > If it is still not fixed then, the second option is better - or we move it to > > the next commitfest. > > It is way past that time, and the link is still broken. > > So I guess it would be the best to remove the link from the documentation. Should we change it to a link to the locexp source? https://github.com/unicode-org/icu-demos/tree/main/locexp This is the source for the locale explorer CGI which is on IBM's external website at: http://demo.icu-project.org/icu-bin/locexp -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.
On Mon, 2021-09-27 at 14:31 -0400, Bruce Momjian wrote: > On Fri, Sep 3, 2021 at 09:39:45PM +0200, Laurenz Albe wrote: > > On Thu, 2021-05-27 at 08:59 +0200, Laurenz Albe wrote: > > > On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote: > > > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is > > > > still the proper one, and eventually it will be fixed. Anyway, the old > > > > link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through > > > > "wrong domain in certificate" errors, still redirects to the same > > > > https://icu4c-demos.unicode.org/icu-bin/locexp > > > > > > > > I believe changing link in Postgres' docs is better than keeping the old > > > > one, even though they are currently both 404 one way or another. At > > > > least it would save people following that link from scary "Warning: > > > > Potential Security Risk Ahead" messages before properly 404-ing. > > > > > > I suggest that we wait until the end of the June 2021 commitfest and decide then. > > > If it is still not fixed then, the second option is better - or we move it to > > > the next commitfest. > > > > It is way past that time, and the link is still broken. > > > > So I guess it would be the best to remove the link from the documentation. > > Should we change it to a link to the locexp source? > > https://github.com/unicode-org/icu-demos/tree/main/locexp > > This is the source for the locale explorer CGI which is on IBM's > external website at: > > http://demo.icu-project.org/icu-bin/locexp I had a look at that and tried to build the software from source. It requires you to build ICU, and even then it failed to build for me. The build documentation is not very detailed. So I think we should not link to that. I noticed that two more external links have moved. Attached is a patch that fixes those links and removes the link to the locale explorer. Yours, Laurenz Albe
Вложения
On 29/09/2021 17:13, Laurenz Albe wrote: > I had a look at that and tried to build the software from source. > It requires you to build ICU, and even then it failed to build for me. > The build documentation is not very detailed. > So I think we should not link to that. > > I noticed that two more external links have moved. > > Attached is a patch that fixes those links and removes the link to > the locale explorer. +1 from me on both changes. We have to remove the locale explorer link, unfortunately. -- Anton Voloshin Postgres Professional, The Russian Postgres Company https://postgrespro.ru
On Wed, Sep 29, 2021 at 06:58:55PM +0700, Anton Voloshin wrote: > On 29/09/2021 17:13, Laurenz Albe wrote: > > I had a look at that and tried to build the software from source. > > It requires you to build ICU, and even then it failed to build for me. > > The build documentation is not very detailed. > > So I think we should not link to that. > > > > I noticed that two more external links have moved. > > > > Attached is a patch that fixes those links and removes the link to > > the locale explorer. > > +1 from me on both changes. We have to remove the locale explorer link, > unfortunately. Patch applied back to PG 10, where ICU was added. Thanks everyone for the work on this. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.
On Mon, 2021-10-04 at 17:11 -0400, Bruce Momjian wrote: > Patch applied back to PG 10, where ICU was added. Thanks everyone for > the work on this. Thanks! I think you can close the commitfest entry: https://commitfest.postgresql.org/35/3059/ Yours, Laurenz Albe
On Tue, Nov 2, 2021 at 02:31:29PM +0100, Laurenz Albe wrote: > On Mon, 2021-10-04 at 17:11 -0400, Bruce Momjian wrote: > > Patch applied back to PG 10, where ICU was added. Thanks everyone for > > the work on this. > > Thanks! > > I think you can close the commitfest entry: > https://commitfest.postgresql.org/35/3059/ Done by someone else: :-) 2021-11-02 19:44:13 Anton Voloshin (a.voloshin) Closed in commitfest 2021-11 with status: Committed -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.