Re: [PATCH] fix ICU explorer link in locale documentation

Поиск
Список
Период
Сортировка
От Laurenz Albe
Тема Re: [PATCH] fix ICU explorer link in locale documentation
Дата
Msg-id 9e64d4f34fdf686c09e4b5a86595dfe9645077bc.camel@cybertec.at
обсуждение исходный текст
Ответ на Re: [PATCH] fix ICU explorer link in locale documentation  (Bruce Momjian <bruce@momjian.us>)
Ответы Re: [PATCH] fix ICU explorer link in locale documentation
Список pgsql-docs
On Mon, 2021-09-27 at 14:31 -0400, Bruce Momjian wrote:
> On Fri, Sep  3, 2021 at 09:39:45PM +0200, Laurenz Albe wrote:
> > On Thu, 2021-05-27 at 08:59 +0200, Laurenz Albe wrote:
> > > On Thu, 2021-05-27 at 11:10 +0700, Anton Voloshin wrote:
> > > > So I guess the https://icu4c-demos.unicode.org/icu-bin/locexp link is 
> > > > still the proper one, and eventually it will be fixed. Anyway, the old 
> > > > link, https://ssl.icu-project.org/icu-bin/locexp, if one goes through 
> > > > "wrong domain in certificate" errors, still redirects to the same
> > > > https://icu4c-demos.unicode.org/icu-bin/locexp
> > > > 
> > > > I believe changing link in Postgres' docs is better than keeping the old 
> > > > one, even though they are currently both 404 one way or another. At 
> > > > least it would save people following that link from scary "Warning: 
> > > > Potential Security Risk Ahead" messages before properly 404-ing.
> > > 
> > > I suggest that we wait until the end of the June 2021 commitfest and decide then.
> > > If it is still not fixed then, the second option is better - or we move it to
> > > the next commitfest.
> > 
> > It is way past that time, and the link is still broken.
> > 
> > So I guess it would be the best to remove the link from the documentation.
> 
> Should we change it to a link to the locexp source?
> 
>         https://github.com/unicode-org/icu-demos/tree/main/locexp
> 
>         This is the source for the locale explorer CGI which is on IBM's
>         external website at:
>         
>             http://demo.icu-project.org/icu-bin/locexp

I had a look at that and tried to build the software from source.
It requires you to build ICU, and even then it failed to build for me.
The build documentation is not very detailed.
So I think we should not link to that.

I noticed that two more external links have moved.

Attached is a patch that fixes those links and removes the link to
the locale explorer.

Yours,
Laurenz Albe

Вложения

В списке pgsql-docs по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Minor doc fixes
Следующее
От: Anton Voloshin
Дата:
Сообщение: Re: [PATCH] fix ICU explorer link in locale documentation