Обсуждение: [PATCH] src\backend\utils\adt\numeric.c copy and past error

Поиск
Список
Период
Сортировка

[PATCH] src\backend\utils\adt\numeric.c copy and past error

От
Ranier Vilela
Дата:
Hi,
Possible copy and past error, found in numeric.c.
I believe I believe that the author's intention was to return const_zero.

regards,
Ranier Vilela
Вложения

Re: [PATCH] src\backend\utils\adt\numeric.c copy and past error

От
Tom Lane
Дата:
Ranier Vilela <ranier.vf@gmail.com> writes:
> Possible copy and past error, found in numeric.c.
> I believe I believe that the author's intention was to return const_zero.

Did you read the comment just above there?

            regards, tom lane



Re: [PATCH] src\backend\utils\adt\numeric.c copy and past error

От
Ranier Vilela
Дата:
Hi,
Yes, but the comment it does not clarify that the return of the variable "const_one" is intentional, instead of "const_zero".
Anybody with reads the source, can think which is a copy and paste mistake.

regards
Ranier Vilela

Em dom., 19 de jan. de 2020 às 21:22, Tom Lane <tgl@sss.pgh.pa.us> escreveu:
Ranier Vilela <ranier.vf@gmail.com> writes:
> Possible copy and past error, found in numeric.c.
> I believe I believe that the author's intention was to return const_zero.

Did you read the comment just above there?

                        regards, tom lane

Re: [PATCH] src\backend\utils\adt\numeric.c copy and past error

От
Tom Lane
Дата:
Ranier Vilela <ranier.vf@gmail.com> writes:
> Yes, but the comment it does not clarify that the return of the variable
> "const_one" is intentional, instead of "const_zero".

I'm not sure which part of "NaN ^ 0 = 1" doesn't clarify for you that
the intended result is 1.

Even without the comment, if you'd bothered to run the regression tests
you'd have noted a failure of a test case clearly intended to test
exactly this behavior.

            regards, tom lane