Обсуждение: Commit fest 2019-09
Hi all, Based on the current clock we are going to be the 1st of September anywhere on Earth in approximately 7 hours: https://www.timeanddate.com/time/zones/aoe Once this happens, I will switch the commit fest as in progress and it will not be possible to add any new patches. I am not sure if somebody would like to volunteer, but I propose myself as commit fest manager for the next session. Feel free to reply to this thread if you feel that you could help out as manager for this time. Thanks, and happy hacking! -- Michael
Вложения
On 2019-Sep-01, Michael Paquier wrote:
> I am not sure if somebody would like to volunteer, but I propose
> myself as commit fest manager for the next session. Feel free to
> reply to this thread if you feel that you could help out as manager
> for this time.
Hello,
Thanks Michael for handling these tasks over the weekend.
I had offered myself as CFM for this one when the cycle started, so I'm
happy to do it.
At this time, the commitfest starts with:
status │ count
────────────────────────┼───────
Needs review │ 165
Waiting on Author │ 30
Ready for Committer │ 11
Returned with Feedback │ 1
Moved to next CF │ 2
Committed │ 14
Rejected │ 1
Withdrawn │ 4
There's an embarrasingly large number of patches in the "Bug Fixes"
section. I encourage reviewers to look at those that "Need Review" so
that they can set "Ready for Committer" and get a committer to finish
them up:
status │ count
─────────────────────┼───────
Committed │ 2
Needs review │ 20
Ready for Committer │ 2
Waiting on Author │ 4
Withdrawn │ 1
Thanks,
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Hi Alvaro,
On Mon, Sep 2, 2019 at 6:47 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
On 2019-Sep-01, Michael Paquier wrote:
> I am not sure if somebody would like to volunteer, but I propose
> myself as commit fest manager for the next session. Feel free to
> reply to this thread if you feel that you could help out as manager
> for this time.
Hello,
Thanks Michael for handling these tasks over the weekend.
I had offered myself as CFM for this one when the cycle started, so I'm
happy to do it.
At this time, the commitfest starts with:
status │ count
────────────────────────┼───────
Needs review │ 165
Waiting on Author │ 30
Ready for Committer │ 11
Returned with Feedback │ 1
Moved to next CF │ 2
Committed │ 14
Rejected │ 1
Withdrawn │ 4
There's an embarrasingly large number of patches in the "Bug Fixes"
section. I encourage reviewers to look at those that "Need Review" so
that they can set "Ready for Committer" and get a committer to finish
them up:
status │ count
─────────────────────┼───────
Committed │ 2
Needs review │ 20
Ready for Committer │ 2
Waiting on Author │ 4
Withdrawn │ 1
Thanks,
I think it is a lot of work if you want I can help with that. (Just start getting your messages on threads)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Ibrar Ahmed
Hi Ibrar On 2019-Sep-04, Ibrar Ahmed wrote: > On Mon, Sep 2, 2019 at 6:47 PM Alvaro Herrera <alvherre@2ndquadrant.com> > wrote: > > There's an embarrasingly large number of patches in the "Bug Fixes" > > section. I encourage reviewers to look at those that "Need Review" so > > that they can set "Ready for Committer" and get a committer to finish > > them up: > > status │ count > > ─────────────────────┼─────── > > Committed │ 2 > > Needs review │ 20 > > Ready for Committer │ 2 > > Waiting on Author │ 4 > > Withdrawn │ 1 > I think it is a lot of work if you want I can help with that. (Just start > getting your messages on threads) If you can review bugfix patches, that would certainly be welcome. Thanks, -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On this CF's second week, numbers are:
statusstring │ week1 │ week2
────────────────────────┼───────┼───────
Needs review │ 165 │ 138
Waiting on Author │ 30 │ 44
Ready for Committer │ 11 │ 5
Returned with Feedback │ 1 │ 4
Moved to next CF │ 2 │ 4
Committed │ 14 │ 23
Rejected │ 1 │ 1
Withdrawn │ 4 │ 9
(8 filas)
One of the "withdrawn" ones was a duplicate entry (2087) for a bugfix patch
(1970).
We cleared a large fraction of the patches that were waiting on
committers. It seems that we now need people (including committers) to
focus on patches that are "Needs Review". I marked a bunch of those as
Waiting-on-Author; patch authors have a lot of pending work.
Here's the set of patches Ready-for-Committer. Note the majority is
pgbench-related:
patch_id │ name
──────────┼───────────────────────────────────────────────────────────────
2217 │ pgbench - allow to create partitioned "account" tables
2069 │ Expose queryid in pg_stat_activity in log_line_prefix
2086 │ pgbench - extend initialization phase control
1736 │ pgbench - add pseudo-random permutation function
2091 │ pgbench - add \aset to store results of combined queries (\;)
I am inclined to think that 2217 is clearly something we want; 1736 is
something we probably want; and 2086 and 2091 are on the verge of being
unwanted things.
We have a number of apparently actionable bugfixes still:
patch_id │ statusstring │ name
──────────┼───────────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
2224 │ Needs review │ Race condition in logical walsender causes long postgresql shutdown delay
2026 │ Needs review │ Spurious "apparent wraparound" via SimpleLruTruncate() rounding (data loss)
2179 │ Needs review │ Fix support for hypothetical indexes using BRIN access method
2187 │ Needs review │ Duplicated LSN in ReorderBuffer
2221 │ Needs review │ Add mandatory access control for TRUNCATE
2044 │ Needs review │ propagating replica identity to partitions
528 │ Needs review │ Fix the optimization to skip WAL-logging on table created in same transaction
2025 │ Needs review │ SimpleLruTruncate() mutual exclusion (data loss from lack thereof)
1995 │ Needs review │ Replica with large recovery_min_apply_delay is not receiving changes from master after
restartuntil this delay is expired
2215 │ Needs review │ pg_upgrade fails with non-standard ACL
2266 │ Needs review │ Fix up partitionwise join on how equi-join conditions between the partition keys are
identified
2050 │ Needs review │ Fix unique join costings
2062 │ Needs review │ Unaccent extension python script Issue in Windows
2205 │ Needs review │ CVE-2017-7484-induced bugs, or, btree cmp functions are not leakproof?
2054 │ Needs review │ fix for BUG #3720: wrong results at using ltree
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
The third week for this commitfest starts. The numbers now:
statusstring │ week1 │ week2 │ week3
────────────────────────┼───────┼───────┼───────
Needs review │ 165 │ 138 │ 116
Waiting on Author │ 30 │ 44 │ 51
Ready for Committer │ 11 │ 5 │ 8
Returned with Feedback │ 1 │ 4 │ 5
Moved to next CF │ 2 │ 4 │ 4
Committed │ 14 │ 23 │ 32
Rejected │ 1 │ 1 │ 1
Withdrawn │ 4 │ 9 │ 11
(8 filas)
It seems to me that we're moving forward at a decent pace, if not super
fast. At least, we're keeping patch authors busy! The number of
patches waiting on committers are steadily low, which seems to be saying
that committers are making a pretty decent job at the final instance for
patches. Still, there's a lot of stuff that just sits there ... and of
course committers could help with that also.
That said, we do need non-committer contributors to review other
people's patches. Please do your part and review patches of at least
equivalent complexity to the patches you're submitting!
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2019-Sep-16, Alvaro Herrera wrote: > The third week for this commitfest starts. The numbers now: > > statusstring │ week1 │ week2 │ week3 > ────────────────────────┼───────┼───────┼─────── > Needs review │ 165 │ 138 │ 116 > Waiting on Author │ 30 │ 44 │ 51 FWIW I have just went over all the waiting-on-author patches and marked a few as needs-review in cases where new versions had been posted and CF app had not been updated. So now we have NR: 127, WoA: 40. Patch authors, please make sure to update the status of your patch in the CF app when posting new versions! -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Hello
The fourth week of this commitfest begins with these numbers:
statusstring │ week1 │ week2 │ week3 │ week4
────────────────────────┼───────┼───────┼───────┼───────
Needs review │ 165 │ 138 │ 116 │ 118
Waiting on Author │ 30 │ 44 │ 51 │ 44
Ready for Committer │ 11 │ 5 │ 8 │ 11
Returned with Feedback │ 1 │ 4 │ 5 │ 5
Moved to next CF │ 2 │ 4 │ 4 │ 4
Committed │ 14 │ 23 │ 32 │ 34
Rejected │ 1 │ 1 │ 1 │ 1
Withdrawn │ 4 │ 9 │ 11 │ 11
Progress last week is disappointing. I hope we manage to get more patches
closed this week.
In terms of bugfixes, this is how we started the month:
status │ week1 │ week4
────────────────────────┼───────┼───────
Needs review │ 20 │ 10
Waiting on Author │ 4 │ 6
Ready for Committer │ 2 │ 1
Returned with Feedback │ 0 │ 1
Moved to next CF │ 0 │ 1
Committed │ 2 │ 6
Withdrawn │ 1 │ 2
We've not made a lot of progress here either, only four bugfix patches
committed in three weeks :-(
In terms of patch author participation in reviewing other people's
patches, the metrics are decidedly disappointing. Strongest reviewers,
counting replies on threads for patches other than one's own:
* Michael Paquier
* Álvaro Herrera (discounting "please rebase" / "marked WoA" pings)
* Amit Kapila
* Tom Lane
Everyone is welcome to join the party!
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Pencils down!
Commitfest now has officially ended, and here are some numbers:
statusstring │ week1 │ week2 │ week3 │ week4 │ count
────────────────────────┼───────┼───────┼───────┼───────┼───────
Needs review │ 165 │ 138 │ 116 │ 118 │ 117
Waiting on Author │ 30 │ 44 │ 51 │ 44 │ 39
Ready for Committer │ 11 │ 5 │ 8 │ 11 │ 9
Returned with Feedback │ 1 │ 4 │ 5 │ 5 │ 8
Moved to next CF │ 2 │ 4 │ 4 │ 4 │ 5
Committed │ 14 │ 23 │ 32 │ 34 │ 38
Rejected │ 1 │ 1 │ 1 │ 1 │ 1
Withdrawn │ 4 │ 9 │ 11 │ 11 │ 11
This fourth week was almost as disappointing as the previous one; only
four CF entries got marked committed. I attribute that to the fact that
we have one of our most active committers busy with the pg12 release,
and most of the other committers are not paying any attention to the
commitfest, instead spending their time developing other patches (I
suppose that means our future still looks bright, but in CF terms it's
still sad.)
We made no progress at all on bugfixes this week -- numbers are
identical to the past one.
On the bright side, a lot of non-committer reviewers seem to have become
more active -- in a subjective look, quite a few patches look better now
than they did a week ago. Also, patch authors seem to have become more
engaged, so there aren't as many patches that don't even apply.
I will be spending some time today marking patches that weren't updated
in time as returned-with-feedback, and moving others to the next
commitfest, and then I'll close this commitfest. I'll be also trying to
commit a couple of pending patches, so I may yet provide one last
update.
Thanks everyone,
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
I've closed the following items as Returned with Feedback. These were
all Waiting-on-Author for a long time, with no new versions posted. In
most cases these are still patches that appear to be useful ... but if
they're not kept updated to feedback, they're clutter in the CF system.
patch_id │ author │ name
──────────┼────────────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────
1854 │ Aya Iwata │ libpq trace log
2268 │ Ian Barwick │ psql: add tab completion for \df slash command suffixes
1796 │ Chris Travers │ documenting signal handling with readme
2051 │ Karl Pinc │ DOC: Document encode() and decode() base64 encoding
2060 │ takuma hoshiai │ suppress errors thrown by to_reg*()
2082 │ Sandro Mani │ Mingw: Fix import library extension, build actual static libraries
2095 │ Daniel Gustafsson │ pg_upgrade version and path checking
2148 │ Timur Birsh │ vacuumlo: report the number of large objects going to be removed
2223 │ Daniel Migowski │ Adding column "mem_usage" to view pg_prepared_statements
2028 │ Mike Palmiotto │ Flexible partition pruning hook
2108 │ Thomas Munro │ Parallel-aware file_fdw
944 │ Nikhil Sontakke │ Logical decoding of two-phase transactions
1961 │ Petr Jelínek │ Synchronizing slots from primary to standby
2167 │ Peter Eisentraut │ unlogged sequences
2124 │ Matwey V. Kornilov │ Introduce spgist quadtree @<(point,circle) operator
1533 │ Matheus Oliveira │ Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT
2034 │ Takamichi Osumi │ extension patch of CREATE OR REPLACE TRIGGER
If somebody wants co-authorship for a patch whose author seems
unresponsive, I suggest to ping them about that and run with it if they
don't respond in a reasonable timeframe.
(There were a few others patches Waiting-on-Author, but these didn't
look as stale. I didn't touch anything in the bugfixes section either.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2019-Sep-30, Alvaro Herrera wrote:
> I've closed the following items as Returned with Feedback. These were
> all Waiting-on-Author for a long time, with no new versions posted. In
> most cases these are still patches that appear to be useful ... but if
> they're not kept updated to feedback, they're clutter in the CF system.
Some more returned with feedback:
patch_id │ author │ name
──────────┼────────────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────
1294 │ Ildus Kurbangaliev │ Custom compression methods
1695 │ Takeshi Ideriha │ Global shared meta cache
2166 │ Takeshi Ideriha │ Shared memory context
2043 │ Jeff Janes │ Bloom index cost model
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Hello,
After closing a few patches that have been dead for months, and moving
the rest to the next commitfest, here's the results:
statusstring │ week1 │ week2 │ week3 │ week4 │ final
────────────────────────┼───────┼───────┼───────┼───────┼───────
Needs review │ 165 │ 138 │ 116 │ 118 │ 0
Waiting on Author │ 30 │ 44 │ 51 │ 44 │ 0
Ready for Committer │ 11 │ 5 │ 8 │ 11 │ 0
Returned with Feedback │ 1 │ 4 │ 5 │ 5 │ 28
Moved to next CF │ 2 │ 4 │ 4 │ 4 │ 191
Committed │ 14 │ 23 │ 32 │ 34 │ 42
Rejected │ 1 │ 1 │ 1 │ 1 │ 1
Withdrawn │ 4 │ 9 │ 11 │ 11 │ 12
This means we got 28 patches committed during this month ... which is
a rather concerningly low figure. I really hope we can do much better
in the upcoming three commitfests -- at least, we're not going to have
a stable release at the same time.
And with that, I've closed the commitfest. I know there's still
technically a few hours left ... but if anyone wants to commit one more
patch, they can mark it committed in the next commitfest without
remorse.
Thanks everyone,
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Mon, Sep 30, 2019 at 04:24:15PM -0300, Alvaro Herrera wrote: > Hello, > > After closing a few patches that have been dead for months, and moving > the rest to the next commitfest, here's the results: > > statusstring │ week1 │ week2 │ week3 │ week4 │ final > ────────────────────────┼───────┼───────┼───────┼───────┼─────── > Needs review │ 165 │ 138 │ 116 │ 118 │ 0 > Waiting on Author │ 30 │ 44 │ 51 │ 44 │ 0 > Ready for Committer │ 11 │ 5 │ 8 │ 11 │ 0 > Returned with Feedback │ 1 │ 4 │ 5 │ 5 │ 28 > Moved to next CF │ 2 │ 4 │ 4 │ 4 │ 191 > Committed │ 14 │ 23 │ 32 │ 34 │ 42 > Rejected │ 1 │ 1 │ 1 │ 1 │ 1 > Withdrawn │ 4 │ 9 │ 11 │ 11 │ 12 > > This means we got 28 patches committed during this month ... which is > a rather concerningly low figure. I really hope we can do much better > in the upcoming three commitfests -- at least, we're not going to have > a stable release at the same time. > > And with that, I've closed the commitfest. I know there's still > technically a few hours left ... but if anyone wants to commit one more > patch, they can mark it committed in the next commitfest without > remorse. > > Thanks everyone, Thanks for doing all this work! Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
On 9/30/19 5:26 PM, David Fetter wrote: > > Thanks for doing all this work! +1! -- -David david@pgmasters.net
On Tue, Oct 1, 2019 at 12:54 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > > Hello, > > After closing a few patches that have been dead for months, and moving > the rest to the next commitfest, here's the results: > > statusstring │ week1 │ week2 │ week3 │ week4 │ final > ────────────────────────┼───────┼───────┼───────┼───────┼─────── > Needs review │ 165 │ 138 │ 116 │ 118 │ 0 > Waiting on Author │ 30 │ 44 │ 51 │ 44 │ 0 > Ready for Committer │ 11 │ 5 │ 8 │ 11 │ 0 > Returned with Feedback │ 1 │ 4 │ 5 │ 5 │ 28 > Moved to next CF │ 2 │ 4 │ 4 │ 4 │ 191 > Committed │ 14 │ 23 │ 32 │ 34 │ 42 > Rejected │ 1 │ 1 │ 1 │ 1 │ 1 > Withdrawn │ 4 │ 9 │ 11 │ 11 │ 12 > > This means we got 28 patches committed during this month ... which is > a rather concerningly low figure. > Yes, I agree that we can improve these numbers. However, like others, I would also like to thank you for sincere and dedicated efforts in this CF. It really helps in moving things forward. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
On Mon, Sep 30, 2019 at 06:20:31PM -0400, David Steele wrote: > On 9/30/19 5:26 PM, David Fetter wrote: >> >> Thanks for doing all this work! > > +1! Thanks, Alvaro! -- Michael