Обсуждение: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explainplan only when user try to download it

Hi,

Embedding images using .toDataURL() method hits the performance of the explain plan rendering if the plan is complex because first it downloads the images then it will convert each images into base64, to improve the performance we will embed the images only when downloading of SVG is called and not when displaying the graphical plan.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi Murtuza,

I was just going through code change, and I would suggest one small change.

In the image_mapper.js, export it as default, as it will have only one export. Then you can use it as imageMapper.default rather than imageMapper.imageMapper.

Otherwise, looks fine to me. I didn't test though :P

On Thu, May 30, 2019 at 2:41 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

Embedding images using .toDataURL() method hits the performance of the explain plan rendering if the plan is complex because first it downloads the images then it will convert each images into base64, to improve the performance we will embed the images only when downloading of SVG is called and not when displaying the graphical plan.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

Here is updated patch.

On Thu, May 30, 2019 at 4:06 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Murtuza,

I was just going through code change, and I would suggest one small change.

In the image_mapper.js, export it as default, as it will have only one export. Then you can use it as imageMapper.default rather than imageMapper.imageMapper.

Otherwise, looks fine to me. I didn't test though :P

On Thu, May 30, 2019 at 2:41 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

Embedding images using .toDataURL() method hits the performance of the explain plan rendering if the plan is complex because first it downloads the images then it will convert each images into base64, to improve the performance we will embed the images only when downloading of SVG is called and not when displaying the graphical plan.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Thanks and Regards,

Aditya Toshniwal

Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"