Обсуждение: Quitting the thes

Hi all,

Here my first patch for postgres. Starting by an easy thing, I correct 
the duplicated "the the" strings from comments on some files.

- src/backend/executor/execExpr.c
- src/include/c.h
- src/include/jit/llvmjit_emit.h
- src/include/nodes/execnodes.h
- src/include/replication/logical.h

Any feedback are welcome!

Thanks a lot,

On Mon, May 13, 2019 at 04:52:15PM -0300, Stephen Amell wrote:
> Here my first patch for postgres. Starting by an easy thing, I correct the
> duplicated "the the" strings from comments on some files.

Welcome!

> - src/backend/executor/execExpr.c
> - src/include/c.h
> - src/include/jit/llvmjit_emit.h
> - src/include/nodes/execnodes.h
> - src/include/replication/logical.h
>
> Any feedback are welcome!

Thanks, committed.  I have noticed an extra one in reorderbuffer.c.

If you get interested in more areas of the code, there is plently of
small work items which can be reviewed or worked on.

We have on the wiki a manual about how to submit a patch:
https://wiki.postgresql.org/wiki/Submitting_a_Patch

Patches go through a dedicated commit fest app, and it has many small
fishes which can be worked on:
https://commitfest.postgresql.org/23/
You could get more familiar with some areas of the code this way.

Thanks,
--
Michael

On 2019-May-14, Michael Paquier wrote:

> Thanks, committed.  I have noticed an extra one in reorderbuffer.c.

Some grepping found a bit more; patch attached.


-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On Wed, Jun 12, 2019 at 02:45:27PM -0400, Alvaro Herrera wrote:
> Some grepping found a bit more; patch attached.

Indeed.  There were much more.  I just got to look with stuff like
that:
find . -name "*.c" | xargs egrep "(\b[a-zA-Z]+) \1\b"

But I did not find any more spots.  Indentation is incorrect in
test_integerset.c.
--
Michael

On 2019-Jun-13, Michael Paquier wrote:

> On Wed, Jun 12, 2019 at 02:45:27PM -0400, Alvaro Herrera wrote:
> > Some grepping found a bit more; patch attached.
> 
> Indeed.  There were much more.  I just got to look with stuff like
> that:
> find . -name "*.c" | xargs egrep "(\b[a-zA-Z]+) \1\b"

This is what I used:
git grep '\<\([a-z_ ]\+\)\> \<\1\>'

> But I did not find any more spots.  Indentation is incorrect in
> test_integerset.c.

Indeed ... fixed.

Thanks for looking,

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services