Обсуждение: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

Hi Khushboo

#3605 is fixed and found below issue in #2392

• As per steps given in RM, I have perform the same. But when I delete the row, delete button is still enabled and save button is disabled even though newly created row is still there. Apart from that code looks good to me. Please fix it.   

On Thu, Apr 4, 2019 at 5:27 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached patch to fix:

1. #3605 - Edit Data: Deleting N number of rows makes first N number of rows disable

2. #2392 - Datagrid: If we delete any row it also saves newly added row

Thanks,

Khushboo

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

Hi,

Please find the attached updated patch.

Thanks,

Khushboo

On Fri, Apr 5, 2019 at 11:32 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Khushboo

#3605 is fixed and found below issue in #2392

• As per steps given in RM, I have perform the same. But when I delete the row, delete button is still enabled and save button is disabled even though newly created row is still there. Apart from that code looks good to me. Please fix it.   

Fixed.

On Thu, Apr 4, 2019 at 5:27 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached patch to fix:

1. #3605 - Edit Data: Deleting N number of rows makes first N number of rows disable

2. #2392 - Datagrid: If we delete any row it also saves newly added row

Thanks,

Khushboo

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

Hi Khushboo

Found some new issues:

1. Delete button gets enabled if I select any new cell (type text) to enter some value.

1. Add two new rows, don't click on Save button and delete couple of rows. Colour of newly added rows will changed to green.

1. Create a table with Serial and Text column. Add two new rows, specify the values and don't click on Save button. Delete some rows and then click on Save button, data is saved in the database but grid is showing same serial id for two newly created rows. After re-run the query it shows the correct value. 

Can you please fix the above issues.

On Mon, Apr 8, 2019 at 2:20 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached updated patch.

Thanks,

Khushboo

On Fri, Apr 5, 2019 at 11:32 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Khushboo

#3605 is fixed and found below issue in #2392

• As per steps given in RM, I have perform the same. But when I delete the row, delete button is still enabled and save button is disabled even though newly created row is still there. Apart from that code looks good to me. Please fix it.   

Fixed.

On Thu, Apr 4, 2019 at 5:27 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached patch to fix:

1. #3605 - Edit Data: Deleting N number of rows makes first N number of rows disable

2. #2392 - Datagrid: If we delete any row it also saves newly added row

Thanks,

Khushboo

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

Hi Khushboo

Following are my review comments:

• Jasmine test case are failing.

• Create a table with two columns id bigint (must be primary key) and name text. Insert couple of rows, now select any two rows and mark it for deletion, add new row and then click on Save button. Grid is not refreshed.     

On Tue, Apr 16, 2019 at 11:34 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached patch with some modification discussed at Redmine for the RM #2392.

1. On deletion, strikeout the selected rows and delete those while clicking on the Save button.

2. If only newly added rows are to be deleted then delete those directly.

Also, Slickgrid has been upgraded to the latest v2.3.4.

Thanks,

Khushboo

On Tue, Apr 9, 2019 at 11:46 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Khushboo

Found some new issues:

1. Delete button gets enabled if I select any new cell (type text) to enter some value.

Fixed 

1. Add two new rows, don't click on Save button and delete couple of rows. Colour of newly added rows will changed to green.

Not applicable now 

1. Create a table with Serial and Text column. Add two new rows, specify the values and don't click on Save button. Delete some rows and then click on Save button, data is saved in the database but grid is showing same serial id for two newly created rows. After re-run the query it shows the correct value. 

Fixed 

Can you please fix the above issues.

On Mon, Apr 8, 2019 at 2:20 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached updated patch.

Thanks,

Khushboo

On Fri, Apr 5, 2019 at 11:32 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Khushboo

#3605 is fixed and found below issue in #2392

• As per steps given in RM, I have perform the same. But when I delete the row, delete button is still enabled and save button is disabled even though newly created row is still there. Apart from that code looks good to me. Please fix it.   

Fixed.

On Thu, Apr 4, 2019 at 5:27 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached patch to fix:

1. #3605 - Edit Data: Deleting N number of rows makes first N number of rows disable

2. #2392 - Datagrid: If we delete any row it also saves newly added row

Thanks,

Khushboo

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246