Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes
Дата
Msg-id CANxoLDdAiOeoWuCg6=qb=TokcEfJ4dGd9CjXr0RCTcVp+WA6fw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Khushboo

Found some new issues:
  1. Delete button gets enabled if I select any new cell (type text) to enter some value.
  2. Add two new rows, don't click on Save button and delete couple of rows. Colour of newly added rows will changed to green.
  3. Create a table with Serial and Text column. Add two new rows, specify the values and don't click on Save button. Delete some rows and then click on Save button, data is saved in the database but grid is showing same serial id for two newly created rows. After re-run the query it shows the correct value. 
Can you please fix the above issues.

On Mon, Apr 8, 2019 at 2:20 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached updated patch.

Thanks,
Khushboo

On Fri, Apr 5, 2019 at 11:32 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

#3605 is fixed and found below issue in #2392
  • As per steps given in RM, I have perform the same. But when I delete the row, delete button is still enabled and save button is disabled even though newly created row is still there. Apart from that code looks good to me. Please fix it.   

Fixed.
On Thu, Apr 4, 2019 at 5:27 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix:

1. #3605 - Edit Data: Deleting N number of rows makes first N number of rows disable
2. #2392 - Datagrid: If we delete any row it also saves newly added row

Thanks,
Khushboo




--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Yosry Muhammad
Дата:
Сообщение: GSoC Proposal - pgAdmin4 Query Tool Automatic Mode Detection
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Fix an issue where the dropdown becomes misaligned/di