Обсуждение: A method to asynchronously LISTEN ?
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Tuesday, 26 February, 2019 22:17:12
Subject: Re: A method to asynchronously LISTEN ?
On Tue, 26 Feb 2019 at 12:29, David G. Johnston <david.g.johnston@gmail.com> wrote:The question being asked is whether executeUpdate method performs synchronous execution of the listener function queue during its execution.This after sending the command to the server and the server completing execution of the NOTIFY. This assumes that the server places the notification on the channel for pick-up immediately (which will not be the case within a transaction).While the client is, IIRC, synchronous, thus the local order of operations can be controlled, the server is asynchronous and thus this test is exposed to timing issues. Maybe we need something like conn.listenSync() that blocks until a notification payload is received on the connection...?kind of defeats the asynchronous aspect, no ?
Hello,I do not think there is a need for something like conn.listenSync().We were just intrigued about the test.In fact the current proposition should just work fine and we would like to test it.How could we have access to a postgresql-*.jdbc.jar that includes this feature ?Regards,Philippe
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Tuesday, 26 February, 2019 22:17:12
Subject: Re: A method to asynchronously LISTEN ?On Tue, Feb 26, 2019 at 12:04 PM Dave Cramer <pg@fastcrypt.com> wrote:On Tue, 26 Feb 2019 at 12:29, David G. Johnston <david.g.johnston@gmail.com> wrote:The question being asked is whether executeUpdate method performs synchronous execution of the listener function queue during its execution.This after sending the command to the server and the server completing execution of the NOTIFY. This assumes that the server places the notification on the channel for pick-up immediately (which will not be the case within a transaction).While the client is, IIRC, synchronous, thus the local order of operations can be controlled, the server is asynchronous and thus this test is exposed to timing issues. Maybe we need something like conn.listenSync() that blocks until a notification payload is received on the connection...?kind of defeats the asynchronous aspect, no ?You'd still want an asynchronous API for people but JavaScript introduced the "async/await" feature for a reason. In this case making it "sync" instead of coding up wait loop seems desirable. That said its quite possible I'm missing some existing feature as I haven't used this API at all.David J.
After starting the testNotify() below, we execute from pgadmin : notify mynotification
But the listener is not notified.
Did we miss something ?
public void testNotify() throws SQLException, InterruptedException {
final AtomicBoolean flag = new AtomicBoolean(false);
Statement stmt = conn.createStatement();
((org.postgresql.PGConnection)conn).addNotificationListener(new org.postgresql.PGNotificationListener() {
@Override
public void notification(org.postgresql.PGNotification notification) {
flag.set(true);
System.out.println("Notification received");
}
});
stmt.executeUpdate("LISTEN mynotification");
// stmt.executeUpdate("NOTIFY mynotification");
Thread.sleep(30000);
org.postgresql.PGNotification[] notifications = conn.unwrap(org.postgresql.PGConnection.class).getNotifications();
//assertTrue(flag.get());
//assertNotNull(notifications);
//assertEquals(1, notifications.length);
//assertEquals("mynotification", notifications[0].getName());
//long endMillis = System.currentTimeMillis();
//long runtime = endMillis - startMillis;
//assertNull("There have been notifications, although none have been expected.",notifications);
//assertTrue("We didn't wait long enough! runtime=" + runtime, runtime > 450);
stmt.close();
}
To: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Wednesday, 27 February, 2019 11:53:59
Subject: Re: A method to asynchronously LISTEN ?
Hello,I do not think there is a need for something like conn.listenSync().We were just intrigued about the test.In fact the current proposition should just work fine and we would like to test it.How could we have access to a postgresql-*.jdbc.jar that includes this feature ?Regards,Philippe
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Tuesday, 26 February, 2019 22:17:12
Subject: Re: A method to asynchronously LISTEN ?On Tue, Feb 26, 2019 at 12:04 PM Dave Cramer <pg@fastcrypt.com> wrote:On Tue, 26 Feb 2019 at 12:29, David G. Johnston <david.g.johnston@gmail.com> wrote:The question being asked is whether executeUpdate method performs synchronous execution of the listener function queue during its execution.This after sending the command to the server and the server completing execution of the NOTIFY. This assumes that the server places the notification on the channel for pick-up immediately (which will not be the case within a transaction).While the client is, IIRC, synchronous, thus the local order of operations can be controlled, the server is asynchronous and thus this test is exposed to timing issues. Maybe we need something like conn.listenSync() that blocks until a notification payload is received on the connection...?kind of defeats the asynchronous aspect, no ?You'd still want an asynchronous API for people but JavaScript introduced the "async/await" feature for a reason. In this case making it "sync" instead of coding up wait loop seems desirable. That said its quite possible I'm missing some existing feature as I haven't used this API at all.David J.
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Thursday, 28 February, 2019 10:52:44
Subject: Re: A method to asynchronously LISTEN ?
After starting the testNotify() below, we execute from pgadmin : notify mynotification
But the listener is not notified.
Did we miss something ?
public void testNotify() throws SQLException, InterruptedException {
final AtomicBoolean flag = new AtomicBoolean(false);
Statement stmt = conn.createStatement();
((org.postgresql.PGConnection)conn).addNotificationListener(new org.postgresql.PGNotificationListener() {
@Override
public void notification(org.postgresql.PGNotification notification) {
flag.set(true);
System.out.println("Notification received");
}
});
stmt.executeUpdate("LISTEN mynotification");
// stmt.executeUpdate("NOTIFY mynotification");
Thread.sleep(30000);
org.postgresql.PGNotification[] notifications = conn.unwrap(org.postgresql.PGConnection.class).getNotifications();
//assertTrue(flag.get());
//assertNotNull(notifications);
//assertEquals(1, notifications.length);
//assertEquals("mynotification", notifications[0].getName());
//long endMillis = System.currentTimeMillis();
//long runtime = endMillis - startMillis;
//assertNull("There have been notifications, although none have been expected.",notifications);
//assertTrue("We didn't wait long enough! runtime=" + runtime, runtime > 450);
stmt.close();
}
To: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Wednesday, 27 February, 2019 11:53:59
Subject: Re: A method to asynchronously LISTEN ?
Hello,I do not think there is a need for something like conn.listenSync().We were just intrigued about the test.In fact the current proposition should just work fine and we would like to test it.How could we have access to a postgresql-*.jdbc.jar that includes this feature ?Regards,Philippe
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Tuesday, 26 February, 2019 22:17:12
Subject: Re: A method to asynchronously LISTEN ?On Tue, Feb 26, 2019 at 12:04 PM Dave Cramer <pg@fastcrypt.com> wrote:On Tue, 26 Feb 2019 at 12:29, David G. Johnston <david.g.johnston@gmail.com> wrote:The question being asked is whether executeUpdate method performs synchronous execution of the listener function queue during its execution.This after sending the command to the server and the server completing execution of the NOTIFY. This assumes that the server places the notification on the channel for pick-up immediately (which will not be the case within a transaction).While the client is, IIRC, synchronous, thus the local order of operations can be controlled, the server is asynchronous and thus this test is exposed to timing issues. Maybe we need something like conn.listenSync() that blocks until a notification payload is received on the connection...?kind of defeats the asynchronous aspect, no ?You'd still want an asynchronous API for people but JavaScript introduced the "async/await" feature for a reason. In this case making it "sync" instead of coding up wait loop seems desirable. That said its quite possible I'm missing some existing feature as I haven't used this API at all.David J.
Hello,could you pleas advise what is wrong in our testing ?We retrieved the git sources, build them.Modified the testNotify() as shown below.When performing "NOTIFY mynotification" from an SQL client, we do not see the "Notification received" message as expected.Thank you.Regards,Philippe Ebersohl
From: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Thursday, 28 February, 2019 10:52:44
Subject: Re: A method to asynchronously LISTEN ?Hello,we retrieved the sources.
After starting the testNotify() below, we execute from pgadmin : notify mynotification
But the listener is not notified.
Did we miss something ?
public void testNotify() throws SQLException, InterruptedException {
final AtomicBoolean flag = new AtomicBoolean(false);
Statement stmt = conn.createStatement();
((org.postgresql.PGConnection)conn).addNotificationListener(new org.postgresql.PGNotificationListener() {
@Override
public void notification(org.postgresql.PGNotification notification) {
flag.set(true);System.out.println("Notification received");
}
});
stmt.executeUpdate("LISTEN mynotification");
// stmt.executeUpdate("NOTIFY mynotification");
Thread.sleep(30000);
org.postgresql.PGNotification[] notifications = conn.unwrap(org.postgresql.PGConnection.class).getNotifications();
//assertTrue(flag.get());
//assertNotNull(notifications);
//assertEquals(1, notifications.length);
//assertEquals("mynotification", notifications[0].getName());
//long endMillis = System.currentTimeMillis();
//long runtime = endMillis - startMillis;
//assertNull("There have been notifications, although none have been expected.",notifications);
//assertTrue("We didn't wait long enough! runtime=" + runtime, runtime > 450);
stmt.close();
}
Regards.Philippe EbersohlFrom: "Dave Cramer" <pg@fastcrypt.com>
To: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Wednesday, 27 February, 2019 11:53:59
Subject: Re: A method to asynchronously LISTEN ?On Wed, 27 Feb 2019 at 05:47, Philippe Ebersohl <philippe.ebersohl@dalim.com> wrote:Hello,I do not think there is a need for something like conn.listenSync().We were just intrigued about the test.In fact the current proposition should just work fine and we would like to test it.How could we have access to a postgresql-*.jdbc.jar that includes this feature ?Regards,PhilippeI just rebased it over the current code https://github.com/pgjdbc/pgjdbc/pull/579You should be able to build it manually using the commandline instructions to get the pullgit checkout -b davecramer-notify mastergit pull https://github.com/davecramer/pgjdbc.git notifythen use maven to build itFrom: "David G. Johnston" <david.g.johnston@gmail.com>
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Tuesday, 26 February, 2019 22:17:12
Subject: Re: A method to asynchronously LISTEN ?On Tue, Feb 26, 2019 at 12:04 PM Dave Cramer <pg@fastcrypt.com> wrote:On Tue, 26 Feb 2019 at 12:29, David G. Johnston <david.g.johnston@gmail.com> wrote:The question being asked is whether executeUpdate method performs synchronous execution of the listener function queue during its execution.This after sending the command to the server and the server completing execution of the NOTIFY. This assumes that the server places the notification on the channel for pick-up immediately (which will not be the case within a transaction).While the client is, IIRC, synchronous, thus the local order of operations can be controlled, the server is asynchronous and thus this test is exposed to timing issues. Maybe we need something like conn.listenSync() that blocks until a notification payload is received on the connection...?kind of defeats the asynchronous aspect, no ?You'd still want an asynchronous API for people but JavaScript introduced the "async/await" feature for a reason. In this case making it "sync" instead of coding up wait loop seems desirable. That said its quite possible I'm missing some existing feature as I haven't used this API at all.David J.
public void testNotify() throws SQLException, InterruptedException {
AtomicBoolean flag = new AtomicBoolean(false);
Statement stmt = conn.createStatement();
((PGConnection)conn).addNotificationListener(new PGNotificationListener() {
@Override
public void notification(PGNotification notification) {
System.out.println("Notification Received");
flag.set(true);
}
});
stmt.executeUpdate("LISTEN mynotification");
for (int i=0;i<30; i++) {
stmt.execute("select 1");
Thread.sleep(1000);
}
stmt.close();
On Mon, 11 Mar 2019 at 05:41, Philippe Ebersohl <philippe.ebersohl@dalim.com> wrote:Hello,could you pleas advise what is wrong in our testing ?We retrieved the git sources, build them.Modified the testNotify() as shown below.When performing "NOTIFY mynotification" from an SQL client, we do not see the "Notification received" message as expected.Thank you.Regards,Philippe EbersohlHello Phillipe,I will look at this as soon as possible. I am currently busy with other things.From: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Thursday, 28 February, 2019 10:52:44
Subject: Re: A method to asynchronously LISTEN ?Hello,we retrieved the sources.
After starting the testNotify() below, we execute from pgadmin : notify mynotification
But the listener is not notified.
Did we miss something ?
public void testNotify() throws SQLException, InterruptedException {
final AtomicBoolean flag = new AtomicBoolean(false);
Statement stmt = conn.createStatement();
((org.postgresql.PGConnection)conn).addNotificationListener(new org.postgresql.PGNotificationListener() {
@Override
public void notification(org.postgresql.PGNotification notification) {
flag.set(true);System.out.println("Notification received");
}
});
stmt.executeUpdate("LISTEN mynotification");
// stmt.executeUpdate("NOTIFY mynotification");
Thread.sleep(30000);
org.postgresql.PGNotification[] notifications = conn.unwrap(org.postgresql.PGConnection.class).getNotifications();
//assertTrue(flag.get());
//assertNotNull(notifications);
//assertEquals(1, notifications.length);
//assertEquals("mynotification", notifications[0].getName());
//long endMillis = System.currentTimeMillis();
//long runtime = endMillis - startMillis;
//assertNull("There have been notifications, although none have been expected.",notifications);
//assertTrue("We didn't wait long enough! runtime=" + runtime, runtime > 450);
stmt.close();
}
Regards.Philippe EbersohlFrom: "Dave Cramer" <pg@fastcrypt.com>
To: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Wednesday, 27 February, 2019 11:53:59
Subject: Re: A method to asynchronously LISTEN ?On Wed, 27 Feb 2019 at 05:47, Philippe Ebersohl <philippe.ebersohl@dalim.com> wrote:Hello,I do not think there is a need for something like conn.listenSync().We were just intrigued about the test.In fact the current proposition should just work fine and we would like to test it.How could we have access to a postgresql-*.jdbc.jar that includes this feature ?Regards,PhilippeI just rebased it over the current code https://github.com/pgjdbc/pgjdbc/pull/579You should be able to build it manually using the commandline instructions to get the pullgit checkout -b davecramer-notify mastergit pull https://github.com/davecramer/pgjdbc.git notifythen use maven to build itFrom: "David G. Johnston" <david.g.johnston@gmail.com>
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Tuesday, 26 February, 2019 22:17:12
Subject: Re: A method to asynchronously LISTEN ?On Tue, Feb 26, 2019 at 12:04 PM Dave Cramer <pg@fastcrypt.com> wrote:On Tue, 26 Feb 2019 at 12:29, David G. Johnston <david.g.johnston@gmail.com> wrote:The question being asked is whether executeUpdate method performs synchronous execution of the listener function queue during its execution.This after sending the command to the server and the server completing execution of the NOTIFY. This assumes that the server places the notification on the channel for pick-up immediately (which will not be the case within a transaction).While the client is, IIRC, synchronous, thus the local order of operations can be controlled, the server is asynchronous and thus this test is exposed to timing issues. Maybe we need something like conn.listenSync() that blocks until a notification payload is received on the connection...?kind of defeats the asynchronous aspect, no ?You'd still want an asynchronous API for people but JavaScript introduced the "async/await" feature for a reason. In this case making it "sync" instead of coding up wait loop seems desirable. That said its quite possible I'm missing some existing feature as I haven't used this API at all.David J.
To: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
Cc: "List" <pgsql-jdbc@postgresql.org>
Sent: Wednesday, 10 April, 2019 16:20:39
Subject: Re: A method to asynchronously LISTEN ?
public void testNotify() throws SQLException, InterruptedException {
AtomicBoolean flag = new AtomicBoolean(false);
Statement stmt = conn.createStatement();
((PGConnection)conn).addNotificationListener(new PGNotificationListener() {
@Override
public void notification(PGNotification notification) {
System.out.println("Notification Received");
flag.set(true);
}
});
stmt.executeUpdate("LISTEN mynotification");
for (int i=0;i<30; i++) {
stmt.execute("select 1");
Thread.sleep(1000);
}
stmt.close();
On Mon, 11 Mar 2019 at 05:41, Philippe Ebersohl <philippe.ebersohl@dalim.com> wrote:Hello,could you pleas advise what is wrong in our testing ?We retrieved the git sources, build them.Modified the testNotify() as shown below.When performing "NOTIFY mynotification" from an SQL client, we do not see the "Notification received" message as expected.Thank you.Regards,Philippe EbersohlHello Phillipe,I will look at this as soon as possible. I am currently busy with other things.From: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Thursday, 28 February, 2019 10:52:44
Subject: Re: A method to asynchronously LISTEN ?Hello,we retrieved the sources.
After starting the testNotify() below, we execute from pgadmin : notify mynotification
But the listener is not notified.
Did we miss something ?
public void testNotify() throws SQLException, InterruptedException {
final AtomicBoolean flag = new AtomicBoolean(false);
Statement stmt = conn.createStatement();
((org.postgresql.PGConnection)conn).addNotificationListener(new org.postgresql.PGNotificationListener() {
@Override
public void notification(org.postgresql.PGNotification notification) {
flag.set(true);System.out.println("Notification received");
}
});
stmt.executeUpdate("LISTEN mynotification");
// stmt.executeUpdate("NOTIFY mynotification");
Thread.sleep(30000);
org.postgresql.PGNotification[] notifications = conn.unwrap(org.postgresql.PGConnection.class).getNotifications();
//assertTrue(flag.get());
//assertNotNull(notifications);
//assertEquals(1, notifications.length);
//assertEquals("mynotification", notifications[0].getName());
//long endMillis = System.currentTimeMillis();
//long runtime = endMillis - startMillis;
//assertNull("There have been notifications, although none have been expected.",notifications);
//assertTrue("We didn't wait long enough! runtime=" + runtime, runtime > 450);
stmt.close();
}
Regards.Philippe EbersohlFrom: "Dave Cramer" <pg@fastcrypt.com>
To: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Wednesday, 27 February, 2019 11:53:59
Subject: Re: A method to asynchronously LISTEN ?On Wed, 27 Feb 2019 at 05:47, Philippe Ebersohl <philippe.ebersohl@dalim.com> wrote:Hello,I do not think there is a need for something like conn.listenSync().We were just intrigued about the test.In fact the current proposition should just work fine and we would like to test it.How could we have access to a postgresql-*.jdbc.jar that includes this feature ?Regards,PhilippeI just rebased it over the current code https://github.com/pgjdbc/pgjdbc/pull/579You should be able to build it manually using the commandline instructions to get the pullgit checkout -b davecramer-notify mastergit pull https://github.com/davecramer/pgjdbc.git notifythen use maven to build itFrom: "David G. Johnston" <david.g.johnston@gmail.com>
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Tuesday, 26 February, 2019 22:17:12
Subject: Re: A method to asynchronously LISTEN ?On Tue, Feb 26, 2019 at 12:04 PM Dave Cramer <pg@fastcrypt.com> wrote:On Tue, 26 Feb 2019 at 12:29, David G. Johnston <david.g.johnston@gmail.com> wrote:The question being asked is whether executeUpdate method performs synchronous execution of the listener function queue during its execution.This after sending the command to the server and the server completing execution of the NOTIFY. This assumes that the server places the notification on the channel for pick-up immediately (which will not be the case within a transaction).While the client is, IIRC, synchronous, thus the local order of operations can be controlled, the server is asynchronous and thus this test is exposed to timing issues. Maybe we need something like conn.listenSync() that blocks until a notification payload is received on the connection...?kind of defeats the asynchronous aspect, no ?You'd still want an asynchronous API for people but JavaScript introduced the "async/await" feature for a reason. In this case making it "sync" instead of coding up wait loop seems desirable. That said its quite possible I'm missing some existing feature as I haven't used this API at all.David J.
public void listen() throws SQLException {
PGNotificationListener listener = new PGNotificationListener() {
public void notification(int processId, String channelName, String payload) {
System.out.println("Received Notification: " + processId + ", " + channelName + ", " + payload);
}
public void closed() {
// initiate reconnection & restart listening
}
};
Statement statement = conn.createStatement();
statement.execute("LISTEN "+QNAME);
statement.close();
conn.addNotificationListener(listener);
System.out.println("Wait for events");
}
postgresNG.listen();
Object lock = new Object();
synchronized (lock)
{
lock.wait();
}
To: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
Cc: "List" <pgsql-jdbc@postgresql.org>
Sent: Wednesday, 10 April, 2019 16:20:39
Subject: Re: A method to asynchronously LISTEN ?
public void testNotify() throws SQLException, InterruptedException {
AtomicBoolean flag = new AtomicBoolean(false);
Statement stmt = conn.createStatement();
((PGConnection)conn).addNotificationListener(new PGNotificationListener() {
@Override
public void notification(PGNotification notification) {
System.out.println("Notification Received");
flag.set(true);
}
});
stmt.executeUpdate("LISTEN mynotification");
for (int i=0;i<30; i++) {
stmt.execute("select 1");
Thread.sleep(1000);
}
stmt.close();
On Mon, 11 Mar 2019 at 05:41, Philippe Ebersohl <philippe.ebersohl@dalim.com> wrote:Hello,could you pleas advise what is wrong in our testing ?We retrieved the git sources, build them.Modified the testNotify() as shown below.When performing "NOTIFY mynotification" from an SQL client, we do not see the "Notification received" message as expected.Thank you.Regards,Philippe EbersohlHello Phillipe,I will look at this as soon as possible. I am currently busy with other things.From: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Thursday, 28 February, 2019 10:52:44
Subject: Re: A method to asynchronously LISTEN ?Hello,we retrieved the sources.
After starting the testNotify() below, we execute from pgadmin : notify mynotification
But the listener is not notified.
Did we miss something ?
public void testNotify() throws SQLException, InterruptedException {
final AtomicBoolean flag = new AtomicBoolean(false);
Statement stmt = conn.createStatement();
((org.postgresql.PGConnection)conn).addNotificationListener(new org.postgresql.PGNotificationListener() {
@Override
public void notification(org.postgresql.PGNotification notification) {
flag.set(true);System.out.println("Notification received");
}
});
stmt.executeUpdate("LISTEN mynotification");
// stmt.executeUpdate("NOTIFY mynotification");
Thread.sleep(30000);
org.postgresql.PGNotification[] notifications = conn.unwrap(org.postgresql.PGConnection.class).getNotifications();
//assertTrue(flag.get());
//assertNotNull(notifications);
//assertEquals(1, notifications.length);
//assertEquals("mynotification", notifications[0].getName());
//long endMillis = System.currentTimeMillis();
//long runtime = endMillis - startMillis;
//assertNull("There have been notifications, although none have been expected.",notifications);
//assertTrue("We didn't wait long enough! runtime=" + runtime, runtime > 450);
stmt.close();
}
Regards.Philippe EbersohlFrom: "Dave Cramer" <pg@fastcrypt.com>
To: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Wednesday, 27 February, 2019 11:53:59
Subject: Re: A method to asynchronously LISTEN ?On Wed, 27 Feb 2019 at 05:47, Philippe Ebersohl <philippe.ebersohl@dalim.com> wrote:Hello,I do not think there is a need for something like conn.listenSync().We were just intrigued about the test.In fact the current proposition should just work fine and we would like to test it.How could we have access to a postgresql-*.jdbc.jar that includes this feature ?Regards,PhilippeI just rebased it over the current code https://github.com/pgjdbc/pgjdbc/pull/579You should be able to build it manually using the commandline instructions to get the pullgit checkout -b davecramer-notify mastergit pull https://github.com/davecramer/pgjdbc.git notifythen use maven to build itFrom: "David G. Johnston" <david.g.johnston@gmail.com>
To: "Dave Cramer" <pg@fastcrypt.com>
Cc: "Philippe Ebersohl" <philippe.ebersohl@dalim.com>, "List" <pgsql-jdbc@postgresql.org>
Sent: Tuesday, 26 February, 2019 22:17:12
Subject: Re: A method to asynchronously LISTEN ?On Tue, Feb 26, 2019 at 12:04 PM Dave Cramer <pg@fastcrypt.com> wrote:On Tue, 26 Feb 2019 at 12:29, David G. Johnston <david.g.johnston@gmail.com> wrote:The question being asked is whether executeUpdate method performs synchronous execution of the listener function queue during its execution.This after sending the command to the server and the server completing execution of the NOTIFY. This assumes that the server places the notification on the channel for pick-up immediately (which will not be the case within a transaction).While the client is, IIRC, synchronous, thus the local order of operations can be controlled, the server is asynchronous and thus this test is exposed to timing issues. Maybe we need something like conn.listenSync() that blocks until a notification payload is received on the connection...?kind of defeats the asynchronous aspect, no ?You'd still want an asynchronous API for people but JavaScript introduced the "async/await" feature for a reason. In this case making it "sync" instead of coding up wait loop seems desirable. That said its quite possible I'm missing some existing feature as I haven't used this API at all.David J.