Обсуждение: commitfest: When are you assigned patches to review?
Hi! I am new to this community. I have submitted few patches to this commitfest and I have read that it is expected that I also review some other patches. But I am not sure about the process here. Should I wait for some other patches to be assigned to me to review? Or is there some other process? Also, how is the level at which I should review it determined? I am not really too sure in my skills and understanding of PostgreSQL codebase to feel confident that I can review well, but I am willing to try. I have read [1] and [2]. [1] https://wiki.postgresql.org/wiki/CommitFest [2] https://wiki.postgresql.org/wiki/Reviewing_a_Patch Mitar -- http://mitar.tnode.com/ https://twitter.com/mitar_m
Hello Mitar, > I am new to this community. I have submitted few patches to this > commitfest and I have read that it is expected that I also review some > other patches. But I am not sure about the process here. Should I wait > for some other patches to be assigned to me to review? Or is there > some other process? The process is that *you* choose the patches to review and register as such for the patch on the CF app. > Also, how is the level at which I should review it > determined? Patches as complex as the one you submitted? Based on your area of expertise? > I am not really too sure in my skills and understanding of > PostgreSQL codebase to feel confident that I can review well, but I am > willing to try. I have read [1] and [2]. There are doc patches, client-side code patches, compilation infrastructure patches... -- Fabien.
Hi everyone! > 8 янв. 2019 г., в 14:14, Fabien COELHO <coelho@cri.ensmp.fr> написал(а): > > The process is that *you* choose the patches to review and register as such for the patch on the CF app. By the way, is it ok to negotiate review exchange? Best regards, Andrey Borodin.
On Wed, 9 Jan 2019 at 01:20, Andrey Borodin <x4mmm@yandex-team.ru> wrote: > By the way, is it ok to negotiate review exchange? I think it happens fairly often. There's no need for the list to know anything about it when it does. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
On Tue, Jan 08, 2019 at 10:14:10AM +0100, Fabien COELHO wrote: >> Also, how is the level at which I should review it >> determined? > > Patches as complex as the one you submitted? The usual expectation is to review one patch of equal difficulty for each patch submitted. The way to measure a patch difficulty is not based on actual facts but mostly on how a patch feels complicated. When it comes to reviews, the more you can look at the better of course, still doing a correct review takes time, and that can be surprising often even for so-said simple patches. > Based on your area of expertise? Taking new challenges on a regular basis is not bad either :) -- Michael
Вложения
Hi! Few more questions. I see that some patches were sent to bugs mailing list, not hackers [1]. I thought that all patches have to be send to the hackers mailing list, as per this wiki page [2]. Moreover, because they were send to the bugs mailing list, I am unsure how can it be discussed/reviewed on hackers mailing list while keeping the thread, as per this wiki page [3]. Furthermore, I thought that each commitfest entry should be about one patch, but [1] seems to provide 3 patches, with multiple versions, which makes it a bit unclear to understand which one and how should they apply. [1] https://commitfest.postgresql.org/21/1924/ [2] https://wiki.postgresql.org/wiki/Submitting_a_Patch [3] https://wiki.postgresql.org/wiki/CommitFest Mitar
On Tue, Jan 08, 2019 at 10:56:32PM -0800, Mitar wrote: > I see that some patches were sent to bugs mailing list, not hackers > [1]. I thought that all patches have to be send to the hackers mailing > list, as per this wiki page [2]. Moreover, because they were send to > the bugs mailing list, I am unsure how can it be discussed/reviewed on > hackers mailing list while keeping the thread, as per this wiki page > [3]. Furthermore, I thought that each commitfest entry should be about > one patch, but [1] seems to provide 3 patches, with multiple versions, > which makes it a bit unclear to understand which one and how should > they apply. That's not a strict process per se. Sometimes when discussing we finish by splitting a patch into multiple ones where it makes sense, and the factor which mainly matters is to keep a commit history clean. Keeping that point in mind we may have one commit fest entry dealing with one of more patches depending on how the author feels things should be handled. My take is that additional CF entries make sense when working on patches which require a different audience and a different kind of reviews, while refactoring and preparatory work may be included with a main patch as long as the patch set remains in roughly the same area of expertise and keeps close to the concept of the thread dealing with a new feature. Bugs can be added as CF entries, posting patches on a bug ticket is also fine. If a bug fix needs more input, moving it to -hackers can also make sense by changing on the way its subject. This depends on the circumstances and that's a case-by-case handling usually. > [1] https://commitfest.postgresql.org/21/1924/ This item is fun to work with, though all of them apply to unaccent and are not that invasive, so a single entry looks fine IMO. -- Michael