Обсуждение: Re: Win32 question: getppid() with no paren

Поиск
Список
Период
Сортировка

Re: Win32 question: getppid() with no paren

От
Claudio Natoli
Дата:
Tom Lane wrote:
> Great.  Could I get someone to implement this now?  The function that
> needs it is PostmasterIsAlive() in src/backend/storage/ipc/pmsignal.c.
> You can check whether it works by noting whether the stats processes
> shut down when the postmaster goes away ...

Here you go. If there is a better place to put the PostmasterHandle, please
do so by all means.  Also, could enable it for EXEC_BACKEND, instead of for
WIN32, which would obviate the WIN32 #ifdefs in read/write_backend_variables
(ie. so that EXEC_BACKEND would also read/write this variable out, but to no
effect in non-WIN32 EXEC_BACKENDs).

Cheers,
Claudio

---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>



Вложения

Re: Win32 question: getppid() with no paren t?

От
Tom Lane
Дата:
Claudio Natoli <claudio.natoli@memetrics.com> writes:
> Tom Lane wrote:
>> Great.  Could I get someone to implement this now?

> Here you go.

Applied, thanks.

> If there is a better place to put the PostmasterHandle, please
> do so by all means.

I thought it was okay there, but should be declared in postmaster.h;
I dislike externs in .c files, because there's no chance of the compiler
catching discrepancies.

>  Also, could enable it for EXEC_BACKEND, instead of for
> WIN32,

Not unless HANDLE is a typedef of wider currency than I thought...

            regards, tom lane