Обсуждение: [pgadmin-hackers][patch] Move to Alembic migration system
Hi Hackers!
Here's a patch to move to current db migration system to use Alembic. Instructions to create new migrations are in the README.
Here's a patch to move to current db migration system to use Alembic. Instructions to create new migrations are in the README.
Thanks!
Joao & Sarah
Joao & Sarah
Вложения
Hi Hackers!
It looks like our previous patch messed up some logging. Please use this one instead.
It looks like our previous patch messed up some logging. Please use this one instead.
Thanks,
Joao & Sarah
On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
Hi Hackers!
Here's a patch to move to current db migration system to use Alembic. Instructions to create new migrations are in the README.Thanks!
Joao & Sarah
Вложения
Ashesh, can you review/commit this please? One thing I notice on a quick look through is that the file headers are missing everywhere. They should be present in all source files, except where they would bloat the data transfer from client to server. On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote: > Hi Hackers! > > It looks like our previous patch messed up some logging. Please use this one > instead. > > Thanks, > Joao & Sarah > > > > On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote: >> >> Hi Hackers! >> >> Here's a patch to move to current db migration system to use Alembic. >> Instructions to create new migrations are in the README. >> >> Thanks! >> Joao & Sarah >> > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.
Thanks!
Joao & Sarah
Joao & Sarah
On Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Re: [pgadmin-hackers][patch] Move to Alembic migration system
От
Joao Pedro De Almeida Pereira
Дата:
Hello Hackers,
We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.
Also we would like to know the status of this.
Thanks
Joao & Sarah
On Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:
Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Hello Dave and Ashesh,
Do you still need us to provide more information about this patch or is it ready to be merged?
Thanks
Joao
On Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Joao & Sarah,
I have asked Murtuza to review the patch today.
He will update me by EOD.
If all goes well, I will commit the patch.
On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Ashesh,
Patch looks good to me.
--
Regards,
On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi,
PFA minor add-on patch for README.
--
Regards,
On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Hi,
We've updated Murtuza's README change to be more consistent with other instructions - adding a colon and newline.
-Matt and George
On Fri, Mar 31, 2017 at 10:47 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Вложения
Hi Jaoao, Sarah,
I've tried to run on fresh machine, it failed with the below error:
$ python setup.py
NOTE: Configuring authentication for SERVER mode.
Enter the email address and password to use for the initial pgAdmin user account:
Email address: ashesh.vashi@enterprisedb.com
Traceback (most recent call last):
File "setup.py", line 52, in <module>
db_upgrade(app)
File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/db_upgrade.py", line 25, in db_upgrade
flask_migrate.upgrade(migration_folder)
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/flask_migrate/__init__.py", line 244, in upgrade
command.upgrade(config, revision, sql=sql, tag=tag)
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/command.py", line 254, in upgrade
script.run_env()
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/script/base.py", line 416, in run_env
util.load_python_file(self.dir, 'env.py')
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/util/pyfiles.py", line 93, in load_python_file
module = load_module_py(module_id, path)
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/util/compat.py", line 75, in load_module_py
mod = imp.load_source(module_id, path, fp)
File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/../../migrations/env.py", line 85, in <module>
run_migrations_online()
File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/../../migrations/env.py", line 78, in run_migrations_online
context.run_migrations()
File "<string>", line 8, in run_migrations
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/runtime/environment.py", line 817, in run_migrations
self.get_context().run_migrations(**kw)
File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/python2.7/site-packages/alembic/runtime/migration.py", line 323, in run_migrations
step.migration_fn(**kw)
File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/migrations/versions/fdc58d9bd449_.py", line 84, in upgrade
email, password = user_info()
File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadmin/setup/user_info.py", line 50, in user_info
email = input("Email address: ")
File "<string>", line 1
^
SyntaxError: invalid syntax
On Fri, Mar 31, 2017 at 8:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Jaoao, Sarah,I've tried to run on fresh machine, it failed with the below error:
And - I have noticed - the headers are missing in new files.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
$ python setup.pyNOTE: Configuring authentication for SERVER mode.Enter the email address and password to use for the initial pgAdmin user account:Email address: ashesh.vashi@enterprisedb.comTraceback (most recent call last):File "setup.py", line 52, in <module>db_upgrade(app)File "/Users/asheshvashi/Developments/Projects/ pgAdmin4/web/pgadmin/setup/db_ upgrade.py", line 25, in db_upgrade flask_migrate.upgrade(migration_folder) File "/Users/asheshvashi/Developments/WorkPlace/ pgAdmin4/lib/python2.7/site- packages/flask_migrate/__init_ _.py", line 244, in upgrade command.upgrade(config, revision, sql=sql, tag=tag)File "/Users/asheshvashi/Developments/WorkPlace/ pgAdmin4/lib/python2.7/site- packages/alembic/command.py", line 254, in upgrade script.run_env()File "/Users/asheshvashi/Developments/WorkPlace/ pgAdmin4/lib/python2.7/site- packages/alembic/script/base. py", line 416, in run_env util.load_python_file(self.dir, 'env.py') File "/Users/asheshvashi/Developments/WorkPlace/ pgAdmin4/lib/python2.7/site- packages/alembic/util/pyfiles. py", line 93, in load_python_file module = load_module_py(module_id, path)File "/Users/asheshvashi/Developments/WorkPlace/ pgAdmin4/lib/python2.7/site- packages/alembic/util/compat. py", line 75, in load_module_py mod = imp.load_source(module_id, path, fp)File "/Users/asheshvashi/Developments/Projects/ pgAdmin4/web/pgadmin/setup/../ ../migrations/env.py", line 85, in <module> run_migrations_online()File "/Users/asheshvashi/Developments/Projects/ pgAdmin4/web/pgadmin/setup/../ ../migrations/env.py", line 78, in run_migrations_online context.run_migrations()File "<string>", line 8, in run_migrationsFile "/Users/asheshvashi/Developments/WorkPlace/ pgAdmin4/lib/python2.7/site- packages/alembic/runtime/ environment.py", line 817, in run_migrations self.get_context().run_migrations(**kw) File "/Users/asheshvashi/Developments/WorkPlace/ pgAdmin4/lib/python2.7/site- packages/alembic/runtime/ migration.py", line 323, in run_migrations step.migration_fn(**kw)File "/Users/asheshvashi/Developments/Projects/ pgAdmin4/web/migrations/ versions/fdc58d9bd449_.py", line 84, in upgrade email, password = user_info()File "/Users/asheshvashi/Developments/Projects/ pgAdmin4/web/pgadmin/setup/ user_info.py", line 50, in user_info email = input("Email address: ")File "<string>", line 1^SyntaxError: invalid syntaxOn Fri, Mar 31, 2017 at 8:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Hi Ashesh!
Good catch. Looks like there was an override of the input function that didn't get moved to the new file, causing the input with the @ to fail. We also added headers to the files that were missing them. This new patch should work.
Thanks!
Joao & Sarah
Joao & Sarah
On Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Jaoao, Sarah,I've tried to run on fresh machine, it failed with the below error:And - I have noticed - the headers are missing in new files.--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
$ python setup.pyNOTE: Configuring authentication for SERVER mode.Enter the email address and password to use for the initial pgAdmin user account:Email address: ashesh.vashi@enterprisedb.comTraceback (most recent call last):File "setup.py", line 52, in <module>db_upgrade(app)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/ pgadmin/setup/db_upgrade.py", line 25, in db_upgrade flask_migrate.upgrade(migration_folder) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/ python2.7/site-packages/flask_ migrate/__init__.py", line 244, in upgrade command.upgrade(config, revision, sql=sql, tag=tag)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/ python2.7/site-packages/ alembic/command.py", line 254, in upgrade script.run_env()File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/ python2.7/site-packages/ alembic/script/base.py", line 416, in run_env util.load_python_file(self.dir, 'env.py') File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/ python2.7/site-packages/ alembic/util/pyfiles.py", line 93, in load_python_file module = load_module_py(module_id, path)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/ python2.7/site-packages/ alembic/util/compat.py", line 75, in load_module_py mod = imp.load_source(module_id, path, fp)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/ pgadmin/setup/../../ migrations/env.py", line 85, in <module> run_migrations_online()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/ pgadmin/setup/../../ migrations/env.py", line 78, in run_migrations_online context.run_migrations()File "<string>", line 8, in run_migrationsFile "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/ python2.7/site-packages/ alembic/runtime/environment. py", line 817, in run_migrations self.get_context().run_migrations(**kw) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/ python2.7/site-packages/ alembic/runtime/migration.py", line 323, in run_migrations step.migration_fn(**kw)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/ migrations/versions/ fdc58d9bd449_.py", line 84, in upgrade email, password = user_info()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/ pgadmin/setup/user_info.py", line 50, in user_info email = input("Email address: ")File "<string>", line 1^SyntaxError: invalid syntaxOn Fri, Mar 31, 2017 at 8:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Hi Hackers!
Is there an update on this?
Thanks,
Sarah & Joao
On Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear <smcalear@pivotal.io> wrote:
Hi Ashesh!Good catch. Looks like there was an override of the input function that didn't get moved to the new file, causing the input with the @ to fail. We also added headers to the files that were missing them. This new patch should work.Thanks!
Joao & SarahOn Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Jaoao, Sarah,I've tried to run on fresh machine, it failed with the below error:And - I have noticed - the headers are missing in new files.--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
$ python setup.pyNOTE: Configuring authentication for SERVER mode.Enter the email address and password to use for the initial pgAdmin user account:Email address: ashesh.vashi@enterprisedb.comTraceback (most recent call last):File "setup.py", line 52, in <module>db_upgrade(app)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/db_upgrade.py", line 25, in db_upgrade flask_migrate.upgrade(migration_folder) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/flask_migr ate/__init__.py", line 244, in upgrade command.upgrade(config, revision, sql=sql, tag=tag)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ command.py", line 254, in upgrade script.run_env()File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ script/base.py", line 416, in run_env util.load_python_file(self.dir, 'env.py') File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ util/pyfiles.py", line 93, in load_python_file module = load_module_py(module_id, path)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ util/compat.py", line 75, in load_module_py mod = imp.load_source(module_id, path, fp)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 85, in <module> run_migrations_online()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 78, in run_migrations_online context.run_migrations()File "<string>", line 8, in run_migrationsFile "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ runtime/environment.py", line 817, in run_migrations self.get_context().run_migrations(**kw) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ runtime/migration.py", line 323, in run_migrations step.migration_fn(**kw)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/migra tions/versions/fdc58d9bd449_. py", line 84, in upgrade email, password = user_info()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/user_info.py", line 50, in user_info email = input("Email address: ")File "<string>", line 1^SyntaxError: invalid syntaxOn Fri, Mar 31, 2017 at 8:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
Hi Hackers!
Hi Sarah,
Is there an update on this?
We will look in to it end of this week.
I was not rushing to it, because - Dave was preparing for the 1.4 release.
-- Thanks, Ashesh
Thanks,Sarah & JoaoOn Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Ashesh!Good catch. Looks like there was an override of the input function that didn't get moved to the new file, causing the input with the @ to fail. We also added headers to the files that were missing them. This new patch should work.Thanks!
Joao & SarahOn Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Jaoao, Sarah,I've tried to run on fresh machine, it failed with the below error:And - I have noticed - the headers are missing in new files.--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
$ python setup.pyNOTE: Configuring authentication for SERVER mode.Enter the email address and password to use for the initial pgAdmin user account:Email address: ashesh.vashi@enterprisedb.comTraceback (most recent call last):File "setup.py", line 52, in <module>db_upgrade(app)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/db_upgrade.py", line 25, in db_upgrade flask_migrate.upgrade(migration_folder) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/flask_migr ate/__init__.py", line 244, in upgrade command.upgrade(config, revision, sql=sql, tag=tag)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/co mmand.py", line 254, in upgrade script.run_env()File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/sc ript/base.py", line 416, in run_env util.load_python_file(self.dir, 'env.py') File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/pyfiles.py", line 93, in load_python_file module = load_module_py(module_id, path)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/compat.py", line 75, in load_module_py mod = imp.load_source(module_id, path, fp)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 85, in <module> run_migrations_online()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 78, in run_migrations_online context.run_migrations()File "<string>", line 8, in run_migrationsFile "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/environment.py", line 817, in run_migrations self.get_context().run_migrations(**kw) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/migration.py", line 323, in run_migrations step.migration_fn(**kw)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/migra tions/versions/fdc58d9bd449_.p y", line 84, in upgrade email, password = user_info()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/user_info.py", line 50, in user_info email = input("Email address: ")File "<string>", line 1^SyntaxError: invalid syntaxOn Fri, Mar 31, 2017 at 8:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Great, thank you so much!
On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Hackers!Hi Sarah,Is there an update on this?We will look in to it end of this week.I was not rushing to it, because - Dave was preparing for the 1.4 release.-- Thanks, AsheshThanks,Sarah & JoaoOn Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Ashesh!Good catch. Looks like there was an override of the input function that didn't get moved to the new file, causing the input with the @ to fail. We also added headers to the files that were missing them. This new patch should work.Thanks!
Joao & SarahOn Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Jaoao, Sarah,I've tried to run on fresh machine, it failed with the below error:And - I have noticed - the headers are missing in new files.--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
$ python setup.pyNOTE: Configuring authentication for SERVER mode.Enter the email address and password to use for the initial pgAdmin user account:Email address: ashesh.vashi@enterprisedb.comTraceback (most recent call last):File "setup.py", line 52, in <module>db_upgrade(app)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/db_upgrade.py", line 25, in db_upgrade flask_migrate.upgrade(migration_folder) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/flask_migr ate/__init__.py", line 244, in upgrade command.upgrade(config, revision, sql=sql, tag=tag)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/co mmand.py", line 254, in upgrade script.run_env()File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/sc ript/base.py", line 416, in run_env util.load_python_file(self.dir, 'env.py') File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/pyfiles.py", line 93, in load_python_file module = load_module_py(module_id, path)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/compat.py", line 75, in load_module_py mod = imp.load_source(module_id, path, fp)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 85, in <module> run_migrations_online()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 78, in run_migrations_online context.run_migrations()File "<string>", line 8, in run_migrationsFile "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/environment.py", line 817, in run_migrations self.get_context().run_migrations(**kw) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/migration.py", line 323, in run_migrations step.migration_fn(**kw)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/migra tions/versions/fdc58d9bd449_.p y", line 84, in upgrade email, password = user_info()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/user_info.py", line 50, in user_info email = input("Email address: ")File "<string>", line 1^SyntaxError: invalid syntaxOn Fri, Mar 31, 2017 at 8:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: [pgadmin-hackers][patch] Move to Alembic migration system
От
Joao Pedro De Almeida Pereira
Дата:
Hello Ashesh,
Did you had time to review this patch?
Thanks
Joao & Oliver
On Wed, Apr 12, 2017 at 9:52 AM, Sarah McAlear <smcalear@pivotal.io> wrote:
Great, thank you so much!On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Hackers!Hi Sarah,Is there an update on this?We will look in to it end of this week.I was not rushing to it, because - Dave was preparing for the 1.4 release.-- Thanks, AsheshThanks,Sarah & JoaoOn Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Ashesh!Good catch. Looks like there was an override of the input function that didn't get moved to the new file, causing the input with the @ to fail. We also added headers to the files that were missing them. This new patch should work.Thanks!
Joao & SarahOn Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Jaoao, Sarah,I've tried to run on fresh machine, it failed with the below error:And - I have noticed - the headers are missing in new files.--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
$ python setup.pyNOTE: Configuring authentication for SERVER mode.Enter the email address and password to use for the initial pgAdmin user account:Email address: ashesh.vashi@enterprisedb.comTraceback (most recent call last):File "setup.py", line 52, in <module>db_upgrade(app)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/db_upgrade.py", line 25, in db_upgrade flask_migrate.upgrade(migration_folder) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/flask_migr ate/__init__.py", line 244, in upgrade command.upgrade(config, revision, sql=sql, tag=tag)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/co mmand.py", line 254, in upgrade script.run_env()File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/sc ript/base.py", line 416, in run_env util.load_python_file(self.dir, 'env.py') File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/pyfiles.py", line 93, in load_python_file module = load_module_py(module_id, path)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/compat.py", line 75, in load_module_py mod = imp.load_source(module_id, path, fp)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 85, in <module> run_migrations_online()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 78, in run_migrations_online context.run_migrations()File "<string>", line 8, in run_migrationsFile "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/environment.py", line 817, in run_migrations self.get_context().run_migrations(**kw) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/migration.py", line 323, in run_migrations step.migration_fn(**kw)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/migra tions/versions/fdc58d9bd449_.p y", line 84, in upgrade email, password = user_info()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/user_info.py", line 50, in user_info email = input("Email address: ")File "<string>", line 1^SyntaxError: invalid syntaxOn Fri, Mar 31, 2017 at 8:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Apr 20, 2017 at 8:15 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Ashesh,Did you had time to review this patch?
Yes - I did.
Please my review comments:
Everytime I start pgAdmin 4, I am getting now the following message:
"pgAdmin 4 - Application Initialisation"
Can we avoid that message?
We are not providing any information during upgrade process.
i.e. older version was so, and so, it will be upgraded to so, and so.
It helps sometimes to while debugging the application.
Rest looks fine to me.
-- Thanks, Ashesh
ThanksJoao & OliverOn Wed, Apr 12, 2017 at 9:52 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Great, thank you so much!On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Hackers!Hi Sarah,Is there an update on this?We will look in to it end of this week.I was not rushing to it, because - Dave was preparing for the 1.4 release.-- Thanks, AsheshThanks,Sarah & JoaoOn Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Ashesh!Good catch. Looks like there was an override of the input function that didn't get moved to the new file, causing the input with the @ to fail. We also added headers to the files that were missing them. This new patch should work.Thanks!
Joao & SarahOn Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Jaoao, Sarah,I've tried to run on fresh machine, it failed with the below error:And - I have noticed - the headers are missing in new files.--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
$ python setup.pyNOTE: Configuring authentication for SERVER mode.Enter the email address and password to use for the initial pgAdmin user account:Email address: ashesh.vashi@enterprisedb.comTraceback (most recent call last):File "setup.py", line 52, in <module>db_upgrade(app)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/db_upgrade.py", line 25, in db_upgrade flask_migrate.upgrade(migration_folder) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/flask_migr ate/__init__.py", line 244, in upgrade command.upgrade(config, revision, sql=sql, tag=tag)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/co mmand.py", line 254, in upgrade script.run_env()File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/sc ript/base.py", line 416, in run_env util.load_python_file(self.dir, 'env.py') File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/pyfiles.py", line 93, in load_python_file module = load_module_py(module_id, path)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/compat.py", line 75, in load_module_py mod = imp.load_source(module_id, path, fp)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 85, in <module> run_migrations_online()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 78, in run_migrations_online context.run_migrations()File "<string>", line 8, in run_migrationsFile "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/environment.py", line 817, in run_migrations self.get_context().run_migrations(**kw) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/migration.py", line 323, in run_migrations step.migration_fn(**kw)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/migra tions/versions/fdc58d9bd449_.p y", line 84, in upgrade email, password = user_info()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/user_info.py", line 50, in user_info email = input("Email address: ")File "<string>", line 1^SyntaxError: invalid syntaxOn Fri, Mar 31, 2017 at 8:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: [pgadmin-hackers][patch] Move to Alembic migration system
От
Joao Pedro De Almeida Pereira
Дата:
Hello Hackers,
@Ashesh thanks for the feedback
Here is the reviewed patch with the suggestions of Ashesh.
Disclaimer: We added a new patch file with the changes
Thanks
Joao & Oliver
On Thu, Apr 20, 2017 at 10:56 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Thu, Apr 20, 2017 at 8:15 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Ashesh,Did you had time to review this patch?Yes - I did.Please my review comments:Everytime I start pgAdmin 4, I am getting now the following message:"pgAdmin 4 - Application Initialisation"Can we avoid that message?We are not providing any information during upgrade process.i.e. older version was so, and so, it will be upgraded to so, and so.It helps sometimes to while debugging the application.Rest looks fine to me.-- Thanks, AsheshThanksJoao & OliverOn Wed, Apr 12, 2017 at 9:52 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Great, thank you so much!On Wed, Apr 12, 2017 at 9:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Wed, Apr 12, 2017 at 7:07 PM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Hackers!Hi Sarah,Is there an update on this?We will look in to it end of this week.I was not rushing to it, because - Dave was preparing for the 1.4 release.-- Thanks, AsheshThanks,Sarah & JoaoOn Fri, Apr 7, 2017 at 10:27 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi Ashesh!Good catch. Looks like there was an override of the input function that didn't get moved to the new file, causing the input with the @ to fail. We also added headers to the files that were missing them. This new patch should work.Thanks!
Joao & SarahOn Mon, Apr 3, 2017 at 8:41 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: On Mon, Apr 3, 2017 at 12:09 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Jaoao, Sarah,I've tried to run on fresh machine, it failed with the below error:And - I have noticed - the headers are missing in new files.--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
$ python setup.pyNOTE: Configuring authentication for SERVER mode.Enter the email address and password to use for the initial pgAdmin user account:Email address: ashesh.vashi@enterprisedb.comTraceback (most recent call last):File "setup.py", line 52, in <module>db_upgrade(app)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/db_upgrade.py", line 25, in db_upgrade flask_migrate.upgrade(migration_folder) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/flask_migr ate/__init__.py", line 244, in upgrade command.upgrade(config, revision, sql=sql, tag=tag)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/co mmand.py", line 254, in upgrade script.run_env()File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/sc ript/base.py", line 416, in run_env util.load_python_file(self.dir, 'env.py') File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/pyfiles.py", line 93, in load_python_file module = load_module_py(module_id, path)File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ut il/compat.py", line 75, in load_module_py mod = imp.load_source(module_id, path, fp)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 85, in <module> run_migrations_online()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/../../migrations/env. py", line 78, in run_migrations_online context.run_migrations()File "<string>", line 8, in run_migrationsFile "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/environment.py", line 817, in run_migrations self.get_context().run_migrations(**kw) File "/Users/asheshvashi/Developments/WorkPlace/pgAdmin4/lib/pyth on2.7/site-packages/alembic/ru ntime/migration.py", line 323, in run_migrations step.migration_fn(**kw)File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/migra tions/versions/fdc58d9bd449_.p y", line 84, in upgrade email, password = user_info()File "/Users/asheshvashi/Developments/Projects/pgAdmin4/web/pgadm in/setup/user_info.py", line 50, in user_info email = input("Email address: ")File "<string>", line 1^SyntaxError: invalid syntaxOn Fri, Mar 31, 2017 at 8:17 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA minor add-on patch for README.--Regards,On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi Ashesh,Patch looks good to me.--Regards,On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Sarah,I have asked Murtuza to review the patch today.He will update me by EOD.If all goes well, I will commit the patch.On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Dave and Ashesh,Do you still need us to provide more information about this patch or is it ready to be merged?ThanksJoaoOn Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We found out a issue using Python 3 related to importing modules that we corrected in the patch that is now attached.Also we would like to know the status of this.ThanksJoao & SarahOn Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear@pivotal.io> wrote:Hi!
We realized that this change was causing the tests to fail because the folder for the sqlite databases was not being created. We also updated the files to contain the missing headers.Thanks!
Joao & SarahOn Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh, can you review/commit this please? One thing I notice on a
quick look through is that the file headers are missing everywhere.
They should be present in all source files, except where they would
bloat the data transfer from client to server.> --
On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
> Hi Hackers!
>
> It looks like our previous patch messed up some logging. Please use this one
> instead.
>
> Thanks,
> Joao & Sarah
>
>
>
> On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> Here's a patch to move to current db migration system to use Alembic.
>> Instructions to create new migrations are in the README.
>>
>> Thanks!
>> Joao & Sarah
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Hi Joao & Oliver,
On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Hackers,@Ashesh thanks for the feedbackHere is the reviewed patch with the suggestions of Ashesh.Disclaimer: We added a new patch file with the changes
I have made some more changes to the patch.
- 'with app.app_context(..)' statement was not required in the 'web/pgadmin/__init__.py' as we're already doing that in the do_upgrade function.
- We also need to create other directories (i.e. sessions, storage, directory containing the log-file) during the setup/running the application (if not exists).
- Added proper check in the pgAdmin4.wsgi file (if configuration file exists, or not)
Please review it.
-- Thanks, Ashesh
Вложения
Re: [pgadmin-hackers][patch] Move to Alembic migration system
От
Joao Pedro De Almeida Pereira
Дата:
Hello Hackers,
We review the patch, just noticed a spelling issue so we regenerated the patch.
Thanks
Joao & Oliver
On Fri, Apr 21, 2017 at 1:21 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Joao & Oliver,On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,@Ashesh thanks for the feedbackHere is the reviewed patch with the suggestions of Ashesh.Disclaimer: We added a new patch file with the changesI have made some more changes to the patch.- 'with app.app_context(..)' statement was not required in the 'web/pgadmin/__init__.py' as we're already doing that in the do_upgrade function.- We also need to create other directories (i.e. sessions, storage, directory containing the log-file) during the setup/running the application (if not exists).- Added proper check in the pgAdmin4.wsgi file (if configuration file exists, or not)Please review it.-- Thanks, Ashesh
Вложения
On Fri, Apr 21, 2017 at 7:59 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Hackers,We review the patch, just noticed a spelling issue so we regenerated the patch.
Thanks.
Your patch was missing README changes. :-)
Committed after adding the necessary changes.
-- Thanks,
Ashesh Vashi
ThanksJoao & OliverOn Fri, Apr 21, 2017 at 1:21 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Oliver,On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,@Ashesh thanks for the feedbackHere is the reviewed patch with the suggestions of Ashesh.Disclaimer: We added a new patch file with the changesI have made some more changes to the patch.- 'with app.app_context(..)' statement was not required in the 'web/pgadmin/__init__.py' as we're already doing that in the do_upgrade function.- We also need to create other directories (i.e. sessions, storage, directory containing the log-file) during the setup/running the application (if not exists).- Added proper check in the pgAdmin4.wsgi file (if configuration file exists, or not)Please review it.-- Thanks, Ashesh
Awesome, thank you for adding that back in!
On Sun, Apr 23, 2017 at 11:17 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Fri, Apr 21, 2017 at 7:59 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,We review the patch, just noticed a spelling issue so we regenerated the patch.Thanks.Your patch was missing README changes. :-)Committed after adding the necessary changes.-- Thanks,Ashesh VashiThanksJoao & OliverOn Fri, Apr 21, 2017 at 1:21 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: Hi Joao & Oliver,On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hello Hackers,@Ashesh thanks for the feedbackHere is the reviewed patch with the suggestions of Ashesh.Disclaimer: We added a new patch file with the changesI have made some more changes to the patch.- 'with app.app_context(..)' statement was not required in the 'web/pgadmin/__init__.py' as we're already doing that in the do_upgrade function.- We also need to create other directories (i.e. sessions, storage, directory containing the log-file) during the setup/running the application (if not exists).- Added proper check in the pgAdmin4.wsgi file (if configuration file exists, or not)Please review it.-- Thanks, Ashesh