Re: [pgadmin-hackers][patch] Move to Alembic migration system

Поиск
Список
Период
Сортировка
От Ashesh Vashi
Тема Re: [pgadmin-hackers][patch] Move to Alembic migration system
Дата
Msg-id CAG7mmoxoP+iQuy_03q3A4SHskdwMjyU3AwR52SwYpZ_98mCRsg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin-hackers][patch] Move to Alembic migration system  (Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io>)
Ответы Re: [pgadmin-hackers][patch] Move to Alembic migration system
Список pgadmin-hackers
Дерево обсуждения
Hi Joao & Oliver,

On Fri, Apr 21, 2017 at 3:39 AM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Hackers,

@Ashesh thanks for the feedback

Here is the reviewed patch with the suggestions of Ashesh.

Disclaimer: We added a new patch file with the changes 
 
I have made some more changes to the patch.
- 'with app.app_context(..)' statement was not required in the 'web/pgadmin/__init__.py' as we're already doing that in the do_upgrade function.
- We also need to create other directories (i.e. sessions, storage, directory containing the log-file) during the setup/running the application (if not exists).
- Added proper check in the pgAdmin4.wsgi file (if configuration file exists, or not)

Please review it.

-- Thanks, Ashesh

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Khushboo Vashi
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM #2339 - Horizontalscrolling in the treeview
Следующее
От: Murtuza Zabuawala
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue withdisplaying bigint[] values in query tool