Обсуждение: BUG #14334: vacuumdb.c build failure on openbsd
VGhlIGZvbGxvd2luZyBidWcgaGFzIGJlZW4gbG9nZ2VkIG9uIHRoZSB3ZWJz aXRlOgoKQnVnIHJlZmVyZW5jZTogICAgICAxNDMzNApMb2dnZWQgYnk6ICAg ICAgICAgIHNlYW4gZmFycmVsbApFbWFpbCBhZGRyZXNzOiAgICAgIGp1bmds ZWJvb2dpZTArcHNxbEBnbWFpbC5jb20KUG9zdGdyZVNRTCB2ZXJzaW9uOiA5 LjZyYzEKT3BlcmF0aW5nIHN5c3RlbTogICBvcGVuYnNkIGN1cnJlbnQKRGVz Y3JpcHRpb246ICAgICAgICAKCkhlbGxvLA0KDQpJJ20gYXR0ZW1wdGluZyB0 byBidWlsZCBwb3N0Z3Jlc3FsIG9uIE9wZW5CU0QgY3VycmVudCB3aXRoIHRo aXMgY29uZmlnCm9wdGlvbjoNCi4vY29uZmlndXJlIC0tZW5hYmxlLWNhc3Nl cnQgLS1lbmFibGUtZGVidWcgIC0td2l0aC1wZXJsIFwNCiAgICAgICAgLS13 aXRoLXB5dGhvbiAtLXdpdGgtdGNsIC0td2l0aC1vcGVuc3NsICAtLXdpdGgt bGlieG1sIFwNCiAgICAgICAgLS13aXRoLWxpYnhzbHQgLS13aXRoLWluY2x1 ZGVzPS91c3IvbG9jYWwvaW5jbHVkZQ0KDQoNCg0KSGVyZSdzIHBhcnQgb2Yg dGhlIGJ1aWxkIHdoZXJlIGl0IGZhaWxzOg0KZ21ha2VbNV06IEVudGVyaW5n IGRpcmVjdG9yeSAnL2hvbWUvc2Vhbi9iaW4vcG9zdGdyZXMvc3JjL2JhY2tl bmQnDQpnbWFrZVs1XTogTm90aGluZyB0byBiZSBkb25lIGZvciAnc3VibWFr ZS1lcnJjb2RlcycuDQpnbWFrZVs1XTogTGVhdmluZyBkaXJlY3RvcnkgJy9o b21lL3NlYW4vYmluL3Bvc3RncmVzL3NyYy9iYWNrZW5kJw0KZ21ha2VbNF06 IExlYXZpbmcgZGlyZWN0b3J5ICcvaG9tZS9zZWFuL2Jpbi9wb3N0Z3Jlcy9z cmMvcG9ydCcNCi91c3IvbG9jYWwvYmluL2dtYWtlIC1DIC4uLy4uLy4uL3Ny Yy9jb21tb24gYWxsDQpnbWFrZVs0XTogRW50ZXJpbmcgZGlyZWN0b3J5ICcv aG9tZS9zZWFuL2Jpbi9wb3N0Z3Jlcy9zcmMvY29tbW9uJw0KL3Vzci9sb2Nh bC9iaW4vZ21ha2UgLUMgLi4vYmFja2VuZCBzdWJtYWtlLWVycmNvZGVzDQpn bWFrZVs1XTogRW50ZXJpbmcgZGlyZWN0b3J5ICcvaG9tZS9zZWFuL2Jpbi9w b3N0Z3Jlcy9zcmMvYmFja2VuZCcNCmdtYWtlWzVdOiBOb3RoaW5nIHRvIGJl IGRvbmUgZm9yICdzdWJtYWtlLWVycmNvZGVzJy4NCmdtYWtlWzVdOiBMZWF2 aW5nIGRpcmVjdG9yeSAnL2hvbWUvc2Vhbi9iaW4vcG9zdGdyZXMvc3JjL2Jh Y2tlbmQnDQpnbWFrZVs0XTogTGVhdmluZyBkaXJlY3RvcnkgJy9ob21lL3Nl YW4vYmluL3Bvc3RncmVzL3NyYy9jb21tb24nDQovdXNyL2xvY2FsL2Jpbi9n bWFrZSAtQyAuLi8uLi8uLi9zcmMvZmVfdXRpbHMgYWxsDQpnbWFrZVs0XTog RW50ZXJpbmcgZGlyZWN0b3J5ICcvaG9tZS9zZWFuL2Jpbi9wb3N0Z3Jlcy9z cmMvZmVfdXRpbHMnDQpnbWFrZVs0XTogTm90aGluZyB0byBiZSBkb25lIGZv ciAnYWxsJy4NCmdtYWtlWzRdOiBMZWF2aW5nIGRpcmVjdG9yeSAnL2hvbWUv c2Vhbi9iaW4vcG9zdGdyZXMvc3JjL2ZlX3V0aWxzJw0KZ2NjIC1XYWxsIC1X bWlzc2luZy1wcm90b3R5cGVzIC1XcG9pbnRlci1hcml0aCAtV2RlY2xhcmF0 aW9uLWFmdGVyLXN0YXRlbWVudAotV2VuZGlmLWxhYmVscyAtV21pc3Npbmct Zm9ybWF0LWF0dHJpYnV0ZSAtV2Zvcm1hdC1zZWN1cml0eQotZm5vLXN0cmlj dC1hbGlhc2luZyAtZndyYXB2IC1nIC1PMiAtSS4uLy4uLy4uL3NyYy9pbnRl cmZhY2VzL2xpYnBxCi1JLi4vLi4vLi4vc3JjL2luY2x1ZGUgLUkvdXNyL2xv Y2FsL2luY2x1ZGUvbGlieG1sMiAtSS91c3IvbG9jYWwvaW5jbHVkZSAKLUkv dXNyL2xvY2FsL2luY2x1ZGUgIC1jIC1vIHZhY3V1bWRiLm8gdmFjdXVtZGIu Yw0KdmFjdXVtZGIuYzo3MDogZXJyb3I6IGV4cGVjdGVkIGRlY2xhcmF0aW9u IHNwZWNpZmllcnMgb3IgJy4uLicgYmVmb3JlCidmZF9zZXQnDQp2YWN1dW1k Yi5jOiBJbiBmdW5jdGlvbiAnbWFpbic6DQp2YWN1dW1kYi5jOjE5MzogZXJy b3I6ICdGRF9TRVRTSVpFJyB1bmRlY2xhcmVkIChmaXJzdCB1c2UgaW4gdGhp cwpmdW5jdGlvbikNCnZhY3V1bWRiLmM6MTkzOiBlcnJvcjogKEVhY2ggdW5k ZWNsYXJlZCBpZGVudGlmaWVyIGlzIHJlcG9ydGVkIG9ubHkgb25jZQ0KdmFj dXVtZGIuYzoxOTM6IGVycm9yOiBmb3IgZWFjaCBmdW5jdGlvbiBpdCBhcHBl YXJzIGluLikNCnZhY3V1bWRiLmM6IEluIGZ1bmN0aW9uICdHZXRJZGxlU2xv dCc6DQp2YWN1dW1kYi5jOjczMzogZXJyb3I6ICdmZF9zZXQnIHVuZGVjbGFy ZWQgKGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0aW9uKQ0KdmFjdXVtZGIuYzo3 MzM6IGVycm9yOiBleHBlY3RlZCAnOycgYmVmb3JlICdzbG90c2V0Jw0KdmFj dXVtZGIuYzo3MzQ6IHdhcm5pbmc6IElTTyBDOTAgZm9yYmlkcyBtaXhlZCBk ZWNsYXJhdGlvbnMgYW5kIGNvZGUNCnZhY3V1bWRiLmM6NzQwOiB3YXJuaW5n OiBpbXBsaWNpdCBkZWNsYXJhdGlvbiBvZiBmdW5jdGlvbiAnRkRfWkVSTycN CnZhY3V1bWRiLmM6NzQwOiBlcnJvcjogJ3Nsb3RzZXQnIHVuZGVjbGFyZWQg KGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0aW9uKQ0KdmFjdXVtZGIuYzo3NDU6 IHdhcm5pbmc6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9uICdG RF9TRVQnDQp2YWN1dW1kYi5jOjc1OTogZXJyb3I6IHRvbyBtYW55IGFyZ3Vt ZW50cyB0byBmdW5jdGlvbiAnc2VsZWN0X2xvb3AnDQp2YWN1dW1kYi5jOjc3 NTogd2FybmluZzogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g J0ZEX0lTU0VUJw0KdmFjdXVtZGIuYzogQXQgdG9wIGxldmVsOg0KdmFjdXVt ZGIuYzo4NzA6IGVycm9yOiBleHBlY3RlZCBkZWNsYXJhdGlvbiBzcGVjaWZp ZXJzIG9yICcuLi4nIGJlZm9yZQonZmRfc2V0Jw0KdmFjdXVtZGIuYzogSW4g ZnVuY3Rpb24gJ3NlbGVjdF9sb29wJzoNCnZhY3V1bWRiLmM6ODczOiBlcnJv cjogJ2ZkX3NldCcgdW5kZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVu Y3Rpb24pDQp2YWN1dW1kYi5jOjg3MzogZXJyb3I6IGV4cGVjdGVkICc7JyBi ZWZvcmUgJ3NhdmVTZXQnDQp2YWN1dW1kYi5jOjg5ODogZXJyb3I6ICd3b3Jr ZXJzZXQnIHVuZGVjbGFyZWQgKGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0aW9u KQ0KdmFjdXVtZGIuYzo4OTg6IGVycm9yOiAnc2F2ZVNldCcgdW5kZWNsYXJl ZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pDQp2YWN1dW1kYi5jOjg5 OTogd2FybmluZzogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g J3NlbGVjdCcNCmdtYWtlWzNdOiAqKiogWzxidWlsdGluPjogdmFjdXVtZGIu b10gRXJyb3IgMQ0KZ21ha2VbM106IExlYXZpbmcgZGlyZWN0b3J5ICcvaG9t ZS9zZWFuL2Jpbi9wb3N0Z3Jlcy9zcmMvYmluL3NjcmlwdHMnDQpnbWFrZVsy XTogKioqIFtNYWtlZmlsZTo0MDogYWxsLXNjcmlwdHMtcmVjdXJzZV0gRXJy b3IgMg0KZ21ha2VbMl06IExlYXZpbmcgZGlyZWN0b3J5ICcvaG9tZS9zZWFu L2Jpbi9wb3N0Z3Jlcy9zcmMvYmluJw0KZ21ha2VbMV06ICoqKiBbTWFrZWZp bGU6MzU6IGFsbC1iaW4tcmVjdXJzZV0gRXJyb3IgMg0KZ21ha2VbMV06IExl YXZpbmcgZGlyZWN0b3J5ICcvaG9tZS9zZWFuL2Jpbi9wb3N0Z3Jlcy9zcmMn DQpnbWFrZTogKioqIFtHTlVtYWtlZmlsZToxMTogYWxsLXNyYy1yZWN1cnNl XSBFcnJvciAyDQoqKiogRXJyb3IgMiBpbiAvaG9tZS9zZWFuL2Jpbi9wb3N0 Z3JlcyAoTWFrZWZpbGU6MzYgJ2FsbCcpICANCg0KDQoNClZhY3V1bWRiLmMg d2FzIGxhc3QgdXBkYXRlZCBlYXJsaWVyIGxhc3QgbW9udGg6DQpodHRwczov L2dpdGh1Yi5jb20vcG9zdGdyZXMvcG9zdGdyZXMvY29tbWl0cy9tYXN0ZXIv c3JjL2Jpbi9zY3JpcHRzL3ZhY3V1bWRiLmMNCg0KDQoNCklzIHRoZXJlIHNv bWV0aGluZyBJIG5lZWQgdG8gZG8gZGlmZmVyZW50bHkgdG8gZ2V0IFBvc3Rn cmVzcWwgdG8gYnVpbGQ/DQoNCg0KDQpDdXJyZW50bHkgaW5zdGFsbGVkOg0K IyBzZWxlY3QgdmVyc2lvbigpOw0KICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHZlcnNpb24NCi0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCiBQb3N0Z3JlU1FM IDEwZGV2ZWwgb24gaTM4Ni11bmtub3duLW9wZW5ic2Q2LjAsIGNvbXBpbGVk IGJ5IGdjYyAoR0NDKSA0LjIuMQoyMDA3MDcxOSAsIDMyLWJpdA0KDQoNCg0K VGhhbmtzLA0KU2VhbgoK
jungleboogie0+psql@gmail.com wrote:
> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement
> -Wendif-labels -Wmissing-format-attribute -Wformat-security
> -fno-strict-aliasing -fwrapv -g -O2 -I../../../src/interfaces/libpq
> -I../../../src/include -I/usr/local/include/libxml2 -I/usr/local/include
> -I/usr/local/include -c -o vacuumdb.o vacuumdb.c
> vacuumdb.c:70: error: expected declaration specifiers or '...' before
> 'fd_set'
> vacuumdb.c: In function 'main':
> vacuumdb.c:193: error: 'FD_SETSIZE' undeclared (first use in this
> function)
What does your select(2) manpage say about what includes are required?
My manpage says
/* According to POSIX.1-2001 */
#include <sys/select.h>
/* According to earlier standards */
#include <sys/time.h>
#include <sys/types.h>
#include <unistd.h>
and we're not including <sys/select.h> anywhere that I can see;
apparently we should add something like
#ifdef HAVE_SYS_SELECT_H
#include <sys/select.h>
#endif
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Hi Alvaro, On 21 September 2016 at 10:57, Alvaro Herrera <alvherre@2ndquadrant.com> wr= ote: > jungleboogie0+psql@gmail.com wrote: > >> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-state= ment >> -Wendif-labels -Wmissing-format-attribute -Wformat-security >> -fno-strict-aliasing -fwrapv -g -O2 -I../../../src/interfaces/libpq >> -I../../../src/include -I/usr/local/include/libxml2 -I/usr/local/include >> -I/usr/local/include -c -o vacuumdb.o vacuumdb.c >> vacuumdb.c:70: error: expected declaration specifiers or '...' before >> 'fd_set' >> vacuumdb.c: In function 'main': >> vacuumdb.c:193: error: 'FD_SETSIZE' undeclared (first use in this >> function) > > What does your select(2) manpage say about what includes are required? > My manpage says > > /* According to POSIX.1-2001 */ > #include <sys/select.h> > > /* According to earlier standards */ > #include <sys/time.h> > #include <sys/types.h> > #include <unistd.h> > http://man.openbsd.org/OpenBSD-current/man2/select.2 Also has #include <sys/select.h> I'm checking out commit https://github.com/postgres/postgres/commit/be7f7ee5ea73626c037600b515087e8= f98038140 (day for the vacuum changes) to see if this will build. If not, maybe it was a change within openbsd. > and we're not including <sys/select.h> anywhere that I can see; > apparently we should add something like > > #ifdef HAVE_SYS_SELECT_H > #include <sys/select.h> > #endif > > -- > =C3=81lvaro Herrera https://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --=20 ------- inum: 883510009027723 sip: jungleboogie@sip2sip.info
jungle Boogie wrote: > http://man.openbsd.org/OpenBSD-current/man2/select.2 > > Also has #include <sys/select.h> So "current" is 6.0? We don't have a lot of OpenBSD machines in the buildfarm; would you be able to contribute one? The one we have (curculio) runs 5.9 and has been running fine with the committed code. https://wiki.postgresql.org/wiki/Buildfarm It makes portability work easier if we see right away that a commit has broken something. Can you try HEAD with the following patch applied and let me know if it works? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Вложения
Hi Alvaro, On 21 September 2016 at 12:22, Alvaro Herrera <alvherre@2ndquadrant.com> wr= ote: > jungle Boogie wrote: > >> http://man.openbsd.org/OpenBSD-current/man2/select.2 >> >> Also has #include <sys/select.h> > > So "current" is 6.0? We don't have a lot of OpenBSD machines in the > buildfarm; would you be able to contribute one? The one we have > (curculio) runs 5.9 and has been running fine with the committed code. > https://wiki.postgresql.org/wiki/Buildfarm > 6.0 is a release version and will only receive patches for the base OS. -current/snapshot is what I'm running and it's the development version of openbsd. In a few months, current will be marked and released as 6.1. Basically I'm following the development branch of OpenBSD: http://www.openbsd.org/faq/current.html > It makes portability work easier if we see right away that a commit has > broken something. > > Can you try HEAD with the following patch applied and let me know if it > works? I wrote to the maintainer of postgresql on openbsd and asked if he could take a look at this email and see if he can reproduce the problem. Meanwhile, I came across this. It looks like 8 days ago select.h was modified, but I have no idea if this is causing the postgresql failure. http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/sys/select.h I will checkout buildfarm and see what it takes to run it! > > -- > =C3=81lvaro Herrera https://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --=20 ------- inum: 883510009027723 sip: jungleboogie@sip2sip.info
jungle Boogie wrote: > Hi Alvaro, > On 21 September 2016 at 12:22, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > > So "current" is 6.0? We don't have a lot of OpenBSD machines in the > > buildfarm; would you be able to contribute one? The one we have > > (curculio) runs 5.9 and has been running fine with the committed code. > > https://wiki.postgresql.org/wiki/Buildfarm > > 6.0 is a release version and will only receive patches for the base OS. I see. > -current/snapshot is what I'm running and it's the development version > of openbsd. In a few months, current will be marked and released as > 6.1. Basically I'm following the development branch of OpenBSD: > http://www.openbsd.org/faq/current.html I think it'd be valuable to have a system running something that tracks "current"; we already have a few "rolling" Linux distros and this seems similar in spirit. It might even provide more feedback for those crazy patches ... > > Can you try HEAD with the following patch applied and let me know if it > > works? > > I wrote to the maintainer of postgresql on openbsd and asked if he > could take a look at this email and see if he can reproduce the > problem. Good. > Meanwhile, I came across this. > It looks like 8 days ago select.h was modified, but I have no idea if > this is causing the postgresql failure. > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/sys/select.h Sounds very likely to me. > I will checkout buildfarm and see what it takes to run it! Great. It's just a cron Perl script that builds Postgres and runs the tests (plus a commitment that you'll give a look in case things fail for odd reasons. We try not to bother you if your animal finds portability issues in Postgres.) -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 21 September 2016 at 12:22, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > Can you try HEAD with the following patch applied and let me know if it > works? Your patch works!! You probably made the patch on a Windows system because there were ^M characters but I copied your three lines to vacuumdb.c and recompiled. Is there a method to report the exact git commit postgresql is running? -- ------- inum: 883510009027723 sip: jungleboogie@sip2sip.info
jungle Boogie wrote: > On 21 September 2016 at 12:22, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > > Can you try HEAD with the following patch applied and let me know if it > > works? > > Your patch works!! > > You probably made the patch on a Windows system because there were ^M > characters but I copied your three lines to vacuumdb.c and recompiled. Windows!?!? I haven't touched that in two decades now (oh my). I just ":read" the patch file into the email body instead of using an attachment. I got lazy there, sorry about that. Anyway thanks for following up. I will push this, probably tomorrow. > Is there a method to report the exact git commit postgresql is running? Not that I know of. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Alvaro Herrera wrote: > jungle Boogie wrote: > > On 21 September 2016 at 12:22, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > > > Can you try HEAD with the following patch applied and let me know if it > > > works? > > > > Your patch works!! > > > > You probably made the patch on a Windows system because there were ^M > > characters but I copied your three lines to vacuumdb.c and recompiled. > Anyway thanks for following up. I will push this, probably tomorrow. It took me a few more days than I intended, which meant this missed 9.6.0, but it's out now. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 26 September 2016 at 21:09, Alvaro Herrera <alvherre@2ndquadrant.com> wr= ote: > Alvaro Herrera wrote: >> jungle Boogie wrote: >> > On 21 September 2016 at 12:22, Alvaro Herrera <alvherre@2ndquadrant.co= m> wrote: >> > > Can you try HEAD with the following patch applied and let me know if= it >> > > works? >> > >> > Your patch works!! >> > >> > You probably made the patch on a Windows system because there were ^M >> > characters but I copied your three lines to vacuumdb.c and recompiled. > >> Anyway thanks for following up. I will push this, probably tomorrow. > > It took me a few more days than I intended, which meant this missed > 9.6.0, but it's out now. > I don't know what the will mean in terms of the OpenBSD package/port of it, but I'll let the maintainer know that it's now patched in Postgres. By the way, I updated to Postgres' master and installed without problems. Thanks for quickly patching it! I haven't forgotten about the buildfarm! Best, sean > -- > =C3=81lvaro Herrera https://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --=20 ------- inum: 883510009027723 sip: jungleboogie@sip2sip.info