Обсуждение: Patch for text.css

Hi,

Could someone please look into applying this patch? The current style in http://www.postgresql.org/layout/css/blue/text.css sets the visited and non-visited link colors to be the same.  This patch fixes them to be different so this navigation aid is restored.

Matt

--- text.css.orig    2007-01-05 11:56:37.295915200 -0800
+++ text.css    2007-01-05 11:57:27.347886400 -0800
@@ -129,7 +129,7 @@
 /* Link Styles */
 
 a:link                          { color:#0085B0; text-decoration: underline; }
-a:visited                       { color:#0085B0; text-decoration: underline; }
+a:visited                       { color:#004E66; text-decoration: underline; }
 a:active                        { color:#0085B0; text-decoration: underline; }
 a:hover                         { color:#000000; text-decoration: underline; }
 

in principle  i like it, but there was a reason it was there. anyond know  why? Objections to changing it1?

/Magnus

------- Original message -------
From: Matt Perry <perrym3@gmail.com>
Sent: 1-5-'07,  12:04

> Hi,
>
> Could someone please look into applying this patch? The current style in
http://www.postgresql.org/layout/css/blue/text.csssets the visited and non-visited  
link colors to be the same.  This patch fixes them to be different so this navigation aid is restored.
>
> Matt
>
> --- text.css.orig    2007-01-05 11:56:37.295915200 -0800
> +++ text.css    2007-01-05 11:57:27.347886400 -0800
> @@ -129,7 +129,7 @@
>  /* Link Styles */
>
>  a:link                          { color:#0085B0; text-decoration: underline; }
> -a:visited                       { color:#0085B0; text-decoration: underline; }
> +a:visited                       { color:#004E66; text-decoration: underline; }
>  a:active                        { color:#0085B0; text-decoration: underline; }
>  a:hover                         { color:#000000; text-decoration: underline; }
>
>

"Magnus Hagander" <magnus@hagander.net> writes:
> in principle  i like it, but there was a reason it was there. anyond know  why? Objections to changing it1?

Surely it was just a typo --- I can't believe anyone would intentionally
hide the difference between visited and unvisited links.  The question
though is what two colors we want to use.

            regards, tom lane

On Saturday 06 January 2007 12:48, Tom Lane wrote:
> "Magnus Hagander" <magnus@hagander.net> writes:
> > in principle  i like it, but there was a reason it was there. anyond know
> >  why? Objections to changing it1?
>
> Surely it was just a typo --- I can't believe anyone would intentionally
> hide the difference between visited and unvisited links.  The question
> though is what two colors we want to use.
>

I'd be more surprised if it wasn't done intentionally; web designers use this
technique all the time, claiming it adds a more consitent color scheme / look
to the website.  Usability analysts will tell you that anything you think you
gain in asthetics is lost in breaking the standard color conventions people
are used to. The above patch sets visited links as a darker/paler blue; if we
are going to change it I'd suggest going with the standard purple color (or
something very similar).

--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL

Robert Treat wrote:
> On Saturday 06 January 2007 12:48, Tom Lane wrote:
>> "Magnus Hagander" <magnus@hagander.net> writes:
>>> in principle  i like it, but there was a reason it was there. anyond know
>>>  why? Objections to changing it1?
>> Surely it was just a typo --- I can't believe anyone would intentionally
>> hide the difference between visited and unvisited links.  The question
>> though is what two colors we want to use.
>>
>
> I'd be more surprised if it wasn't done intentionally; web designers use this
> technique all the time, claiming it adds a more consitent color scheme / look
> to the website.  Usability analysts will tell you that anything you think you
> gain in asthetics is lost in breaking the standard color conventions people
> are used to. The above patch sets visited links as a darker/paler blue; if we
> are going to change it I'd suggest going with the standard purple color (or
> something very similar).

Or should we perhaps just stop setting a color at all on it? That would
let the browser choose color? I don't know how common it is for people
to change the colors of the links, but I'm sure some do... And then we'd
just go with whatever the browser had?

//Magnus

Magnus Hagander <magnus@hagander.net> writes:
> Or should we perhaps just stop setting a color at all on it? That would
> let the browser choose color?

I wouldn't vote for that; the odds are good that the browser's defaults
would look ugly, or maybe even be nearly invisible against our
backgrounds.  We *should* set the link colors ... just not to the same
thing.

            regards, tom lane

On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
> > Or should we perhaps just stop setting a color at all on it? That would
> > let the browser choose color?
>
> I wouldn't vote for that; the odds are good that the browser's defaults
> would look ugly, or maybe even be nearly invisible against our
> backgrounds.  We *should* set the link colors ... just not to the same
> thing.

I've applied the patch to http://magnus-master.pgadmin.org with the
color as suggested, for review.

Thoughts? Different color? Suggestions?

//Magnus

Magnus Hagander wrote:
> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
>> Magnus Hagander <magnus@hagander.net> writes:
>>> Or should we perhaps just stop setting a color at all on it? That would
>>> let the browser choose color?
>> I wouldn't vote for that; the odds are good that the browser's defaults
>> would look ugly, or maybe even be nearly invisible against our
>> backgrounds.  We *should* set the link colors ... just not to the same
>> thing.
>
> I've applied the patch to http://magnus-master.pgadmin.org with the
> color as suggested, for review.
>
> Thoughts? Different color? Suggestions?

Looks fine to me.

/D

On Monday 08 January 2007 11:20, Magnus Hagander wrote:
> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
> > Magnus Hagander <magnus@hagander.net> writes:
> > > Or should we perhaps just stop setting a color at all on it? That would
> > > let the browser choose color?
> >
> > I wouldn't vote for that; the odds are good that the browser's defaults
> > would look ugly, or maybe even be nearly invisible against our
> > backgrounds.  We *should* set the link colors ... just not to the same
> > thing.
>
> I've applied the patch to http://magnus-master.pgadmin.org with the
> color as suggested, for review.
>
> Thoughts? Different color? Suggestions?
>

I had a hard time differentiating it last night, so I changed it to use the
standard color on http://xzilla.postgresql.org just to get a different look.
Anyone interested in comparing can check it out.

--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL

On 8 Jan 2007 at 23:58, Robert Treat wrote:

> On Monday 08 January 2007 11:20, Magnus Hagander wrote:
> > On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
> > > Magnus Hagander <magnus@hagander.net> writes:
> > > > Or should we perhaps just stop setting a color at all on it? That would
> > > > let the browser choose color?
> > >
> > > I wouldn't vote for that; the odds are good that the browser's defaults
> > > would look ugly, or maybe even be nearly invisible against our
> > > backgrounds.  We *should* set the link colors ... just not to the same
> > > thing.
> >
> > I've applied the patch to http://magnus-master.pgadmin.org with the
> > color as suggested, for review.
> >
> > Thoughts? Different color? Suggestions?
> >
>
> I had a hard time differentiating it last night, so I changed it to use the
> standard color on http://xzilla.postgresql.org just to get a different look.
> Anyone interested in comparing can check it out.

FWIW, I'm slightly colour blind.  I see the differences in the first
one better.

--
Dan Langille : Software Developer looking for work
my resume: http://www.freebsddiary.org/dan_langille.php
PGCon - The PostgreSQL Conference - http://www.pgcon.org/

Robert Treat wrote:
> On Monday 08 January 2007 11:20, Magnus Hagander wrote:
>> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
>>> Magnus Hagander <magnus@hagander.net> writes:
>>>> Or should we perhaps just stop setting a color at all on it? That would
>>>> let the browser choose color?
>>> I wouldn't vote for that; the odds are good that the browser's defaults
>>> would look ugly, or maybe even be nearly invisible against our
>>> backgrounds.  We *should* set the link colors ... just not to the same
>>> thing.
>> I've applied the patch to http://magnus-master.pgadmin.org with the
>> color as suggested, for review.
>>
>> Thoughts? Different color? Suggestions?
>>
>
> I had a hard time differentiating it last night, so I changed it to use the
> standard color on http://xzilla.postgresql.org just to get a different look.
> Anyone interested in comparing can check it out.

I personally think yours is clearer, but I'm a bit concerned on the
third opinion ;-) Anybody else care to chime in?

//Magnus

> > I had a hard time differentiating it last night, so I changed it to use the
> > standard color on http://xzilla.postgresql.org just to get a different look.
> > Anyone interested in comparing can check it out.
>
> I personally think yours is clearer, but I'm a bit concerned on the
> third opinion ;-) Anybody else care to chime in?

None you have any clue ;)

Joshua D. Drake


P.S. You can now ignore the third opinion and move forward :)



>
> //Magnus
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
>        choose an index scan if your joining column's datatypes do not
>        match
>
--

      === The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
Providing the most comprehensive  PostgreSQL solutions since 1997
             http://www.commandprompt.com/

Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate

Are we going to apply this?

---------------------------------------------------------------------------

Magnus Hagander wrote:
> Robert Treat wrote:
> > On Monday 08 January 2007 11:20, Magnus Hagander wrote:
> >> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
> >>> Magnus Hagander <magnus@hagander.net> writes:
> >>>> Or should we perhaps just stop setting a color at all on it? That would
> >>>> let the browser choose color?
> >>> I wouldn't vote for that; the odds are good that the browser's defaults
> >>> would look ugly, or maybe even be nearly invisible against our
> >>> backgrounds.  We *should* set the link colors ... just not to the same
> >>> thing.
> >> I've applied the patch to http://magnus-master.pgadmin.org with the
> >> color as suggested, for review.
> >>
> >> Thoughts? Different color? Suggestions?
> >>
> >
> > I had a hard time differentiating it last night, so I changed it to use the
> > standard color on http://xzilla.postgresql.org just to get a different look.
> > Anyone interested in comparing can check it out.
>
> I personally think yours is clearer, but I'm a bit concerned on the
> third opinion ;-) Anybody else care to chime in?
>
> //Magnus
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
>        choose an index scan if your joining column's datatypes do not
>        match

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

I was hoping someone else would comment on which one of the two they
preferred before we committed it. And then I promptly forgot about it ;-)

So, which one do people prefer?

//Magnus


Bruce Momjian wrote:
> Are we going to apply this?
>
> ---------------------------------------------------------------------------
>
> Magnus Hagander wrote:
>> Robert Treat wrote:
>>> On Monday 08 January 2007 11:20, Magnus Hagander wrote:
>>>> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
>>>>> Magnus Hagander <magnus@hagander.net> writes:
>>>>>> Or should we perhaps just stop setting a color at all on it? That would
>>>>>> let the browser choose color?
>>>>> I wouldn't vote for that; the odds are good that the browser's defaults
>>>>> would look ugly, or maybe even be nearly invisible against our
>>>>> backgrounds.  We *should* set the link colors ... just not to the same
>>>>> thing.
>>>> I've applied the patch to http://magnus-master.pgadmin.org with the
>>>> color as suggested, for review.
>>>>
>>>> Thoughts? Different color? Suggestions?
>>>>
>>> I had a hard time differentiating it last night, so I changed it to use the
>>> standard color on http://xzilla.postgresql.org just to get a different look.
>>> Anyone interested in comparing can check it out.
>> I personally think yours is clearer, but I'm a bit concerned on the
>> third opinion ;-) Anybody else care to chime in?
>>
>> //Magnus
>>
>> ---------------------------(end of broadcast)---------------------------
>> TIP 9: In versions below 8.0, the planner will ignore your desire to
>>        choose an index scan if your joining column's datatypes do not
>>        match
>

I think the feedback was that using the standard colors was too likely
to look bad on the web site.  Perhaps you should just increase the
different between the blues on your version and commit it, and then ask
for more feedback.

---------------------------------------------------------------------------

Magnus Hagander wrote:
> I was hoping someone else would comment on which one of the two they
> preferred before we committed it. And then I promptly forgot about it ;-)
>
> So, which one do people prefer?
>
> //Magnus
>
>
> Bruce Momjian wrote:
> > Are we going to apply this?
> >
> > ---------------------------------------------------------------------------
> >
> > Magnus Hagander wrote:
> >> Robert Treat wrote:
> >>> On Monday 08 January 2007 11:20, Magnus Hagander wrote:
> >>>> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
> >>>>> Magnus Hagander <magnus@hagander.net> writes:
> >>>>>> Or should we perhaps just stop setting a color at all on it? That would
> >>>>>> let the browser choose color?
> >>>>> I wouldn't vote for that; the odds are good that the browser's defaults
> >>>>> would look ugly, or maybe even be nearly invisible against our
> >>>>> backgrounds.  We *should* set the link colors ... just not to the same
> >>>>> thing.
> >>>> I've applied the patch to http://magnus-master.pgadmin.org with the
> >>>> color as suggested, for review.
> >>>>
> >>>> Thoughts? Different color? Suggestions?
> >>>>
> >>> I had a hard time differentiating it last night, so I changed it to use the
> >>> standard color on http://xzilla.postgresql.org just to get a different look.
> >>> Anyone interested in comparing can check it out.
> >> I personally think yours is clearer, but I'm a bit concerned on the
> >> third opinion ;-) Anybody else care to chime in?
> >>
> >> //Magnus
> >>
> >> ---------------------------(end of broadcast)---------------------------
> >> TIP 9: In versions below 8.0, the planner will ignore your desire to
> >>        choose an index scan if your joining column's datatypes do not
> >>        match
> >

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

On 1/20/07, Bruce Momjian <bruce@momjian.us> wrote:
>
> Perhaps you should just increase the
> different between the blues on your version and commit it, and then ask
> for more feedback.

Is there any chance that this could be deployed soon?

Matt

On Wednesday 31 January 2007 14:15, Matt Perry wrote:
> On 1/20/07, Bruce Momjian <bruce@momjian.us> wrote:
> > Perhaps you should just increase the
> > different between the blues on your version and commit it, and then ask
> > for more feedback.
>
> Is there any chance that this could be deployed soon?
>

Did you have an opinion on the quasi-blue vs standard colors? I'm inclined to 
commit the stand colors unless you speak up. 

-- 
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL

Robert Treat wrote:
> On Wednesday 31 January 2007 14:15, Matt Perry wrote:
> > On 1/20/07, Bruce Momjian <bruce@momjian.us> wrote:
> > > Perhaps you should just increase the
> > > different between the blues on your version and commit it, and then ask
> > > for more feedback.
> >
> > Is there any chance that this could be deployed soon?
> >
> 
> Did you have an opinion on the quasi-blue vs standard colors? I'm inclined to 
> commit the stand colors unless you speak up. 

I think the consensus was that the quasi-blue was better than using
standard because the standard might not look good on our site.

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +

Robert Treat wrote:
> On Wednesday 31 January 2007 14:15, Matt Perry wrote:
> > On 1/20/07, Bruce Momjian <bruce@momjian.us> wrote:
> > > Perhaps you should just increase the
> > > different between the blues on your version and commit it, and then ask
> > > for more feedback.
> >
> > Is there any chance that this could be deployed soon?
> >
> 
> Did you have an opinion on the quasi-blue vs standard colors? I'm inclined to 
> commit the stand colors unless you speak up. 

Looks like this has been applied.

--  Bruce Momjian   bruce@momjian.us Homepage        http://momjian.us EnterpriseDB    http://www.enterprisedb.com + If
yourlife is a hard drive, Christ can be your backup. +
 

On Tuesday 06 February 2007 13:59, Bruce Momjian wrote:
> Robert Treat wrote:
> > On Wednesday 31 January 2007 14:15, Matt Perry wrote:
> > > On 1/20/07, Bruce Momjian <bruce@momjian.us> wrote:
> > > > Perhaps you should just increase the
> > > > different between the blues on your version and commit it, and then
> > > > ask for more feedback.
> > >
> > > Is there any chance that this could be deployed soon?
> >
> > Did you have an opinion on the quasi-blue vs standard colors? I'm
> > inclined to commit the stand colors unless you speak up.
>
> Looks like this has been applied.

Yep, I applied it a few days ago. :-)

-- 
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL

Robert Treat wrote:
> On Tuesday 06 February 2007 13:59, Bruce Momjian wrote:
> > Robert Treat wrote:
> > > On Wednesday 31 January 2007 14:15, Matt Perry wrote:
> > > > On 1/20/07, Bruce Momjian <bruce@momjian.us> wrote:
> > > > > Perhaps you should just increase the
> > > > > different between the blues on your version and commit it, and then
> > > > > ask for more feedback.
> > > >
> > > > Is there any chance that this could be deployed soon?
> > >
> > > Did you have an opinion on the quasi-blue vs standard colors? I'm
> > > inclined to commit the stand colors unless you speak up.
> >
> > Looks like this has been applied.
> 
> Yep, I applied it a few days ago. :-)

Looks good.

--  Bruce Momjian   bruce@momjian.us Homepage        http://momjian.us EnterpriseDB    http://www.enterprisedb.com + If
yourlife is a hard drive, Christ can be your backup. +